In some cases, the svn author names might contain leading or trailing
whitespaces, leading to messages such as:
Author: user1
not defined in authors.txt
(the trailing newline leads to the line break). The user "user1" is
defined in authors.txt though, e.g.
user1 = User
Fix this by trimm
On 2019-09-12 at 16:47:41 +0200, Eric Sunshine wrote:
> On Thu, Sep 12, 2019 at 7:59 AM Tobias Klauser wrote:
> > In some cases, the svn author names might contain leading or trailing
> > whitespaces, leading to messages such as:
> >
> > Author: user1
> >not defined in authors.txt
> >
> > (
On Thu, Sep 12, 2019 at 7:59 AM Tobias Klauser wrote:
> In some cases, the svn author names might contain leading or trailing
> whitespaces, leading to messages such as:
>
> Author: user1
>not defined in authors.txt
>
> (the trailing newline leads to the line break). The user "user1" is
> de
In some cases, the svn author names might contain leading or trailing
whitespaces, leading to messages such as:
Author: user1
not defined in authors.txt
(the trailing newline leads to the line break). The user "user1" is
defined in authors.txt though, e.g.
user1 = User
Fix this by trimm
Eric Wong writes:
> Ævar Arnfjörð Bjarmason wrote:
>> See https://public-inbox.org/git/86h8oobl36@phe.ftfl.ca/ for the
>> original report.
>
> Thanks for taking a look at this. Also https://bugs.debian.org/894997
>
>> --- a/perl/Git.pm
>> +++ b/perl/Git.pm
>> @@ -554,7 +554,7 @@ sub get_rec
On Fri, Apr 06, 2018 at 01:15:14PM +, Ævar Arnfjörð Bjarmason wrote:
> Change code in Git.pm that sometimes calls chomp() on undef to only do
> so the value is defined.
>
> This code has been chomping undef values ever since it was added in
> b26098fc2f ("git-svn: reduce scope of input record
On Fri, Apr 06 2018, Eric Wong wrote:
> Ævar Arnfjörð Bjarmason wrote:
>> On Fri, Apr 06 2018, Eric Wong wrote:
>> > Ævar Arnfjörð Bjarmason wrote:
>> >
>> >> --- a/perl/Git.pm
>> >> +++ b/perl/Git.pm
>> >> @@ -554,7 +554,7 @@ sub get_record {
>> >> my ($fh, $rs) = @_;
>> >> local $/ = $rs;
Ævar Arnfjörð Bjarmason wrote:
> On Fri, Apr 06 2018, Eric Wong wrote:
> > Ævar Arnfjörð Bjarmason wrote:
> >
> >> --- a/perl/Git.pm
> >> +++ b/perl/Git.pm
> >> @@ -554,7 +554,7 @@ sub get_record {
> >>my ($fh, $rs) = @_;
> >>local $/ = $rs;
> >>my $rec = <$fh>;
> >> - chomp $rec if
On Fri, Apr 06 2018, Eric Wong wrote:
> Ævar Arnfjörð Bjarmason wrote:
>> See https://public-inbox.org/git/86h8oobl36@phe.ftfl.ca/ for the
>> original report.
>
> Thanks for taking a look at this. Also https://bugs.debian.org/894997
>
>> --- a/perl/Git.pm
>> +++ b/perl/Git.pm
>> @@ -554,7 +
Ævar Arnfjörð Bjarmason wrote:
> See https://public-inbox.org/git/86h8oobl36@phe.ftfl.ca/ for the
> original report.
Thanks for taking a look at this. Also https://bugs.debian.org/894997
> --- a/perl/Git.pm
> +++ b/perl/Git.pm
> @@ -554,7 +554,7 @@ sub get_record {
> my ($fh, $rs) = @
Hi Ævar,
On Fri, 6 Apr 2018, Ævar Arnfjörð Bjarmason wrote:
> Change code in Git.pm that sometimes calls chomp() on undef to only do
> so the value is defined.
>
> This code has been chomping undef values ever since it was added in
> b26098fc2f ("git-svn: reduce scope of input record separator c
Change code in Git.pm that sometimes calls chomp() on undef to only do
so the value is defined.
This code has been chomping undef values ever since it was added in
b26098fc2f ("git-svn: reduce scope of input record separator change",
2016-10-14), but started warning due to the introduction of "use
---
> Eric Wong (1):
> git-svn: control destruction order to avoid segfault
>
> git-svn.perl | 5 +
> 1 file changed, 5 insertions(+)
Thanks. I'd actually apply this as a patch instead of pullilng, as
I suspect you'd want it in 'ma
++
1 file changed, 5 insertions(+)
-----8<-
Subject: [PATCH] git-svn: control destruction order to avoid segfault
It seems necessary to control destruction ordering to avoid a
segfault with SVN 1.9.5 when using "git svn branch".
I've also reported the problem against libs
"Bennett, Brian" writes:
> Thank you all for your guidance,
>
> I have completed my test this morning with the patch and the 'git
> svn dcommit' is now SUCCESSFUl!
Thanks, all.
odd
Zullinger
Sent: Thursday, December 14, 2017 5:50 PM
To: Bennett, Brian
Cc: Eric Wong ; Junio C Hamano ;
git@vger.kernel.org
Subject: Re: [PATCH] git-svn: convert CRLF to LF in commit message to SVN
Hi Brian,
Bennett, Brian wrote:
> Thank you for your fast response,
>
> I haven
Hi Brian,
Bennett, Brian wrote:
> Thank you for your fast response,
>
> I haven't done a build of this type before (so I could
> test the patch first) so I'm trying to do that and get
> this far:
...
> I don't want to drag out testing the patch, so if either
> of you are able to quickly guide me
0
Facebook | LinkedIn
-Original Message-
From: Eric Wong [mailto:e...@80x24.org]
Sent: Wednesday, December 13, 2017 6:21 PM
To: Bennett, Brian ; Junio C Hamano
Cc: git@vger.kernel.org
Subject: [PATCH] git-svn: convert CRLF to LF in commit message to SVN
"Bennett, Brian&quo
t/t9169-git-svn-dcommit-crlf.sh | 27 +++++++
2 files changed, 28 insertions(+)
create mode 100755 t/t9169-git-svn-dcommit-crlf.sh
--8<
Subject: [PATCH] git-svn: convert CRLF to LF in commit message to SVN
Subversion since 1.6 does not accept CR characters i
Junio C Hamano writes:
> > Yep, seems alright. Can you apply directly?
> > Been a bit preoccupied as of late. Thanks.
>
> Surely, I'll just add your Reviewed-by: myself ;-)
OK, thanks. This will fix the bug I've reported here a week or so ago
(see the References header).
urs
Eric Wong writes:
> Junio C Hamano wrote:
>> Urs Thuermann writes:
>>
>> > In parse_svn_date() prepend the correct UTC offset to the timestamp
>> > returned. This is the offset in effect at the commit time instead of
>> > the offset in effect at calling time.
>> >
>> > Signed-off-by: Urs Thue
Junio C Hamano wrote:
> Urs Thuermann writes:
>
> > In parse_svn_date() prepend the correct UTC offset to the timestamp
> > returned. This is the offset in effect at the commit time instead of
> > the offset in effect at calling time.
> >
> > Signed-off-by: Urs Thuermann
> > ---
> > perl/Git/
Urs Thuermann writes:
> In parse_svn_date() prepend the correct UTC offset to the timestamp
> returned. This is the offset in effect at the commit time instead of
> the offset in effect at calling time.
>
> Signed-off-by: Urs Thuermann
> ---
> perl/Git/SVN.pm | 2 +-
> 1 file changed, 1 insert
In parse_svn_date() prepend the correct UTC offset to the timestamp
returned. This is the offset in effect at the commit time instead of
the offset in effect at calling time.
Signed-off-by: Urs Thuermann
---
perl/Git/SVN.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/per
Thanks.
Andreas Heiduk wrote:
> Some options specific for `git svn commit-diff` where not documented
> so far.
>
> Signed-off-by: Andreas Heiduk
Thanks again. It's been a while since "commit-diff" :)
Signed-off and pushed for Junio:
The following changes since commit 02a2850ad58eff6de70eb2dc5f9634
Some options specific for `git svn commit-diff` where not documented
so far.
Signed-off-by: Andreas Heiduk
---
Documentation/git-svn.txt | 15 +++
1 file changed, 15 insertions(+)
diff --git a/Documentation/git-svn.txt b/Documentation/git-svn.txt
index fba0b4eec..aa2aeabb6 100644
--
t-svn line 1200.
>
> I can workaround the issue to add auth configuration to
> SVN::Client->new().
Missing sign-off (see Documentation/SubmittingPatches).
Not my rule, but it's unfortunately required for this project.
Also, the Subject: should be in the imperative mood,
Perhaps s
I have the following authentication failure while svn rebase and
svn dcommit works fine without authentication failures.
$ git svn branch v7_3
Copying https://xxx at r27519
to https:///v7_3...
Can't create session: Unable to c
Eric Wong writes:
> Junio: ping?
>
> https://public-inbox.org/git/20161223014202.GA8327@starla/raw
>
> Thanks.
Thanks for reminding. This indeed fell thru cracks.
Junio: ping?
https://public-inbox.org/git/20161223014202.GA8327@starla/raw
Thanks.
On 2016-12-23 02:42, Eric Wong wrote:
> Hi Michael, the patch below should fix things up.
Thank you Eric, I was able to successfully fetch the SVN tag with your
patch applied.
Cheers,
--
Michael Fladischer
Fladi.at
signature.asc
Description: OpenPGP digital signature
Hi Michael, the patch below should fix things up.
Junio: this should go to 'maint', pull request below.
8<---
Subject: [PATCH] git-svn: escape backslashes in refnames
This brings git-svn refname escaping up-to-date with
commit a4c2e69936df8dd0b071b85664c
Eric Wong writes:
> Blindly checking a path component for falsiness is unwise, as
> "0" is false to Perl, but a valid pathname component for SVN
> (or any filesystem).
>
> Found via random code reading.
>
> Signed-off-by: Eric Wong
> ---
> Junio: this bugfix should go to "maint".
> Will push
Blindly checking a path component for falsiness is unwise, as
"0" is false to Perl, but a valid pathname component for SVN
(or any filesystem).
Found via random code reading.
Signed-off-by: Eric Wong
---
Junio: this bugfix should go to "maint".
Will push along with a doc fix for Juergen.
p
te one up sometime this week.
>
> My English is not that well. So I prefer, if you update the
> documentation :-)
No problem, my asciidoc is a bit rusty, but I think
the formatted result will be fine.
(Btw, list convention here is to reply-to-all;
it prevents vger from being a single-poi
Junio C Hamano wrote:
> Just peeking from the sideline, but the your squash looks like an
> improvement to me.
Thanks.
> Hopefully the final version after your interaction with Dscho can
> come to me via another "pull this now"?
Not sure if I'll be online the next few days,
but I've preeptively
Eric Wong writes:
> Johannes Schindelin wrote:
>> +++ b/perl/Git/SVN.pm
>> @@ -1658,6 +1658,11 @@ sub tie_for_persistent_memoization {
>> if ($memo_backend > 0) {
>> tie %$hash => 'Git::SVN::Memoize::YAML', "$path.yaml";
>> } else {
>> +# first verify that any
Johannes Schindelin wrote:
> +++ b/perl/Git/SVN.pm
> @@ -1658,6 +1658,11 @@ sub tie_for_persistent_memoization {
> if ($memo_backend > 0) {
> tie %$hash => 'Git::SVN::Memoize::YAML', "$path.yaml";
> } else {
> + # first verify that any existing file can actual
From: Gavin Lambert
Reusing cached data speeds up git-svn by quite a fair bit. However, if
the YAML module is unavailable, the caches are written to disk in an
architecture-dependent manner. That leads to problems when upgrading,
say, from 32-bit to 64-bit Git for Windows.
Let's just try to read
Junio C Hamano wrote:
> Subject: [PATCH] t9100: portability fix
>
> Do not say "export VAR=VAL"; "VAR=VAL && export VAR" is always more
> portable.
Oops, sorry I should've caught that :x
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.
Junio C Hamano writes:
> Eric Wong writes:
>
>> Repushed my master in case it's a convenient time to pull.
>>
>> The following changes since commit 29493589e97a2de0c4c1c314f61ccafaee3b5caf:
>>
>> archive-tar: huge offset and future timestamps would not work on 32-bit
>> (2016-07-15 10:51:55 -
Eric Wong writes:
> Repushed my master in case it's a convenient time to pull.
>
> The following changes since commit 29493589e97a2de0c4c1c314f61ccafaee3b5caf:
>
> archive-tar: huge offset and future timestamps would not work on 32-bit
> (2016-07-15 10:51:55 -0700)
>
> are available in the git
es changed, 24 insertions(+), 2 deletions(-)
-8<-
Subject: [PATCH] git-svn: allow --version to work anywhere
Checking the version of the installed SVN libraries should not
require a git repository at all. This matches the behavior of
"git --version".
Add a test for "git svn he
This has always been supported since we read config variables
based on the command-line option parser. Document it explicitly
since users usually want to maintain the same program across
invocations.
Signed-off-by: Eric Wong
---
Pushed to master of bogomips.org/git-svn.git, but I might
have mo
Eric Wong writes:
> Christopher Layne wrote:
>> * cmd_clone should detect a missing $url arg before using it otherwise
>> an uninitialized value error is emitted in even the simplest case of
>> 'git svn clone' without arguments.
>
> Thanks, this patch looks obviously correct.
>
> I've elimin
> On Jul 2, 2016, at 2315 PT, Eric Wong wrote:
>> sub cmd_clone {
>> my ($url, $path) = @_;
>> -if (!defined $path &&
>> +if (!$url) {
>> +die "SVN repository location required ",
>> +"as a command-line argument\n";
>
> "as a command-line argument" seems
Christopher Layne wrote:
> * cmd_clone should detect a missing $url arg before using it otherwise
> an uninitialized value error is emitted in even the simplest case of
> 'git svn clone' without arguments.
Thanks, this patch looks obviously correct.
I've eliminated the '* ' and space prefix
* cmd_clone should detect a missing $url arg before using it otherwise
an uninitialized value error is emitted in even the simplest case of
'git svn clone' without arguments.
Signed-off-by: Christopher Layne
---
git-svn.perl | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --g
ks.
>
> Yeah a warning is probably enough.
OK, patch below.
> Another possibility would be to default to an error that tells people
> about a configuration variable that could let them decide depending on
> their workflow if this should be an error, a warning or just be
> ignored.
I t
Christian Couder wrote:
> Signed-off-by: Christian Couder
Thanks Christian,
Signed-off-by: Eric Wong
...And pushed to my svn/bad-ref branch for Junio.
(I don't think I'll have other git-svn-related changes
immediately pending)
The following changes since commit 63a35025b11bf0e7ef39693aeea3b6
When passing a bad --trunk option to `git svn clone`, like for example the
same URL that we are cloning:
C:\Windows\system32>git svn clone
https://mycompany.svn.beanstalkapp.com/myproject --no-metadata -A
c:\temp\svn_to_git_users.txt
--trunk=https://mycompany.svn.beanstalkapp.com/myproject
Eric Wong writes:
> Junio C Hamano wrote:
>> I am not sure if it is a good idea to show */*/* as an example in
>> the message (that is an anti-example of 'one set of wildcard' by
>> having three stars, isn't it?), but that is not a new issue this
>> change introduces.
>
> Actually, going back to
Junio C Hamano wrote:
> I am not sure if it is a good idea to show */*/* as an example in
> the message (that is an anti-example of 'one set of wildcard' by
> having three stars, isn't it?), but that is not a new issue this
> change introduces.
Actually, going back to commit 570d35c26dfbc40757da6
Hello all,
On 01/14/2016 09:15 PM, Junio C Hamano wrote:
> Eric Wong writes:
>
>> Error messages should attempt to fit within the confines of
>> an 80-column terminal to avoid compatibility and accessibility
>> problems. Furthermore the word "directories" can be misleading
>> when used in the co
ant
Subject: [PATCH] git-svn: improve rebase/mkdirs performance
Processing empty_dir directives becomes extremely slow for svn
repositories with a large enough history.
This is due to using a single hash to store the list of empty
directories, with the expensive step being purging items from
Processing empty_dir directives becomes extremely slow for svn
repositories with a large enough history.
This is due to using a single hash to store the list of empty
directories, with the expensive step being purging items from
that hash using grep+delete.
Storing directories in a hash of hashes
ds,
Victor
From: Eric Wong [normalper...@yhbt.net]
Sent: Wednesday, September 23, 2015 12:22 PM
To: Victor Leschuk
Cc: Junio C Hamano; git@vger.kernel.org
Subject: Re: [PATCH] git-svn: make batch mode optional for git-cat-file
Victor Leschuk wrote:
> Hello Eric, thank
Victor Leschuk wrote:
> Hello Eric, thanks for looking into it.
>
> >> git-cat-file has outgrown the parent perl process several times
> >> (git-cat-file - ~3-4Gb, perl - 400Mb).
>
> > Ugh, that sucks.
> > Even the 400Mb size of Perl annoys me greatly and I'd work
> > on fixing it if I had more
ide
git-cat-file, I think we could give it a try, I can prepare a patch and run
some tests.
--
Best Regards,
Victor
From: Eric Wong [normalper...@yhbt.net]
Sent: Tuesday, September 22, 2015 5:35 PM
To: Victor Leschuk
Cc: Junio C Hamano; git@vger.kernel.org
Subject: Re: [PATCH] git-svn: ma
Eric Wong wrote:
> Victor Leschuk wrote:
> > The thing is that git-cat-file keeps growing during work when running
> > in "batch" mode. See the figure attached: it is for cloning a rather
> > small repo (1 hour to clone about ~14000 revisions). However the clone
> > of a large repo (~28 revis
Victor Leschuk wrote:
> The thing is that git-cat-file keeps growing during work when running
> in "batch" mode. See the figure attached: it is for cloning a rather
> small repo (1 hour to clone about ~14000 revisions). However the clone
> of a large repo (~28 revisions) took about 2 weeks and
Victor Leschuk writes:
> We already do have some of these: 'no-metadata', 'no-checkout',
> no-auth-cache'. So I was just following the existing convention. Do
> you think we need to change it and stick with
> --catch-file-batch=1/--cat-file-batch=0 ?
Inventing a new --cat-file-batch=[0|1] is not
: git@vger.kernel.org
Subject: RE: [PATCH] git-svn: make batch mode optional for git-cat-file
Hello Junio,
thanks for your review. First of all I'd like to apologize for sending the
patch without description. Actually I was in a hurry and sent it by accident: I
planned to edit the mail b
__
From: Junio C Hamano [jch2...@gmail.com] On Behalf Of Junio C Hamano
[gits...@pobox.com]
Sent: Monday, September 21, 2015 11:25 AM
To: Victor Leschuk
Cc: git@vger.kernel.org; Victor Leschuk
Subject: Re: [PATCH] git-svn: make batch mode optional for git-cat-file
Victor Leschu
Victor Leschuk writes:
> Signed-off-by: Victor Leschuk
> ---
Before the S-o-b line is a good place to explain why this is a good
change to have. Please use it.
> git-svn.perl | 1 +
> perl/Git.pm | 41 -
> 2 files changed, 41 insertions(+), 1 deletio
Signed-off-by: Victor Leschuk
---
git-svn.perl | 1 +
perl/Git.pm | 41 -
2 files changed, 41 insertions(+), 1 deletion(-)
diff --git a/git-svn.perl b/git-svn.perl
index 36f7240..b793c26 100755
--- a/git-svn.perl
+++ b/git-svn.perl
@@ -139,6 +139,7 @@ m
Eric Wong venit, vidit, dixit 10.09.2015 20:08:
> Michael J Gruber wrote:
>> Instead, make git svn uses the perl regex
>>
>> /^(.+?|\(no author\))\s*=\s*(.+?)\s*<(.*)>\s*$/
>>
>> for parsing the authors file so that the same (slightly more lenient)
>> regex is used in both cases.
>>
>> Reported-by
Eric Wong writes:
> Michael J Gruber wrote:
>> Instead, make git svn uses the perl regex
>>
>> /^(.+?|\(no author\))\s*=\s*(.+?)\s*<(.*)>\s*$/
>>
>> for parsing the authors file so that the same (slightly more lenient)
>> regex is used in both cases.
>>
>> Reported-by: Till Schäfer
>> Signed
Michael J Gruber wrote:
> Instead, make git svn uses the perl regex
>
> /^(.+?|\(no author\))\s*=\s*(.+?)\s*<(.*)>\s*$/
>
> for parsing the authors file so that the same (slightly more lenient)
> regex is used in both cases.
>
> Reported-by: Till Schäfer
> Signed-off-by: Michael J Gruber
Tha
Currently, git-svn parses an authors file using the perl regex
/^(.+?|\(no author\))\s*=\s*(.+?)\s*<(.+)>\s*$/
in order to extract svn user name, real name and e-mail.
This does not match an empty e-mail field like "<>". On the other hand,
the output of an authors-prog is parsed with the perl reg
Michael J Gruber venit, vidit, dixit 24.03.2015 16:10:
> t9119 refuses to run with svn versions greater than 1.6 since "git svn
> info" does not even try to match the output of "svn info" for later
> versions.
>
> Adjust "git svn info" to match these versions and make t9119 run with
> them. This r
t9119 refuses to run with svn versions greater than 1.6 since "git svn
info" does not even try to match the output of "svn info" for later
versions.
Adjust "git svn info" to match these versions and make t9119 run with
them. This requires the following changes:
* compute checksums with SHA1 inste
Junio C Hamano wrote:
> Ryuichi Kokubo writes:
>
> > git svn uses POSIX::strftime('%s', $sec, $min, ...) to make unix epoch time.
> > But lowercase %s formatting character is a GNU extention. This causes
> > problem
> > in git svn fetch --localtime on non-glibc systems, such as msys or cygwin.
Ryuichi Kokubo writes:
> git svn uses POSIX::strftime('%s', $sec, $min, ...) to make unix epoch time.
> But lowercase %s formatting character is a GNU extention. This causes problem
> in git svn fetch --localtime on non-glibc systems, such as msys or cygwin.
> Using Time::Local::timelocal($sec, $
git svn uses POSIX::strftime('%s', $sec, $min, ...) to make unix epoch time.
But lowercase %s formatting character is a GNU extention. This causes problem
in git svn fetch --localtime on non-glibc systems, such as msys or cygwin.
Using Time::Local::timelocal($sec, $min, ...) fixes it.
Signed-off-b
Baby steps, pushed to my master on git://bogomips.org/git-svn
--8<
Subject: [PATCH] git-svn: lazy load some modules
We can delay loading some modules until we need them for uncommon
code paths. For example, persistent memoization is not of
Eric,
I'm sorry, but this change isn't important enough for me to follow up.
Please merge the other two patches, if you think they're good.
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http:
Ramkumar Ramachandra wrote:
> The working_head_info routine takes a very long time to execute on large
> repositories. The least we can do is to comfort users that some progress
> is being made.
>
> Signed-off-by: Ramkumar Ramachandra
> ---
> I was worried because of the long wait, so I wrote t
Ramkumar Ramachandra wrote:
>> It is functional, maybe someone will use GIT_SVN_ID=0 ?
>
> Right. Kindly drop the first hunk.
Amendment: there are actually many other places where variables are
checked without "defined", so I doubt we want to put up with the extra
ugliness to allow "0".
--
To unsu
Eric Wong wrote:
> It is functional, maybe someone will use GIT_SVN_ID=0 ?
Right. Kindly drop the first hunk.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Eric Wong wrote:
> How portable is open on a directory? Perhaps it'd be better to
> check if it's a file, first:
Sure, that works; feel free to fix it up locally before committing.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.
Ramkumar Ramachandra wrote:
> Ramkumar Ramachandra wrote:
> > -our $default_ref_id = $ENV{GIT_SVN_ID} || 'git-svn';
> > +our $default_ref_id = defined $ENV{GIT_SVN_ID} ? $ENV{GIT_SVN_ID} :
> > 'git-svn';
>
> This is probably not a functional change; please look at the second hunk.
It is funct
Ramkumar Ramachandra wrote:
> +++ b/git-svn.perl
> @@ -337,6 +337,10 @@ for (my $i = 0; $i < @ARGV; $i++) {
> # make sure we're always running at the top-level working directory
> if ($cmd && $cmd =~ /(?:clone|init|multi-init)$/) {
> $ENV{GIT_DIR} ||= ".git";
> + # catch the submodule
Ramkumar Ramachandra wrote:
> -our $default_ref_id = $ENV{GIT_SVN_ID} || 'git-svn';
> +our $default_ref_id = defined $ENV{GIT_SVN_ID} ? $ENV{GIT_SVN_ID} :
> 'git-svn';
This is probably not a functional change; please look at the second hunk.
--
To unsubscribe from this list: send the line "unsu
It's a simple matter of opening the directory specified in the gitfile.
Signed-off-by: Ramkumar Ramachandra
---
git-svn.perl | 4
1 file changed, 4 insertions(+)
diff --git a/git-svn.perl b/git-svn.perl
index 6aa156c..8642783 100755
--- a/git-svn.perl
+++ b/git-svn.perl
@@ -337,6 +337,10 @
$ENV{GIT_SVN_ID} will return a string, so check it with defined. Also,
ref_id should not match "refs/remotes/".
Signed-off-by: Ramkumar Ramachandra
---
perl/Git/SVN.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/perl/Git/SVN.pm b/perl/Git/SVN.pm
index d9a52a5..06ff216
The working_head_info routine takes a very long time to execute on large
repositories. The least we can do is to comfort users that some progress
is being made.
Signed-off-by: Ramkumar Ramachandra
---
I was worried because of the long wait, so I wrote this to convince
myself that git-svn wasn't
> On Dec 8, 2014, at 1:36 PM, Eric Wong wrote:
>
> Alfred Perlstein wrote:
>> Appearing here:
>> http://marc.info/?l=git&m=125259772625008&w=2
>
> Probably better to use a mid URL here, too
>
> http://mid.gmane.org/1927112650.1281253084529659.javamail.r...@klofta.sjsoft.com
>
> such a long
Alfred Perlstein wrote:
> Appearing here:
> http://marc.info/?l=git&m=125259772625008&w=2
Probably better to use a mid URL here, too
http://mid.gmane.org/1927112650.1281253084529659.javamail.r...@klofta.sjsoft.com
such a long URL, though...
> --- a/perl/Git/SVN/Editor.pm
> +++ b/perl/Git/SVN
This change allows git-svn to support setting subversion properties.
Very useful for manually setting properties when committing to a
subversion repo that *requires* properties to be set without requiring
moving your changeset to separate subversion checkout in order to
set props.
This change is
Added:
Eric Sunshine's:
- suggestion to include the comment about propset only
working on files with content changes.
Eric Wong's:
- use && to chain commands throughout tests
- use svn_cmd wrapper throughout tests
- show $! in die messages
- favor $(...) over `...` in tests
- make new_props an
On 12/6/14, 9:42 PM, Eric Wong wrote:
Alfred Perlstein wrote:
This change allows git-svn to support setting subversion properties.
Very useful for manually setting properties when committing to a
subversion repo that *requires* properties to be set without requiring
moving your changeset to s
On Sat, Dec 6, 2014 at 5:29 PM, Alfred Perlstein wrote:
> I have incorporated Eric Wong's feedback into the git-svn propset support
> patch.
>
> There is a nit that I want to point out. The code does not support adding
> props
> unless there are also content changes to the files as well. You c
On Sun, Dec 7, 2014 at 3:00 AM, Torsten Bögershausen wrote:
> On 2014-12-07 06.45, Torsten Bögershausen wrote:
> []
>>> +
>>> +test_expect_success 'add multiple props' '
>>> +git svn propset svn:keywords "FreeBSD=%H" foo &&
>>> +git svn propset fbsd:nokeywords yes foo &&
>>> +echo hell
On 2014-12-07 06.45, Torsten Bögershausen wrote:
[]
>> +
>> +test_expect_success 'add multiple props' '
>> +git svn propset svn:keywords "FreeBSD=%H" foo &&
>> +git svn propset fbsd:nokeywords yes foo &&
>> +echo hello >> foo &&
>> +git commit -m "testing propset" foo &&
>> +git
> diff --git a/t/t9148-git-svn-propset.sh b/t/t9148-git-svn-propset.sh
> new file mode 100755
> index 000..b36a8a2
> --- /dev/null
> +++ b/t/t9148-git-svn-propset.sh
> @@ -0,0 +1,71 @@
> +#!/bin/sh
> +#
> +# Copyright (c) 2014 Alfred Perlstein
> +#
> +
> +test_description='git svn propset test
Alfred Perlstein wrote:
> This change allows git-svn to support setting subversion properties.
>
> Very useful for manually setting properties when committing to a
> subversion repo that *requires* properties to be set without requiring
> moving your changeset to separate subversion checkout in o
This change allows git-svn to support setting subversion properties.
Very useful for manually setting properties when committing to a
subversion repo that *requires* properties to be set without requiring
moving your changeset to separate subversion checkout in order to
set props.
This change is
I have incorporated Eric Wong's feedback into the git-svn propset support patch.
Issues resolved:
1) Test-case written.
2) Remove dead code.
3) Use shorter vars for formatting.
4) Fix bool comparisons.
5) Check for filesystem errors on write to .gitattribute file.
6) Use command_output_pipe() inst
1 - 100 of 211 matches
Mail list logo
