Re: [PATCH] Feature: custom guitool commands can now have custom keyboard shortcuts

2019-10-13 Thread Pratyush Yadav
On 09/10/19 01:01AM, Harish Karumuthil wrote: > Hi all, there is an update: > > I added necessary error catching code so that, script will not crash if the > keybinding code is worng. Instead of crashing it will print error message. > The final patch will look something like this. Like I mentione

Re: [PATCH] Feature: custom guitool commands can now have custom keyboard shortcuts

2019-10-13 Thread Pratyush Yadav
Hi Harish, Sorry for the late reply. Couldn't find much time last few days. On 07/10/19 11:43AM, Harish Karumuthil wrote: > Hi Pratyush, Regarding your messages, > > >On Sun, 2019-10-06 at 02:31 +0530, Pratyush Yadav wrote: > > You don't need to "set up" an email client with git-send-email. > >

Re: [PATCH] Feature: custom guitool commands can now have custom keyboard shortcuts

2019-10-09 Thread Johannes Schindelin
Hi, On Wed, 9 Oct 2019, Harish Karumuthil wrote: > @Johannes Schindelin: In short, from your previous message I understand point. > > 1. shortcut codes like "" will only in Windows platform. It may > not work in Linux / Mac. > 2. We need do translate shortcut codes somehow ( using one-to-one map

Re: [PATCH] Feature: custom guitool commands can now have custom keyboard shortcuts

2019-10-08 Thread Harish Karumuthil
Hi all, there is an update: I added necessary error catching code so that, script will not crash if the keybinding code is worng. Instead of crashing it will print error message. The final patch will look something like this. --- lib/tools.tcl | 24 1 file changed, 20 in

Re: GitGUIGadget, was Re: [PATCH] Feature: custom guitool commands can now have custom keyboard shortcuts

2019-10-07 Thread Alban Gruin
Hi Birger, Le 07/10/2019 à 12:43, Birger Skogeng Pedersen a écrit : > It seems this topic has kindof derailed(?). But I feel like voicing my > opinion nonetheless. > > -%<- > > My biggest gripe with not using Github is how to keep track of replies > (comments) to a topic. I have to navigate thro

Re: GitGUIGadget, was Re: [PATCH] Feature: custom guitool commands can now have custom keyboard shortcuts

2019-10-07 Thread Birger Skogeng Pedersen
It seems this topic has kindof derailed(?). But I feel like voicing my opinion nonetheless. I have to say I absolutely agree with Johannes Schindelin here. I would really prefer a more modern way of contributing to this project (any software project, really) than using emails. Be that Github, Gitl

Re: [PATCH] Feature: custom guitool commands can now have custom keyboard shortcuts

2019-10-07 Thread Johannes Schindelin
Hi Harish, On Mon, 7 Oct 2019, Harish Karumuthil wrote: > > However, it might not even need to put in _such_ a lot of work: in my > > tests, `Control-,` worked just as well as `Control-comma`. To test this > > for yourself, use this snippet (that is slightly modified from the > > example at the b

GitGUIGadget, was Re: [PATCH] Feature: custom guitool commands can now have custom keyboard shortcuts

2019-10-07 Thread Johannes Schindelin
Hi Pratyush, On Mon, 7 Oct 2019, Pratyush Yadav wrote: > On 06/10/19 10:27PM, Johannes Schindelin wrote: > > > > On Mon, 7 Oct 2019, Pratyush Yadav wrote: > > > > > On 06/10/19 11:49AM, Johannes Schindelin wrote: > > > > > > > > On Sun, 6 Oct 2019, Pratyush Yadav wrote: > > > > > > > > > On 06/10

Re: [PATCH] Feature: custom guitool commands can now have custom keyboard shortcuts

2019-10-06 Thread Harish Karumuthil
Hi Johannes Schindelin, Regarding your messages, > However, it might not even need to put in _such_ a lot of work: in my > tests, `Control-,` worked just as well as `Control-comma`. To test this > for yourself, use this snippet (that is slightly modified from the > example at the bottom of https:

Re: [PATCH] Feature: custom guitool commands can now have custom keyboard shortcuts

2019-10-06 Thread Harish Karumuthil
Hi Pratyush, Regarding your messages, >On Sun, 2019-10-06 at 02:31 +0530, Pratyush Yadav wrote: > You don't need to "set up" an email client with git-send-email. > git-send-email is an email client itself. Well, one which can only send > emails. For now, I am sticking with a mail client ( evolu

Re: [PATCH] Feature: custom guitool commands can now have custom keyboard shortcuts

2019-10-06 Thread Philip Oakley
Hi Dscho, On 06/10/2019 21:27, Johannes Schindelin wrote: Let me provide you with some data, then. Granted, it's not necessarily all Git GUI, but it includes Git GUI patches, too: Git for Windows' contributions. As should be well-known, I try to follow Postel's Law when it comes to Git for Wind

Re: [PATCH] Feature: custom guitool commands can now have custom keyboard shortcuts

2019-10-06 Thread Pratyush Yadav
On 06/10/19 10:27PM, Johannes Schindelin wrote: > Hi Pratyush, > > On Mon, 7 Oct 2019, Pratyush Yadav wrote: > > > On 06/10/19 11:49AM, Johannes Schindelin wrote: > > > Hi Pratyush, > > > > > > On Sun, 6 Oct 2019, Pratyush Yadav wrote: > > > > > > > On 06/10/19 01:46AM, Harish Karumuthil wrote: >

Re: [PATCH] Feature: custom guitool commands can now have custom keyboard shortcuts

2019-10-06 Thread Johannes Schindelin
Hi Pratyush, On Mon, 7 Oct 2019, Pratyush Yadav wrote: > On 06/10/19 11:49AM, Johannes Schindelin wrote: > > Hi Pratyush, > > > > On Sun, 6 Oct 2019, Pratyush Yadav wrote: > > > > > On 06/10/19 01:46AM, Harish Karumuthil wrote: > > > > > > > > From https://www.kernel.org/doc/html/v4.10/process/em

Re: [PATCH] Feature: custom guitool commands can now have custom keyboard shortcuts

2019-10-06 Thread Philip Oakley
On 06/10/2019 19:39, Pratyush Yadav wrote: That way, you don't have to introduce settings separate from `git-cola`'s, and you can reuse the short-and-sweet variable name. I think a more important question is whether we_really_ need to have compatibility with git-cola. Most of our shortcuts don'

Re: [PATCH] Feature: custom guitool commands can now have custom keyboard shortcuts

2019-10-06 Thread Pratyush Yadav
On 06/10/19 11:49AM, Johannes Schindelin wrote: > Hi Pratyush, > > On Sun, 6 Oct 2019, Pratyush Yadav wrote: > > > On 06/10/19 01:46AM, Harish Karumuthil wrote: > > > > > > From https://www.kernel.org/doc/html/v4.10/process/email-clients.html, I > > > understood that, my current email client ( th

Re: [PATCH] Feature: custom guitool commands can now have custom keyboard shortcuts

2019-10-06 Thread Johannes Schindelin
Hi Pratyush, On Sun, 6 Oct 2019, Pratyush Yadav wrote: > On 06/10/19 01:46AM, Harish Karumuthil wrote: > > > > From https://www.kernel.org/doc/html/v4.10/process/email-clients.html, I > > understood that, my current email client ( that is gmail web ) is not good > > for submitting patches. So I w

Re: [PATCH] Feature: custom guitool commands can now have custom keyboard shortcuts

2019-10-05 Thread Pratyush Yadav
On 06/10/19 01:46AM, Harish Karumuthil wrote: > Hi All, > > From https://www.kernel.org/doc/html/v4.10/process/email-clients.html, I > understood that, my current email client ( that is gmail web ) is not good > for submitting patches. So I was tying to setup a mail client which is > compatible wi

Re: [PATCH] Feature: custom guitool commands can now have custom keyboard shortcuts

2019-10-05 Thread Harish Karumuthil
Hi All, >From https://www.kernel.org/doc/html/v4.10/process/email-clients.html, I understood that, my current email client ( that is gmail web ) is not good for submitting patches. So I was tying to setup a mail client which is compatible with `git send-mail`. But I was not able to get a satisfact

Re: [PATCH] Feature: custom guitool commands can now have custom keyboard shortcuts

2019-10-04 Thread Pratyush Yadav
On 04/10/19 10:49AM, Johannes Schindelin wrote: > Hi Pratyush, > > please don't top-post on this list (yet another of these things > requiring extra brain cycles in the mailing list workflow). I didn't top-post, or at least it wasn't the intention. The text above the quoted text is the "preface"

Re: [PATCH] Feature: custom guitool commands can now have custom keyboard shortcuts

2019-10-04 Thread Johannes Schindelin
Hi Pratyush, please don't top-post on this list (yet another of these things requiring extra brain cycles in the mailing list workflow). On Fri, 4 Oct 2019, Pratyush Yadav wrote: > Hi Harish, > > Thanks for the patch. Unfortunately, it seems your mail client messed up > the formatting, and the p

Re: [PATCH] Feature: custom guitool commands can now have custom keyboard shortcuts

2019-10-03 Thread Pratyush Yadav
Hi Harish, Thanks for the patch. Unfortunately, it seems your mail client messed up the formatting, and the patch won't apply. I'm guessing it is because your mail client broke long lines into two, messing up the diff. We use an email-based workflow, so please either configure your mail client

Re: [PATCH] Feature: custom guitool commands can now have custom keyboard shortcuts

2019-10-03 Thread harish k
Hi All, I', Just reopening this feature request. A quick summary of my proposal is given below. 1. This PR will allow an additional configuration option "guitool..gitgui-shortcut" which will allow us to specify keyboard shortcut for custom commands in git-gui 2. Even there exists a parameter cal

Re: [PATCH] Feature: custom guitool commands can now have custom keyboard shortcuts

2016-03-31 Thread harish k
Hi David, Actually Im a TCL primer. This is the first time Im dealing with. That is why I kept it simple ( ie both accel-key and accel-label need to be defined in config ). I think, git-cola is using Qt style representation accel-key in the config file. Is git-cola is an official tool from git

Re: [PATCH] Feature: custom guitool commands can now have custom keyboard shortcuts

2016-03-31 Thread David Aguilar
On Tue, Mar 29, 2016 at 11:29:41AM +, Harish K wrote: > --- > git-gui/lib/tools.tcl | 16 +--- > 1 file changed, 13 insertions(+), 3 deletions(-) I forgot to mention that git-gui has its own repository. The git project merges the upstream repo as a subtree into its git-gui direct

Re: [PATCH] Feature: custom guitool commands can now have custom keyboard shortcuts

2016-03-31 Thread David Aguilar
Hello, On Tue, Mar 29, 2016 at 11:38:10AM +, Harish K wrote: > --- > git-gui/lib/tools.tcl | 16 +--- > 1 file changed, 13 insertions(+), 3 deletions(-) > > diff --git a/git-gui/lib/tools.tcl b/git-gui/lib/tools.tcl > index 6ec9411..749bc67 100644 > --- a/git-gui/lib/tools.tcl >

[PATCH] Feature: custom guitool commands can now have custom keyboard shortcuts

2016-03-29 Thread Harish K
--- git-gui/lib/tools.tcl | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/git-gui/lib/tools.tcl b/git-gui/lib/tools.tcl index 6ec9411..749bc67 100644 --- a/git-gui/lib/tools.tcl +++ b/git-gui/lib/tools.tcl @@ -38,7 +38,7 @@ proc tools_create_item {parent args}

[PATCH] Feature: custom guitool commands can now have custom keyboard shortcuts

2016-03-29 Thread Harish K
--- git-gui/lib/tools.tcl | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/git-gui/lib/tools.tcl b/git-gui/lib/tools.tcl index 6ec9411..749bc67 100644 --- a/git-gui/lib/tools.tcl +++ b/git-gui/lib/tools.tcl @@ -38,7 +38,7 @@ proc tools_create_item {parent args}