Re: [PATCH] Enable parallelism in git submodule update.

2012-11-03 Thread Jens Lehmann
Am 03.11.2012 19:44, schrieb Phil Hord: > On Sat, Nov 3, 2012 at 11:42 AM, Jens Lehmann wrote: >> Am 30.10.2012 19:11, schrieb Stefan Zager: >>> This is a refresh of a conversation from a couple of months ago. >>> >>> I didn't try to implement all the desired features (e.g., smart logic >>> for pa

Re: [PATCH] Enable parallelism in git submodule update.

2012-11-03 Thread Jens Lehmann
Am 29.07.2012 17:37, schrieb Jens Lehmann: > Am 27.07.2012 20:37, schrieb Stefan Zager: >> The --jobs parameter may be used to set the degree of per-submodule >> parallel execution. > > I think this is a sound idea, but it would be good to see some > actual measurements. What are the performance n

Re: [PATCH] Enable parallelism in git submodule update.

2012-11-03 Thread Phil Hord
On Sat, Nov 3, 2012 at 11:42 AM, Jens Lehmann wrote: > Am 30.10.2012 19:11, schrieb Stefan Zager: >> This is a refresh of a conversation from a couple of months ago. >> >> I didn't try to implement all the desired features (e.g., smart logic >> for passing a -j parameter to recursive submodule inv

Re: [PATCH] Enable parallelism in git submodule update.

2012-11-03 Thread Jens Lehmann
Am 30.10.2012 19:11, schrieb Stefan Zager: > This is a refresh of a conversation from a couple of months ago. > > I didn't try to implement all the desired features (e.g., smart logic > for passing a -j parameter to recursive submodule invocations), but I > did address the one issue that Junio ins

Re: [PATCH] Enable parallelism in git submodule update.

2012-11-02 Thread Stefan Zager
ping? On Tue, Oct 30, 2012 at 11:11 AM, Stefan Zager wrote: > This is a refresh of a conversation from a couple of months ago. > > I didn't try to implement all the desired features (e.g., smart logic > for passing a -j parameter to recursive submodule invocations), but I > did address the one is

Re: [PATCH] Enable parallelism in git submodule update.

2012-10-30 Thread Stefan Zager
This is a refresh of a conversation from a couple of months ago. I didn't try to implement all the desired features (e.g., smart logic for passing a -j parameter to recursive submodule invocations), but I did address the one issue that Junio insisted on: the code makes a best effort to detect whet

[PATCH] Enable parallelism in git submodule update.

2012-10-30 Thread szager
The --jobs parameter may be used to set the degree of per-submodule parallel execution. Signed-off-by: Stefan Zager --- Documentation/git-submodule.txt |8 ++- git-submodule.sh| 40 ++- 2 files changed, 46 insertions(+), 2 deletions(-

[PATCH] Enable parallelism in git submodule update.

2012-10-30 Thread szager
The --jobs parameter may be used to set the degree of per-submodule parallel execution. Signed-off-by: Stefan Zager --- Documentation/git-submodule.txt |8 ++- git-submodule.sh| 40 ++- 2 files changed, 46 insertions(+), 2 deletions(-

Re: [PATCH] Enable parallelism in git submodule update.

2012-07-29 Thread Junio C Hamano
Heiko Voigt writes: > On Fri, Jul 27, 2012 at 04:25:58PM -0700, Junio C Hamano wrote: > ... >> Of course, any set of rules have exceptions ;-) There are a few >> things to which we say "Even though it is not in POSIX, everybody >> who matters supports it, and without taking advantage of it, what

Re: [PATCH] Enable parallelism in git submodule update.

2012-07-29 Thread Jens Lehmann
Am 27.07.2012 20:37, schrieb Stefan Zager: > The --jobs parameter may be used to set the degree of per-submodule > parallel execution. I think this is a sound idea, but it would be good to see some actual measurements. What are the performance numbers with and without this change? Which cases do b

Re: [PATCH] Enable parallelism in git submodule update.

2012-07-28 Thread Heiko Voigt
Hi, On Fri, Jul 27, 2012 at 04:25:58PM -0700, Junio C Hamano wrote: > Stefan Zager writes: > > > On Fri, Jul 27, 2012 at 2:38 PM, Junio C Hamano wrote: > > > >> Stefan Zager writes: > >> > >> > + module_list "$@" | awk '{print $4}' | xargs -L 1 -P > >> "$jobs" git submodule update

Re: [PATCH] Enable parallelism in git submodule update.

2012-07-28 Thread Heiko Voigt
Hi Stefan, neat patch. See below for a few notes. On Fri, Jul 27, 2012 at 11:37:34AM -0700, Stefan Zager wrote: > diff --git a/git-submodule.sh b/git-submodule.sh > index dba4d39..761420a 100755 > --- a/git-submodule.sh > +++ b/git-submodule.sh > @@ -491,6 +492,20 @@ cmd_update() >

Re: [PATCH] Enable parallelism in git submodule update.

2012-07-27 Thread Junio C Hamano
Stefan Zager writes: > On Fri, Jul 27, 2012 at 2:38 PM, Junio C Hamano wrote: > >> Stefan Zager writes: >> >> > + module_list "$@" | awk '{print $4}' | xargs -L 1 -P >> "$jobs" git submodule update $orig_args >> >> Capital-P option to xargs is not even in POSIX, no? > > I wasn't awa

Re: [PATCH] Enable parallelism in git submodule update.

2012-07-27 Thread Junio C Hamano
Stefan Zager writes: > + module_list "$@" | awk '{print $4}' | xargs -L 1 -P "$jobs" git > submodule update $orig_args Capital-P option to xargs is not even in POSIX, no? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.ker

[PATCH] Enable parallelism in git submodule update.

2012-07-27 Thread Stefan Zager
The --jobs parameter may be used to set the degree of per-submodule parallel execution. Signed-off-by: Stefan Zager --- Documentation/git-submodule.txt | 8 +++- git-submodule.sh| 23 ++- 2 files changed, 29 insertions(+), 2 deletions(-) diff --git a/Doc