Re: [PATCH] Enable HAVE_DEV_TTY for Solaris

2012-08-08 Thread Jeff King
On Wed, Aug 08, 2012 at 04:13:03PM +0200, Erik Faye-Lund wrote: > On Tue, Aug 7, 2012 at 6:10 AM, Jeff King wrote: > > Subject: [PATCH] terminal: seek when switching between reading and writing > > > > When a stdio stream is opened in update mode (e.g., "w+"), > > the C standard forbids switching

Re: [PATCH] Enable HAVE_DEV_TTY for Solaris

2012-08-08 Thread Erik Faye-Lund
On Tue, Aug 7, 2012 at 6:10 AM, Jeff King wrote: > Subject: [PATCH] terminal: seek when switching between reading and writing > > When a stdio stream is opened in update mode (e.g., "w+"), > the C standard forbids switching between reading or writing > without an intervening positioning function.

Re: [PATCH] Enable HAVE_DEV_TTY for Solaris

2012-08-07 Thread Ben Walton
Excerpts from Jeff King's message of Tue Aug 07 00:10:26 -0400 2012: > Signed-off-by: Jeff King Acked-by: Ben Walton I agree with your assesment that this is the right way to go (vs migrating out of stdio) for now. If the changes Tay needs to make require the migration then it can become part

Re: [PATCH] Enable HAVE_DEV_TTY for Solaris

2012-08-06 Thread Jeff King
On Tue, Aug 07, 2012 at 12:03:26AM -0400, Jeff King wrote: > > So which direction do you guys want to go? Use the "bidirectional > > stdio with fseek()" for now, with the expectation that Tay's other > > series will rewrite it to fd based one? > > I think so. The stdio fix is short and obviously

Re: [PATCH] Enable HAVE_DEV_TTY for Solaris

2012-08-06 Thread Jeff King
On Mon, Aug 06, 2012 at 08:43:02PM -0700, Junio C Hamano wrote: > Ben Walton writes: > > > Now that git_terminal_prompt can cleanly interact with /dev/tty on > > Solaris, enable HAVE_DEV_TTY so that this code path is used for > > credential reading instead of relying on the crippled getpass(). >

Re: [PATCH] Enable HAVE_DEV_TTY for Solaris

2012-08-06 Thread Junio C Hamano
Ben Walton writes: > Now that git_terminal_prompt can cleanly interact with /dev/tty on > Solaris, enable HAVE_DEV_TTY so that this code path is used for > credential reading instead of relying on the crippled getpass(). > > Signed-off-by: Ben Walton > --- > > This is a follow up to Jeff's patch

[PATCH] Enable HAVE_DEV_TTY for Solaris

2012-08-06 Thread Ben Walton
Now that git_terminal_prompt can cleanly interact with /dev/tty on Solaris, enable HAVE_DEV_TTY so that this code path is used for credential reading instead of relying on the crippled getpass(). Signed-off-by: Ben Walton --- This is a follow up to Jeff's patch that fixes git_terminal_prompt on