Re: [PATCH] Documentation: mention that `eol` can change the dirty status of paths

2017-08-31 Thread Ben Boeckel
On Wed, Aug 30, 2017 at 14:31:30 -0700, Junio C Hamano wrote: > Is this "always makes them dirty" or "may make them dirty depending > on the situation"? > > If the latter, I'd prefer to see s/makes/may make/ here. Yes, a coworker reported that some files slipped through this. New patch incoming

Re: [PATCH] Documentation: mention that `eol` can change the dirty status of paths

2017-08-30 Thread Junio C Hamano
Torsten Bögershausen writes: > How about something like this : > > This attribute sets a specific line-ending style to be used in the > working directory. It enables end-of-line conversion without any > -content checks, effectively setting the `text` attribute. > +content checks, effective

Re: [PATCH] Documentation: mention that `eol` can change the dirty status of paths

2017-08-30 Thread Ben Boeckel
On Thu, Aug 24, 2017 at 07:50:54 +0200, Torsten Bögershausen wrote: > This attribute sets a specific line-ending style to be used in the > working directory. It enables end-of-line conversion without any > -content checks, effectively setting the `text` attribute. > +content checks, effectiv

Re: [PATCH] Documentation: mention that `eol` can change the dirty status of paths

2017-08-23 Thread Torsten Bögershausen
On Wed, Aug 23, 2017 at 05:17:41PM -0400, Ben Boeckel wrote: > When setting the `eol` attribute, paths can change their dirty status > without any change in the working directory. This can cause confusion > and should at least be mentioned with a remedy. > > Signed-off-by: Ben Boeckel > --- > Do

Re: [PATCH] Documentation: mention that `eol` can change the dirty status of paths

2017-08-23 Thread Ben Boeckel
On Wed, Aug 23, 2017 at 17:17:41 -0400, Ben Boeckel wrote: > diff --git a/Documentation/gitattributes.txt b/Documentation/gitattributes.txt > index c4f2be2..3044b71 100644 > --- a/Documentation/gitattributes.txt > +++ b/Documentation/gitattributes.txt > @@ -151,7 +151,11 @@ unspecified. > > This

[PATCH] Documentation: mention that `eol` can change the dirty status of paths

2017-08-23 Thread Ben Boeckel
When setting the `eol` attribute, paths can change their dirty status without any change in the working directory. This can cause confusion and should at least be mentioned with a remedy. Signed-off-by: Ben Boeckel --- Documentation/gitattributes.txt | 6 +- 1 file changed, 5 insertions(+),