Re: [PATCH] Close transport helper on protocol error

Jeff King writes: > ... > At which point I do wonder if this is better handled by a wrapper > process which simply reaps everything. And indeed, people have already > come up with similar solutions for containers: > > https://github.com/Yelp/dumb-init > > So I dunno. I am not really opposed to

Re: [PATCH] Close transport helper on protocol error

On Tue, Jul 23, 2019 at 10:33:10AM -0700, Junio C Hamano wrote: > > + if (recvline(data, &buf)){ > > + release_helper(transport); > > exit(128); > > + } > > This, together with other exit(128) we see in this patch now have > release_helepr

Re: [PATCH] Close transport helper on protocol error

thibault.ja...@gmail.com writes: > Subject: Re: [PATCH] Close transport helper on protocol error Perhaps Subject: transport: close helper on protocol error > +static int disconnect_helper(struct transport *transport); > + > +static int disconnect_helper_data(struct helpe

[PATCH] Close transport helper on protocol error

From: Thibault Jamet We have noticed that in some cases, when the transport is not fully compliant with the protocol, git exits with a status of 128 without closing the transport. This usually does not have consequences in a standard unix environment as the process gets then attached to the init