Re: [PATCH] Clarify documentation on commit message strip

2015-04-27 Thread Fredrik Gustafsson
On Mon, Apr 27, 2015 at 10:31:28AM -0700, Junio C Hamano wrote: > Fredrik Gustafsson writes: > > > I agree that it is very clear once you do edit the commit message. My main > > point with this patch was to clarify -v, since it's not obvious from the > > documentation that it will be removed. >

Re: [PATCH] Clarify documentation on commit message strip

2015-04-27 Thread Junio C Hamano
Fredrik Gustafsson writes: > I agree that it is very clear once you do edit the commit message. My main > point with this patch was to clarify -v, since it's not obvious from the > documentation that it will be removed. While I agree with you that the documentation should make it clear that the

[PATCH] Clarify documentation on commit message strip

2015-04-24 Thread Fredrik Gustafsson
When using `-v` to add a unified diff to the commit message, this is stripped and not a part of the commit message. This is not mentioned. Add a note about this with the `-v` description and slightly modify the description for the default `--cleanup` mode. Signed-off-by: Fredrik Gustafsson ---

Re: [PATCH] Clarify documentation on commit message strip

2015-04-24 Thread Junio C Hamano
Fredrik Gustafsson writes: > diff --git a/Documentation/git-commit.txt b/Documentation/git-commit.txt > index 617e29b..e31d828 100644 > --- a/Documentation/git-commit.txt > +++ b/Documentation/git-commit.txt > @@ -180,8 +180,9 @@ OPTIONS > + > -- > strip:: > - Strip leading and trailing em

[PATCH] Clarify documentation on commit message strip

2015-04-24 Thread Fredrik Gustafsson
When using `-v` to add a unified diff to the commit message, this is stripped and not a part of the commit message. This is not mentioned. Add a note about this with the `-v` description as well as description for the default `--cleanup` mode. Signed-off-by: Fredrik Gustafsson --- Documentation