Re: [PATCH] Add support for commit attributes

2014-04-10 Thread Max Horn
On 10.04.2014, at 19:28, Felipe Contreras wrote: > Diego Lago wrote: >> Commit attributes are custom commit extra headers the user can >> add to the commit object. >> >> The motivation for this patch is that in my company we have a custom >> continuous integration software that uses a custom fo

RE: [PATCH] Add support for commit attributes

2014-04-10 Thread Felipe Contreras
Diego Lago wrote: > Commit attributes are custom commit extra headers the user can > add to the commit object. > > The motivation for this patch is that in my company we have a custom > continuous integration software that uses a custom formatted commit > message (currently in YALM format) to show

Re: [PATCH] Add support for commit attributes

2014-04-10 Thread Junio C Hamano
Junio C Hamano writes: > I actually think this "recording information about commits" is > exactly the use-case notes were invented to address, and if it is > found cumbersome to use, the reason why it is cumbersome needs to be > discovered and use of notes needs to be improved. Hooks and/or a >

Re: [PATCH] Add support for commit attributes

2014-04-10 Thread Junio C Hamano
Duy Nguyen writes: > If the problem is polluting human eyes, wouldn't it be better to make > git-log to filter it out? For example, we could tell git that all > fields (in the message body) that start with X- are "rubbish", so > instead of showing "X-something: base64 stuff...", it shows > "X-som

Re: [PATCH] Add support for commit attributes

2014-04-10 Thread Duy Nguyen
On Thu, Apr 10, 2014 at 1:27 PM, Diego Lago González wrote: > Writing this data into the message, the user is forced to write it in the > correct format (I think is better to write key=value pairs as an option > instead of writing as message lines with spaces in key, between key and > equal sign a

Re: [PATCH] Add support for commit attributes

2014-04-09 Thread Diego Lago González
2014-04-10 6:25 GMT+02:00 Duy Nguyen : > On Thu, Apr 10, 2014 at 2:38 AM, Diego Lago > wrote: >> Commit attributes are custom commit extra headers the user can >> add to the commit object. >> >> The motivation for this patch is that in my company we have a custom >> continuous integration software

Re: [PATCH] Add support for commit attributes

2014-04-09 Thread Duy Nguyen
On Thu, Apr 10, 2014 at 2:38 AM, Diego Lago wrote: > Commit attributes are custom commit extra headers the user can > add to the commit object. > > The motivation for this patch is that in my company we have a custom > continuous integration software that uses a custom formatted commit > message (

[PATCH] Add support for commit attributes

2014-04-09 Thread Diego Lago
41 t/t2400-commit-attributes.sh | 187 +++ 5 files changed, 456 insertions(+), 1 deletion(-) create mode 100755 t/t2400-commit-attributes.sh -- 1.7.9.5 >From 5d63d32fc94c5824e6189092065160eaf075ff5e Mon Sep 17 00:00:00 2001 From: Diego Lago Date: Tue, 8 Apr 2014 17:29:4