Re: [PATCH] (exit 1) is silly

2016-03-22 Thread Junio C Hamano
Sebastian Schuberth writes: > On 3/22/2016 17:16, Junio C Hamano wrote: > >> IMO, this is such a minor thing that once it _is_ in the tree, it's >> not really worth the patch noise to go and fix it up. > > IMO, instead of writing this you could have just accepted the patch, > reducing the patch n

Re: [PATCH] (exit 1) is silly

2016-03-22 Thread Sebastian Schuberth
On 3/22/2016 17:16, Junio C Hamano wrote: IMO, this is such a minor thing that once it _is_ in the tree, it's not really worth the patch noise to go and fix it up. IMO, instead of writing this you could have just accepted the patch, reducing the patch noise ;-) Regards, Sebastian -- To un

Re: [PATCH] (exit 1) is silly

2016-03-22 Thread Junio C Hamano
izabera writes: > Signed-off-by: izabera > --- > GIT-VERSION-GEN | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/GIT-VERSION-GEN b/GIT-VERSION-GEN > index b5072a2..17b6ef4 100755 > --- a/GIT-VERSION-GEN > +++ b/GIT-VERSION-GEN > @@ -14,7 +14,7 @@ then > elif test -d ${

[PATCH] (exit 1) is silly

2016-03-22 Thread izabera
Signed-off-by: izabera --- GIT-VERSION-GEN | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/GIT-VERSION-GEN b/GIT-VERSION-GEN index b5072a2..17b6ef4 100755 --- a/GIT-VERSION-GEN +++ b/GIT-VERSION-GEN @@ -14,7 +14,7 @@ then elif test -d ${GIT_DIR:-.git} -o -f .git && VN