Re: [PATCH][GSoC] parse-options: Add OPT_SET_INT_NONEG.

2014-03-12 Thread Junio C Hamano
Yuxuan Shui writes: > On Thu, Mar 13, 2014 at 2:30 AM, Junio C Hamano wrote: >> Duy Nguyen writes: >> >>> By convention, no full stop in the subject line. The subject should >>> summarize your changes and "add ..NONEG" is just one part of it. The >>> other is "convert to use ...NONEG". So I sug

Re: [PATCH][GSoC] parse-options: Add OPT_SET_INT_NONEG.

2014-03-12 Thread Yuxuan Shui
Hi, On Thu, Mar 13, 2014 at 2:30 AM, Junio C Hamano wrote: > Duy Nguyen writes: > >> By convention, no full stop in the subject line. The subject should >> summarize your changes and "add ..NONEG" is just one part of it. The >> other is "convert to use ...NONEG". So I suggest "parse-options: >>

Re: [PATCH][GSoC] parse-options: Add OPT_SET_INT_NONEG.

2014-03-12 Thread Junio C Hamano
Duy Nguyen writes: > By convention, no full stop in the subject line. The subject should > summarize your changes and "add ..NONEG" is just one part of it. The > other is "convert to use ...NONEG". So I suggest "parse-options: > convert to use new macro OPT_SET_INT_NONEG()" or something like that

Re: [PATCH][GSoC] parse-options: Add OPT_SET_INT_NONEG.

2014-03-12 Thread Yuxuan Shui
On Wed, Mar 12, 2014 at 6:47 PM, Duy Nguyen wrote: > By convention, no full stop in the subject line. The subject should > summarize your changes and "add ..NONEG" is just one part of it. The > other is "convert to use ...NONEG". So I suggest "parse-options: > convert to use new macro OPT_SET_INT_

Re: [PATCH][GSoC] parse-options: Add OPT_SET_INT_NONEG.

2014-03-12 Thread Duy Nguyen
By convention, no full stop in the subject line. The subject should summarize your changes and "add ..NONEG" is just one part of it. The other is "convert to use ...NONEG". So I suggest "parse-options: convert to use new macro OPT_SET_INT_NONEG()" or something like that. You should also explain in

[PATCH][GSoC] parse-options: Add OPT_SET_INT_NONEG.

2014-03-11 Thread Yuxuan Shui
Reference: http://git.github.io/SoC-2014-Microprojects.html Signed-off-by: Yuxuan Shui --- builtin/fetch.c| 5 ++--- builtin/merge.c| 5 ++--- builtin/notes.c| 10 -- builtin/pack-objects.c | 15 ++- builtin/update-index.c | 20 p