> Matthieu Moy writes:
> > Ideally, you would check the list of commits displayed too. If the
> > commits sha1 are stable, this should be easy to do. If it's too hard to
> > test, I'd say its not worth the trouble, but others may disagree.
>
> Originally I chose not to check if the SHA-1 were
Matthieu Moy writes:
> Ideally, you would check the list of commits displayed too. If the
> commits sha1 are stable, this should be easy to do. If it's too hard to
> test, I'd say its not worth the trouble, but others may disagree.
Originally I chose not to check if the SHA-1 were corrects since
Remi Galan Alfonso writes:
> Checking that the warning was correctly displayed like in the test for
> "warn" if I understood correctly. About that, is checking that the
> first line is "Warning: some commits may have been dropped
> accidentally." (like in the test for "warn") enough, or should I
Remi Galan Alfonso
writes:
> In this case it is not true, because of the infile and outfile being
> identical. However sort does have a -o (-output) that I missed that
> allows avoiding using echo or writing in another file; I'm correcting
> with this.
Even though it is in POSIX, some implementa
Matthieu Moy writes:
> > Galan Rémi writes:
> > +# Sort the SHA-1 and compare them
> > +echo "$(sort -u "$todo".oldsha1)" >"$todo".oldsha1
> > +echo "$(sort -u "$todo".newsha1)" >"$todo".newsha1
>
> Useless uses of echo.
>
> echo $(foo) -> foo
In
Galan Rémi writes:
> Check if commits were removed (i.e. a line was deleted) and print
> warnings or abort git rebase according to the value of the
s/according to/depending on/
(although both translate to the same "selon" in french ;-))
> configuration variable rebase.missingCommitsCheckLevel.
Check if commits were removed (i.e. a line was deleted) and print
warnings or abort git rebase according to the value of the
configuration variable rebase.missingCommitsCheckLevel.
Add the configuration variable rebase.missingCommitsCheckLevel.
- When unset or set to "ignore", no checking is d
7 matches
Mail list logo
