[PATCH/RFC v4 10/10] send-email: suppress meaningless whitespaces in from field

2015-06-17 Thread Remi Lespinet
Matthieu Moy writes > Remi Lespinet writes: > > if (defined $sender) { > > + $sender =~ s/^\s+|\s$//g; > I would say \s+ also for the second \s. Not really different, but it > feels wrong to iterate the substitution as many times as there are > trailing spaces to remove. Oops should hav

Re: [PATCH/RFC v4 10/10] send-email: suppress meaningless whitespaces in from field

2015-06-17 Thread Matthieu Moy
Remi Lespinet writes: > if (defined $sender) { > + $sender =~ s/^\s+|\s$//g; I would say \s+ also for the second \s. Not really different, but it feels wrong to iterate the substitution as many times as there are trailing spaces to remove. -- Matthieu Moy http://www-verimag.imag.fr/~moy/

[PATCH/RFC v4 10/10] send-email: suppress meaningless whitespaces in from field

2015-06-17 Thread Remi Lespinet
Remove leading and trailing whitespaces in from field before interepreting it to improve consistency with other options. The split_addrs function already take care of trailing and leading whitespaces for to, cc and bcc fields. The from option now: - has the same behavior when passing arguments l