Re: [PATCH/RFC v3 01/12] pack-objects: a bit of document about struct object_entry

2018-03-09 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > The role of this comment block becomes more important after we shuffle > fields around to shrink this struct. It will be much harder to see what > field is related to what. This also documents the holes in this struct > according to pahole. > > A couple of notes on

[PATCH/RFC v3 01/12] pack-objects: a bit of document about struct object_entry

2018-03-08 Thread Nguyễn Thái Ngọc Duy
The role of this comment block becomes more important after we shuffle fields around to shrink this struct. It will be much harder to see what field is related to what. This also documents the holes in this struct according to pahole. A couple of notes on shrinking the struct: 1) The reader may n