Re: [PATCH/RFC 3/4] attr: do not attempt to expand when we know it's not a macro

2014-12-09 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > Keep track of all recognized macros in the new "maybe_macro" field. > This this field is true, it _may_ be a macro (depending on what's in > the current attr stack). But if the field is false, it's definitely > not a macro, no need to go through the whole attr stac

Re: [PATCH/RFC 3/4] attr: do not attempt to expand when we know it's not a macro

2014-12-09 Thread Eric Sunshine
On Tue, Dec 9, 2014 at 8:53 AM, Nguyễn Thái Ngọc Duy wrote: > Keep track of all recognized macros in the new "maybe_macro" field. > This this field is true, it _may_ be a macro (depending on what's in s/This this/If this/ > the current attr stack). But if the field is false, it's definitely > no

[PATCH/RFC 3/4] attr: do not attempt to expand when we know it's not a macro

2014-12-09 Thread Nguyễn Thái Ngọc Duy
Keep track of all recognized macros in the new "maybe_macro" field. This this field is true, it _may_ be a macro (depending on what's in the current attr stack). But if the field is false, it's definitely not a macro, no need to go through the whole attr stack in macroexpand_one() to search for one