Re: [PATCH/RFC 2/2] git rebase -i: Warn removed or dupplicated commits

2015-05-28 Thread Junio C Hamano
Remi Galan Alfonso writes: > Junio C Hamano writes: >> I think there is a difference between (silently) accepting just to >> be lenient and documenting and advocating mixed case uses. >> >> Personally, I'd rather not to see gratuitous flexibility to allow >> the same thing spelled in 47 differe

Re: [PATCH/RFC 2/2] git rebase -i: Warn removed or dupplicated commits

2015-05-28 Thread Remi Galan Alfonso
Junio C Hamano writes: > I think there is a difference between (silently) accepting just to > be lenient and documenting and advocating mixed case uses. > > Personally, I'd rather not to see gratuitous flexibility to allow > the same thing spelled in 47 different ways for no good reason. It was

Re: [PATCH/RFC 2/2] git rebase -i: Warn removed or dupplicated commits

2015-05-27 Thread Junio C Hamano
Matthieu Moy writes: > Stephen Kelly writes: > >> Galan Rémi ensimag.grenoble-inp.fr> writes: >> >>> >>> Check if commits were removed (i.e. a line was deleted) or dupplicated >>> (e.g. the same commit is picked twice), can print warnings or abort >>> git rebase according to the value of the c

Re: [PATCH/RFC 2/2] git rebase -i: Warn removed or dupplicated commits

2015-05-27 Thread Junio C Hamano
Remi Galan Alfonso writes: > Thank you for reviewing the code. > > Eric Sunshine writes: >> > + # To uppercase >> > + checkLevel=$(echo "$checkLevel" | tr '[:lower:]' '[:upper:]') >> >> Is there precedence elsewhere for recognizing uppercase and lowercase >> variants of config value

Re: [PATCH/RFC 2/2] git rebase -i: Warn removed or dupplicated commits

2015-05-27 Thread Eric Sunshine
On Wed, May 27, 2015 at 9:19 AM, Remi Galan Alfonso wrote: > Eric Sunshine writes: >> > + # To uppercase >> > + checkLevel=$(echo "$checkLevel" | tr '[:lower:]' '[:upper:]') >> >> Is there precedence elsewhere for recognizing uppercase and lowercase >> variants of config values? > > It

Re: [PATCH/RFC 2/2] git rebase -i: Warn removed or dupplicated commits

2015-05-27 Thread Remi Galan Alfonso
Eric Sunshine writes: > Shouldn't this case also 'die' when rebase.checkLevel is "error"? And, > why doesn't the user get advice about configuring rebase.checkLevel in > this case? Stephen Kelly writes: > I sometimes duplicate commits deliberately if I want to split a commit in > two. Matthieu Moy

Re: [PATCH/RFC 2/2] git rebase -i: Warn removed or dupplicated commits

2015-05-27 Thread Remi Galan Alfonso
Thank you for reviewing the code. Eric Sunshine writes: > > + # To uppercase > > + checkLevel=$(echo "$checkLevel" | tr '[:lower:]' '[:upper:]') > > Is there precedence elsewhere for recognizing uppercase and lowercase > variants of config values? It seems to be commonly used when p

Re: [PATCH/RFC 2/2] git rebase -i: Warn removed or dupplicated commits

2015-05-27 Thread Matthieu Moy
Stephen Kelly writes: > Galan Rémi ensimag.grenoble-inp.fr> writes: > >> >> Check if commits were removed (i.e. a line was deleted) or dupplicated >> (e.g. the same commit is picked twice), can print warnings or abort >> git rebase according to the value of the configuration variable >> rebase.

Re: [PATCH/RFC 2/2] git rebase -i: Warn removed or dupplicated commits

2015-05-27 Thread Stephen Kelly
Galan Rémi ensimag.grenoble-inp.fr> writes: > > Check if commits were removed (i.e. a line was deleted) or dupplicated > (e.g. the same commit is picked twice), can print warnings or abort > git rebase according to the value of the configuration variable > rebase.checkLevel. I sometimes duplica

Re: [PATCH/RFC 2/2] git rebase -i: Warn removed or dupplicated commits

2015-05-26 Thread Eric Sunshine
On Tue, May 26, 2015 at 5:38 PM, Galan Rémi wrote: > git rebase -i: Warn removed or dupplicated commits s/dupplicated/duplicated/ Also, drop capitalization, and insert "about": git rebase -i: warn about removed or duplicated commits > Check if commits were removed (i.e. a line was deleted)

[PATCH/RFC 2/2] git rebase -i: Warn removed or dupplicated commits

2015-05-26 Thread Galan Rémi
Check if commits were removed (i.e. a line was deleted) or dupplicated (e.g. the same commit is picked twice), can print warnings or abort git rebase according to the value of the configuration variable rebase.checkLevel. Add the configuration variable rebase.checkLevel. - When unset or set to