Re: [PATCH/RFC 1/4] contrib: add git-contacts helper

2013-07-02 Thread Eric Sunshine
On Tue, Jul 2, 2013 at 2:32 PM, Junio C Hamano wrote: > Eric Sunshine writes: > >>> The author name and email can be grabbed from the "blame" output >>> without doing this (and the result may be more robust), but you >>> would need to read from the log message anyway, so I think this is >>> OK. >

Re: [PATCH/RFC 1/4] contrib: add git-contacts helper

2013-07-02 Thread Junio C Hamano
Eric Sunshine writes: >> The author name and email can be grabbed from the "blame" output >> without doing this (and the result may be more robust), but you >> would need to read from the log message anyway, so I think this is >> OK. >> >> Note that the names and emails in blame output are saniti

Re: [PATCH/RFC 1/4] contrib: add git-contacts helper

2013-07-02 Thread Eric Sunshine
On Mon, Jul 1, 2013 at 2:39 PM, Junio C Hamano wrote: > Eric Sunshine writes: > >> diff --git a/contrib/contacts/git-contacts b/contrib/contacts/git-contacts >> new file mode 100755 >> index 000..9007bae >> --- /dev/null >> +++ b/contrib/contacts/git-contacts >> @@ -0,0 +1,121 @@ >> +#!/usr/b

Re: [PATCH/RFC 1/4] contrib: add git-contacts helper

2013-07-01 Thread Junio C Hamano
Junio C Hamano writes: > - If the patch were prepared with a non-standard src/dst-prefix, >unconditional substr($1, 2) would call blame on a wrong (and >likely to be nonexistent) path without a useful diagnosis (the >invocation of "git blame" will likely die with "no such path >'

Re: [PATCH/RFC 1/4] contrib: add git-contacts helper

2013-07-01 Thread Junio C Hamano
Eric Sunshine writes: > diff --git a/contrib/contacts/git-contacts b/contrib/contacts/git-contacts > new file mode 100755 > index 000..9007bae > --- /dev/null > +++ b/contrib/contacts/git-contacts > @@ -0,0 +1,121 @@ > +#!/usr/bin/perl > + > +# List people who might be interested in a patch.

[PATCH/RFC 1/4] contrib: add git-contacts helper

2013-06-30 Thread Eric Sunshine
This script lists people that might be interested in a patch by going back through the history for each patch hunk, and finding people that reviewed, acknowledge, signed, or authored the code the patch is modifying. It does this by running git-blame incrementally on each hunk and then parsing the