Re: [PATCH/RFC 1/2] sha1_file: close all pack files after running

2015-10-05 Thread Johannes Schindelin
Hi Max, On 2015-10-05 06:57, Max Kirillov wrote: > On Sun, Oct 04, 2015 at 04:53:30PM +0200, Johannes Schindelin wrote: >> I guess then we would need two different patches for the >> two different fixes, at least. >> >> So now I am unsure how to proceed: I do not want to step >> on your toes, but

Re: [PATCH/RFC 1/2] sha1_file: close all pack files after running

2015-10-04 Thread Max Kirillov
On Sun, Oct 04, 2015 at 04:53:30PM +0200, Johannes Schindelin wrote: > I guess then we would need two different patches for the > two different fixes, at least. > > So now I am unsure how to proceed: I do not want to step > on your toes, but I also want to see my use case fixed and > I want to mov

Re: [PATCH/RFC 1/2] sha1_file: close all pack files after running

2015-10-04 Thread Johannes Schindelin
Hi Max, On 2015-10-02 21:21, Max Kirillov wrote: > On Fri, Oct 02, 2015 at 12:13:40PM +0200, Johannes Schindelin wrote: >> On 2015-10-02 12:05, Johannes Schindelin wrote: >> >> > On 2015-10-01 05:29, Max Kirillov wrote: When a builtin has done its job, but waits for pager or not waited b

Re: [PATCH/RFC 1/2] sha1_file: close all pack files after running

2015-10-02 Thread Max Kirillov
On Fri, Oct 02, 2015 at 10:06:46PM +0300, Max Kirillov wrote: > for i in $(seq 1000) > t_git -c core.packedGitWindowSize=100 log It was 32-bit build. I cannot promise those exactly numbers will work, because I don not clearly understand what do they mean. With 100 commits the pack size was 20K, bu

Re: [PATCH/RFC 1/2] sha1_file: close all pack files after running

2015-10-02 Thread Max Kirillov
On Fri, Oct 02, 2015 at 12:13:40PM +0200, Johannes Schindelin wrote: > Hi Max, > > On 2015-10-02 12:05, Johannes Schindelin wrote: > > > On 2015-10-01 05:29, Max Kirillov wrote: >>> When a builtin has done its job, but waits for pager or not waited >>> by its caller and still hanging it keeps pac

Re: [PATCH/RFC 1/2] sha1_file: close all pack files after running

2015-10-02 Thread Max Kirillov
On Fri, Oct 02, 2015 at 12:05:55PM +0200, Johannes Schindelin wrote: > Hi Max, > > On 2015-10-01 05:29, Max Kirillov wrote: >> When a builtin has done its job, but waits for pager or not waited >> by its caller and still hanging it keeps pack files opened. >> This can cause a number of issues, for

Re: [PATCH/RFC 1/2] sha1_file: close all pack files after running

2015-10-02 Thread Johannes Schindelin
Hi Max, On 2015-10-02 12:05, Johannes Schindelin wrote: > On 2015-10-01 05:29, Max Kirillov wrote: >> When a builtin has done its job, but waits for pager or not waited >> by its caller and still hanging it keeps pack files opened. >> This can cause a number of issues, for example on Windows git

Re: [PATCH/RFC 1/2] sha1_file: close all pack files after running

2015-10-02 Thread Johannes Schindelin
Hi Max, On 2015-10-01 05:29, Max Kirillov wrote: > When a builtin has done its job, but waits for pager or not waited > by its caller and still hanging it keeps pack files opened. > This can cause a number of issues, for example on Windows git gc > cannot remove the packs. I did not experience th

[PATCH/RFC 1/2] sha1_file: close all pack files after running

2015-09-30 Thread Max Kirillov
When a builtin has done its job, but waits for pager or not waited by its caller and still hanging it keeps pack files opened. This can cause a number of issues, for example on Windows git gc cannot remove the packs. Fix this by explicitly closing all pack files and unmapping memory from the packs