Re: [PATCH/RFC] fsck: complain when .gitignore and .gitattributes are symlinks

2019-01-22 Thread Ramsay Jones
On 22/01/2019 07:23, Jeff King wrote: > On Fri, Jan 18, 2019 at 01:41:08AM +, Ramsay Jones wrote: > >> I don't do this "from time to time", but *every* build on all >> platforms! :-D >> >> As I have mentioned before, I run the script on 'master', 'next' >> and 'pu', but I don't look at the

Re: [PATCH/RFC] fsck: complain when .gitignore and .gitattributes are symlinks

2019-01-21 Thread Jeff King
On Fri, Jan 18, 2019 at 01:41:08AM +, Ramsay Jones wrote: > I don't do this "from time to time", but *every* build on all > platforms! :-D > > As I have mentioned before, I run the script on 'master', 'next' > and 'pu', but I don't look at the results for 'master', I simply > look at the diff

Re: [PATCH/RFC] fsck: complain when .gitignore and .gitattributes are symlinks

2019-01-17 Thread Ramsay Jones
On 17/01/2019 21:24, Jeff King wrote: > On Thu, Jan 17, 2019 at 12:13:12PM -0800, Junio C Hamano wrote: > >>> @@ -966,7 +968,9 @@ int verify_path(const char *path, unsigned mode) >>> if (is_hfs_dotgit(path)) >>> return 0; >>>

Re: [PATCH/RFC] fsck: complain when .gitignore and .gitattributes are symlinks

2019-01-17 Thread Jeff King
On Thu, Jan 17, 2019 at 12:13:12PM -0800, Junio C Hamano wrote: > > @@ -966,7 +968,9 @@ int verify_path(const char *path, unsigned mode) > > if (is_hfs_dotgit(path)) > > return 0; > > if (S_ISLNK(mode)) { >

Re: [PATCH/RFC] fsck: complain when .gitignore and .gitattributes are symlinks

2019-01-17 Thread Junio C Hamano
Jeff King writes: > Hmm. I think this commit message isn't quite right, because we also > skipped the patches to touch gitignore/gitattributes in verify_path(). > > Are you thinking we should resurrect that behavior[1], too, or just > protect at the fsck level? > >> It was omitted from that serie

Re: [PATCH/RFC] fsck: complain when .gitignore and .gitattributes are symlinks

2019-01-17 Thread Jeff King
On Mon, Jan 14, 2019 at 03:09:02PM -0800, Jonathan Nieder wrote: > From: Jeff King > Date: Sun, 13 May 2018 14:14:34 -0400 > > This case is already forbidden by verify_path(), so let's > check it in fsck. It's easier to handle than .gitmodules, > because we don't care about checking the blob con

[PATCH/RFC] fsck: complain when .gitignore and .gitattributes are symlinks

2019-01-14 Thread Jonathan Nieder
From: Jeff King Date: Sun, 13 May 2018 14:14:34 -0400 This case is already forbidden by verify_path(), so let's check it in fsck. It's easier to handle than .gitmodules, because we don't care about checking the blob content. This is really just about whether the name and mode for the tree entry a