On Thu, Mar 03, 2016 at 05:05:03PM -0500, Santiago Torres wrote:
> I've been trying to shape these changes into sensible patch, but it is
> not as trivial as I originally thought. I think the issue lies in the
> tag desambiguation aspect of the git-tag command.
>
> It seems that verify-tag can ta
Hi Peff.
I've been trying to shape these changes into sensible patch, but it is
not as trivial as I originally thought. I think the issue lies in the
tag desambiguation aspect of the git-tag command.
It seems that verify-tag can take either the refname or the hash of the
object. However, git tag
On Sat, Feb 27, 2016 at 12:45:24PM -0500, Santiago Torres wrote:
> > A much more interesting change in this area, I think, would be to skip
> > verify-tag entirely. Once upon a time it had a lot of logic itself, but
> > these days it is a thin wrapper over run_gpg_verify(), and we could
> > improv
Hello Jeff, thanks for going through the patch.
> > diff --git a/builtin/tag.c b/builtin/tag.c
> > index 1705c94..5de1161 100644
> > --- a/builtin/tag.c
> > +++ b/builtin/tag.c
> > @@ -105,8 +105,7 @@ static int verify_tag(const char *name, const char *ref,
> > const u
On Fri, Feb 26, 2016 at 07:27:44PM -0500, santi...@nyu.edu wrote:
> From: Santiago Torres
>
> The verify tag function converts the commit sha1 to hex and passes it as
> a command-line argument to builtin/verify-tag. Given that builtin/verify-tag
> already resolves the ref name sha1 equivalent, t
From: Santiago Torres
The verify tag function converts the commit sha1 to hex and passes it as
a command-line argument to builtin/verify-tag. Given that builtin/verify-tag
already resolves the ref name sha1 equivalent, the sha1 to
hex_sha1 conversion is unnecessary and the ref-name can be used in
6 matches
Mail list logo
