On Tue, 2017-06-20 at 09:57 -0700, Stefan Beller wrote:
> canonical: "according to recognized rules or scientific laws."
> sounds about right. :)
>
I actually used as I found it to have the meaning of "conforming to
orthodox or recognized rules" :)
> While this was just reflowed and not newly in
On Tue, Jun 20, 2017 at 9:57 AM, Stefan Beller wrote:
>
> With or without this nit addressed, this patch looks good to me,
>
Well actually not quite. The subject (and commit message) is very vague,
maybe:
Documentation/git-submodule: cleanup "add" section
The "add" section for 'git-subm
On Mon, Jun 19, 2017 at 8:12 PM, Kaartic Sivaraam
wrote:
> Make following changes to the git-submodule
> documentation:
>
> * Remove redundancy
> * Remove unclear back reference
> * Use more appropriate word
> * Quote important word
>
> Suggestions-by: Stefan Beller
> Signed-off-by: Kaartic Sivar
Make following changes to the git-submodule
documentation:
* Remove redundancy
* Remove unclear back reference
* Use more appropriate word
* Quote important word
Suggestions-by: Stefan Beller
Signed-off-by: Kaartic Sivaraam
---
Currently used the word "canonical" instead of "humanish". If that
On Mon, Jun 19, 2017 at 10:33 AM, Kaartic Sivaraam
wrote:
>
>> Please markup the '.gitmodules' either via single quotes or `.
>> (or even link to 'gitmodules(5)' )
>>
> Marked it up using `. Help needed to link to 'gitmodules(5)', as I'm
> not sure how to provide alternative text to 'linkgit:'.
On Sun, 2017-06-18 at 22:50 -0700, Stefan Beller wrote:
> > > diff --git a/Documentation/git-submodule.txt b/Documentation/git-
> > > submodule.txt
> > > index 74bc6200d..9812b0655 100644
> > > --- a/Documentation/git-submodule.txt
> > > +++ b/Documentation/git-submodule.txt
> > > @@ -63,13 +63,7 @
On Sun, Jun 18, 2017 at 10:24 PM, Junio C Hamano wrote:
> Stefan, this was sent in my way, but I know you are the primary
> person who is looking into updating submodule documentation these
> days, so I am forwarding it in your way to ask you to give the first
> comment.
>
> Thanks.
AFAICT this i
Stefan, this was sent in my way, but I know you are the primary
person who is looking into updating submodule documentation these
days, so I am forwarding it in your way to ask you to give the first
comment.
Thanks.
Kaartic Sivaraam writes:
> 1. Remove redundancy from documentation
> 2. Remov
1. Remove redundancy from documentation
2. Remove unclear reference to alternative
Signed-off-by: Kaartic Sivaraam
---
The following line seemes unclear and hence was removed for now. Suggest any
changes that could make it clear.
"This second form is provided to ease creating a new submodule fr
9 matches
Mail list logo
