Re: [GSoC] Convert “git stash” to builtin proposal

On Sun, Mar 25, 2018 at 4:38 PM, Paul-Sebastian Ungureanu wrote: > On 25.03.2018 12:46, Christian Couder wrote: >> >> On Sat, Mar 24, 2018 at 8:31 PM, Paul-Sebastian Ungureanu >> wrote: >>> >>> On 23.03.2018 19:11, Christian Couder wrote: >>> > * Ensure that no regression occurred: considerin

Re: [GSoC] Convert “git stash” to builtin proposal

Hi Paul, On Sun, 25 Mar 2018, Paul-Sebastian Ungureanu wrote: > One thing I did not mention in the previous reply was that I also added > a new paragraph to "Benefits to community" about 'git stash' being slow > on Windows for a lot of users. I consider this alone to be a very good > justificatio

Re: [GSoC] Convert “git stash” to builtin proposal

On 25.03.2018 12:46, Christian Couder wrote: On Sat, Mar 24, 2018 at 8:31 PM, Paul-Sebastian Ungureanu wrote: On 23.03.2018 19:11, Christian Couder wrote: * Ensure that no regression occurred: considering that there are plenty of tests and that I have a good understanding of the function, thi

Re: [GSoC] Convert “git stash” to builtin proposal

On 23.03.2018 19:06, Johannes Schindelin wrote: [... proposal ...] This is a pretty good proposal. The initial draft at converting `stash list` is a good start (it will need to be converted to avoid spawning an extra process, but that is something we can do incrementally, together). Thank you

Re: [GSoC] Convert “git stash” to builtin proposal

On Sat, Mar 24, 2018 at 8:31 PM, Paul-Sebastian Ungureanu wrote: > On 23.03.2018 19:11, Christian Couder wrote: > >>> * Ensure that no regression occurred: considering that there are plenty >>> of tests and that I have a good understanding of the function, this >>> should be a trivial task. >> >>

Re: [GSoC] Convert “git stash” to builtin proposal

On 23.03.2018 19:11, Christian Couder wrote: * Ensure that no regression occurred: considering that there are plenty of tests and that I have a good understanding of the function, this should be a trivial task. There are a lot of things that the test suite doesn't test. Hopefully, by first a

Re: [GSoC] Convert “git stash” to builtin proposal

On Fri, Mar 23, 2018 at 12:15 AM, Paul-Sebastian Ungureanu wrote: > > On Tue, 2018-03-20 at 23:08 +0100, Christian Couder wrote: >> >> On Tue, Mar 20, 2018 at 9:09 PM, Paul-Sebastian Ungureanu >> wrote: >> > >> > * Convert function: this step is basically makes up the goal of >> > this >> > proje

Re: [GSoC] Convert “git stash” to builtin proposal

Hi Paul-Sebastian, On Fri, 23 Mar 2018, Paul-Sebastian Ungureanu wrote: > On Tue, 2018-03-20 at 23:08 +0100, Christian Couder wrote: > > Hi, > > > > On Tue, Mar 20, 2018 at 9:09 PM, Paul-Sebastian Ungureanu > > wrote: > > > > > > * Convert function: this step is basically makes up the goal of

Re: [GSoC] Convert “git stash” to builtin proposal

Hello, On Tue, 2018-03-20 at 23:08 +0100, Christian Couder wrote: > Hi, > > On Tue, Mar 20, 2018 at 9:09 PM, Paul-Sebastian Ungureanu > wrote: > > > > * Convert function: this step is basically makes up the goal of > > this > > project. > > Could you explain a bit more how you would convert a

Re: [GSoC] Convert “git stash” to builtin proposal

Hi, On Tue, Mar 20, 2018 at 9:09 PM, Paul-Sebastian Ungureanu wrote: > > * Convert function: this step is basically makes up the goal of this > project. Could you explain a bit more how you would convert a function? Or could you explain for example how you would convert "git stash list" below?

[GSoC] Convert “git stash” to builtin proposal

Hello, I have completed the first draft of my proposal for the Google Summer of Code, which can be found at [1] or below for those who prefer the text version. Any feedback is greatly appreciated. Thanks! [1] https://docs.google.com/document/d/1TtdD7zgUsEOszHG5HX1at4zHMDsPmSBYWqy dOPTTpV8/edit?u