Re: [GSoC][RFC/PATCH] userdiff: added support for diffing shell scripts

2019-03-29 Thread Thomas Gummerer
On 03/29, Kapil Jain wrote: > On Fri, Mar 29, 2019 at 3:00 AM Thomas Gummerer wrote: > > > > > > I had previously mentioned that this project was attempted already in > > my email at [*1*]. Did you take a look at the thread I linked to > > there, and the regex used? I still feel like that previo

Re: [GSoC][RFC/PATCH] userdiff: added support for diffing shell scripts

2019-03-29 Thread Kapil Jain
On Fri, Mar 29, 2019 at 3:00 AM Thomas Gummerer wrote: > > > I had previously mentioned that this project was attempted already in > my email at [*1*]. Did you take a look at the thread I linked to > there, and the regex used? I still feel like that previous experience > is something you could l

Re: [GSoC][RFC/PATCH] userdiff: added support for diffing shell scripts

2019-03-28 Thread Thomas Gummerer
On 03/24, Kapil Jain wrote: > On Sun, Mar 24, 2019 at 2:49 PM Christian Couder > wrote: > > > > The test_language_driver() function used to test the regexps is > > ... > > GIT_TEST_CMP which is usually either "diff -u" or "diff -c". > > Thanks. > > please provide some insights on the regex menti

Re: [GSoC][RFC/PATCH] userdiff: added support for diffing shell scripts

2019-03-24 Thread Kapil Jain
On Sun, Mar 24, 2019 at 2:49 PM Christian Couder wrote: > > The test_language_driver() function used to test the regexps is > ... > GIT_TEST_CMP which is usually either "diff -u" or "diff -c". Thanks. please provide some insights on the regex mentioned below: + +PATTERNS("shell", + /* Function

Re: [GSoC][RFC/PATCH] userdiff: added support for diffing shell scripts

2019-03-24 Thread Christian Couder
On Sun, Mar 24, 2019 at 9:04 AM Kapil Jain wrote: > > On Sun, Mar 24, 2019 at 1:34 AM Christian Couder > wrote: > > > > To save some work by people who could help you, it might be a good > > idea to show the output of the failing test, for example the output of > > `./t4034-diff-words.sh -i -v` o

Re: [GSoC][RFC/PATCH] userdiff: added support for diffing shell scripts

2019-03-24 Thread Kapil Jain
On Sun, Mar 24, 2019 at 1:34 AM Christian Couder wrote: > > To save some work by people who could help you, it might be a good > idea to show the output of the failing test, for example the output of > `./t4034-diff-words.sh -i -v` or `./t4034-diff-words.sh -i -v -x`. Looks like i just needed to

Re: [GSoC][RFC/PATCH] userdiff: added support for diffing shell scripts

2019-03-23 Thread Christian Couder
On Fri, Mar 22, 2019 at 5:08 PM Kapil Jain wrote: > > Signed-off-by: Kapil Jain > --- > > The test written does not pass, imo there's some problem with the regex part. > please let me know about the fault. To save some work by people who could help you, it might be a good idea to show the output

[GSoC][RFC/PATCH] userdiff: added support for diffing shell scripts

2019-03-22 Thread Kapil Jain
Signed-off-by: Kapil Jain --- The test written does not pass, imo there's some problem with the regex part. please let me know about the fault. t/t4034-diff-words.sh | 2 ++ t/t4034/shell/expect | 6 ++ t/t4034/shell/post| 1 + t/t4034/shell/pre | 1 + userdiff.c| 7 +++