Re: [GSoC][PATCH v4] fixup! rebase -i: rewrite write_basic_state() in C

2018-07-31 Thread Junio C Hamano
Junio C Hamano writes: > As the number of his or her own topics each contributor needs to > keep track of by definition is the number of all topics I need to s/is the/is smaller than the/; Sorry for the noise X-<. > take care of, I do not want to have to keep track of things myself > more than

Re: [GSoC][PATCH v4] fixup! rebase -i: rewrite write_basic_state() in C

2018-07-31 Thread Junio C Hamano
Alban Gruin writes: >> Hmph, from reading your other message >> >> >> https://public-inbox.org/git/dce8c99b-51e9-4ed1-8ae4-28049cb6e...@gmail.com/ >> >> I got an impression that a rerolled version is coming anyway. Is >> this fix so urgent that it needs tobe squashed in in the meantime >> a

Re: [GSoC][PATCH v4] fixup! rebase -i: rewrite write_basic_state() in C

2018-07-31 Thread Alban Gruin
Hi Junio, Le 31/07/2018 à 17:23, Junio C Hamano a écrit : > Alban Gruin writes: > >> As pointed out by SZEDER Gábor, git-rebase.sh wrote to to 'quiet' with >> an `echo`: >> >> echo "$GIT_QUIET" > "$state_dir/quiet" >> >> This mean that even if $GIT_QUIET is empty, a newline is written to >>

Re: [GSoC][PATCH v4] fixup! rebase -i: rewrite write_basic_state() in C

2018-07-31 Thread Junio C Hamano
Alban Gruin writes: > As pointed out by SZEDER Gábor, git-rebase.sh wrote to to 'quiet' with > an `echo`: > > echo "$GIT_QUIET" > "$state_dir/quiet" > > This mean that even if $GIT_QUIET is empty, a newline is written to > quiet. The rewrite of write_basic_state() changed this behaviour, whi

[GSoC][PATCH v4] fixup! rebase -i: rewrite write_basic_state() in C

2018-07-31 Thread Alban Gruin
As pointed out by SZEDER Gábor, git-rebase.sh wrote to to 'quiet' with an `echo`: echo "$GIT_QUIET" > "$state_dir/quiet" This mean that even if $GIT_QUIET is empty, a newline is written to quiet. The rewrite of write_basic_state() changed this behaviour, which could lead to problems. This p