Re: [GSoC][PATCH v3 2/3] t0000: avoid using pipes

2019-03-24 Thread Ævar Arnfjörð Bjarmason
On Sun, Mar 24 2019, jonathan chang wrote: > On Mon, Mar 18, 2019 at 12:47 AM Ævar Arnfjörð Bjarmason > wrote: >> >> >> On Sun, Mar 17 2019, Jonathan Chang wrote: >> >> > The exit code of the upstream in a pipe is ignored thus we should avoid >> > using it. By writing out the output of the git

Re: [GSoC][PATCH v3 2/3] t0000: avoid using pipes

2019-03-24 Thread jonathan chang
On Mon, Mar 18, 2019 at 12:47 AM Ævar Arnfjörð Bjarmason wrote: > > > On Sun, Mar 17 2019, Jonathan Chang wrote: > > > The exit code of the upstream in a pipe is ignored thus we should avoid > > using it. By writing out the output of the git command to a file, we can > > test the exit codes of bot

Re: [GSoC][PATCH v3 2/3] t0000: avoid using pipes

2019-03-17 Thread Ævar Arnfjörð Bjarmason
On Sun, Mar 17 2019, Jonathan Chang wrote: > The exit code of the upstream in a pipe is ignored thus we should avoid > using it. By writing out the output of the git command to a file, we can > test the exit codes of both the commands. > > Signed-off-by: Jonathan Chang > --- > t/t-basic.sh

[GSoC][PATCH v3 2/3] t0000: avoid using pipes

2019-03-17 Thread Jonathan Chang
The exit code of the upstream in a pipe is ignored thus we should avoid using it. By writing out the output of the git command to a file, we can test the exit codes of both the commands. Signed-off-by: Jonathan Chang --- t/t-basic.sh | 28 ++-- 1 file changed, 14 inse