Re: [GSoC][PATCH v2 3/5] t0003-attributes: avoid using pipes

2019-03-14 Thread jonathan chang
On Sun, Mar 10, 2019 at 6:13 PM Eric Sunshine wrote: > > On Sun, Mar 10, 2019 at 4:09 AM Jonathan Chang wrote: > > The exit code of the upstream in a pipe is ignored thus we should avoid > > using it. By writing out the output of the git command to a file, we can > > test the exit codes of both t

Re: [GSoC][PATCH v2 3/5] t0003-attributes: avoid using pipes

2019-03-10 Thread Eric Sunshine
On Sun, Mar 10, 2019 at 4:09 AM Jonathan Chang wrote: > The exit code of the upstream in a pipe is ignored thus we should avoid > using it. By writing out the output of the git command to a file, we can > test the exit codes of both the commands. > > Signed-off-by: Jonathan Chang > > diff --git a

[GSoC][PATCH v2 3/5] t0003-attributes: avoid using pipes

2019-03-10 Thread Jonathan Chang
The exit code of the upstream in a pipe is ignored thus we should avoid using it. By writing out the output of the git command to a file, we can test the exit codes of both the commands. Signed-off-by: Jonathan Chang diff --git a/t/t0003-attributes.sh b/t/t0003-attributes.sh index 71e63d8b50..14