Re: [GSoC][PATCH v2] log: forbid log --graph --no-walk

2015-03-14 Thread brian m. carlson
On Sun, Mar 15, 2015 at 01:55:28AM +0200, epilys wrote: > On 03/15/2015 01:47 AM, brian m. carlson wrote: > > It looks like you indented here with four spaces instead of a tab. > > We prefer tabs in Git. > > Messed that up. Do you think I should resubmit a v3 or am I hogging > the mailing list to

Re: [GSoC][PATCH v2] log: forbid log --graph --no-walk

2015-03-14 Thread epilys
On 03/15/2015 01:47 AM, brian m. carlson wrote: > It looks like you indented here with four spaces instead of a tab. > We prefer tabs in Git. Messed that up. Do you think I should resubmit a v3 or am I hogging the mailing list too much? -- To unsubscribe from this list: send the line "unsubscrib

Re: [GSoC][PATCH v2] log: forbid log --graph --no-walk

2015-03-14 Thread brian m. carlson
On Sun, Mar 15, 2015 at 01:33:07AM +0200, epilys wrote: > diff --git a/builtin/log.c b/builtin/log.c > index dd8f3fc..0194133 100644 > --- a/builtin/log.c > +++ b/builtin/log.c > @@ -155,6 +155,8 @@ static void cmd_log_init_finish(int argc, const char > **argv, const char *prefix, > memset(&

[GSoC][PATCH v2] log: forbid log --graph --no-walk

2015-03-14 Thread epilys
In git-log, --graph shows a graphical representation of a continuous commit history, and --no-walk shows discrete specified commits without continuity. Using both doesn't make sense, so we forbid the combined use of these flags. Signed-off-by: Manos Pitsidianakis --- builtin/log.c | 2 ++ t/t42