Re: [GSoC][PATCH 4/8] submodule: port submodule subcommand 'status' from shell to C

2017-07-18 Thread Junio C Hamano
On Tue, Jul 18, 2017 at 3:44 PM, Stefan Beller wrote: > On Tue, Jul 18, 2017 at 3:32 PM, Junio C Hamano wrote: >> Stefan Beller writes: >> + if (!lstat(list_item->name, &st) && !ce_match_stat(list_item, &st, 0)) { + print_status(info, ' ', list_item->name, sub

Re: [GSoC][PATCH 4/8] submodule: port submodule subcommand 'status' from shell to C

2017-07-18 Thread Stefan Beller
On Tue, Jul 18, 2017 at 3:32 PM, Junio C Hamano wrote: > Stefan Beller writes: > >>> + if (!lstat(list_item->name, &st) && !ce_match_stat(list_item, &st, >>> 0)) { >>> + print_status(info, ' ', list_item->name, sub_sha1, >>> displaypath); >> >> The question from the last rou

Re: [GSoC][PATCH 4/8] submodule: port submodule subcommand 'status' from shell to C

2017-07-18 Thread Junio C Hamano
Stefan Beller writes: >> + if (!lstat(list_item->name, &st) && !ce_match_stat(list_item, &st, >> 0)) { >> + print_status(info, ' ', list_item->name, sub_sha1, >> displaypath); > > The question from the last round still stands > https://public-inbox.org/git/cagz79kb18z5zc9iu3

Re: [GSoC][PATCH 4/8] submodule: port submodule subcommand 'status' from shell to C

2017-07-18 Thread Stefan Beller
On Tue, Jul 18, 2017 at 1:49 PM, Prathamesh Chavan wrote: > This aims to make git-submodule 'status' a built-in. Hence, the function > cmd_status() is ported from shell to C. This is done by introducing > three functions: module_status(), submodule_status() and print_status(). > > The function mod

[GSoC][PATCH 4/8] submodule: port submodule subcommand 'status' from shell to C

2017-07-18 Thread Prathamesh Chavan
This aims to make git-submodule 'status' a built-in. Hence, the function cmd_status() is ported from shell to C. This is done by introducing three functions: module_status(), submodule_status() and print_status(). The function module_status() acts as the front-end of the subcommand. It parses subc

Re: [GSoC][PATCH 4/8] submodule: port submodule subcommand 'status' from shell to C

2017-07-10 Thread Brandon Williams
On 07/11, Prathamesh Chavan wrote: > This aims to make git-submodule 'status' a built-in. Hence, the function > cmd_status() is ported from shell to C. This is done by introducing > three functions: module_status(), submodule_status() and print_status(). > > The function module_status() acts as th

[GSoC][PATCH 4/8] submodule: port submodule subcommand 'status' from shell to C

2017-07-10 Thread Prathamesh Chavan
This aims to make git-submodule 'status' a built-in. Hence, the function cmd_status() is ported from shell to C. This is done by introducing three functions: module_status(), submodule_status() and print_status(). The function module_status() acts as the front-end of the subcommand. It parses subc