Re: [GSoC][PATCH] test: avoid pipes in git related commands for test suite

On Mon, Mar 19, 2018 at 1:32 PM, Pratik Karki wrote: > Thank you Eric Sunshine, > I have done as you had instructed me. I look forward to more > understanding of the codebase and would love to fix > "git rev-parse" problems in my follow-on patches. > Thank you for the professional review comment.

[GSoC][PATCH] test: avoid pipes in git related commands for test suite

Thank you Eric Sunshine, I have done as you had instructed me. I look forward to more understanding of the codebase and would love to fix "git rev-parse" problems in my follow-on patches. Thank you for the professional review comment. Sorry for late follow-on patch, I got tied up with my universi

Re: [GSoC] [PATCH] test: avoid pipes in git related commands for test suite

Eric Sunshine writes: > Thanks for presenting an opposing opinion. While I understand your > position, the reason for my suggested transformation is that if the > patch already transformed the code in the way suggested, it would > increase my confidence, as a reviewer, that the patch author had >

Re: [GSoC] [PATCH] test: avoid pipes in git related commands for test suite

On Wed, Mar 14, 2018 at 5:57 AM, Ævar Arnfjörð Bjarmason wrote: > On Wed, Mar 14 2018, Eric Sunshine jotted: >> On Tue, Mar 13, 2018 at 4:19 PM, Pratik Karki >> wrote: >>> -'git diff-tree -r -M --name-status HEAD^ HEAD | \ >>> - grep "^R100..*path0/COPYING..*path2/COPYING" && >>> -

Re: [GSoC] [PATCH] test: avoid pipes in git related commands for test suite

On Wed, Mar 14 2018, Eric Sunshine jotted: > Thanks for the patch. See comments below... > > On Tue, Mar 13, 2018 at 4:19 PM, Pratik Karki wrote: >> This patch removes the necessity of pipes in git related commands for test >> suite. >> >> Exit code of the upstream in a pipe is ignored so, it's

Re: [GSoC] [PATCH] test: avoid pipes in git related commands for test suite

Thanks for the patch. See comments below... On Tue, Mar 13, 2018 at 4:19 PM, Pratik Karki wrote: > This patch removes the necessity of pipes in git related commands for test > suite. > > Exit code of the upstream in a pipe is ignored so, it's use should be > avoided. The fix for this is to writ

[GSoC] [PATCH] test: avoid pipes in git related commands for test suite

This patch removes the necessity of pipes in git related commands for test suite. Exit code of the upstream in a pipe is ignored so, it's use should be avoided. The fix for this is to write the output of the git command to a file and test the exit codes of both the commands being linked by pipe