Re: [BUG] redundant error message

2013-12-06 Thread Jeff King
On Fri, Dec 06, 2013 at 08:15:52AM +0700, Duy Nguyen wrote: > On Fri, Dec 6, 2013 at 4:28 AM, Jeff King wrote: > > BTW, the raw looping to find "--" made me wonder how we handle: > > > > git log --grep -- HEAD > > > > I'd expect it to be equivalent to: > > > > git log --grep=-- HEAD > > > > b

Re: [BUG] redundant error message

2013-12-05 Thread Duy Nguyen
On Fri, Dec 6, 2013 at 4:28 AM, Jeff King wrote: > BTW, the raw looping to find "--" made me wonder how we handle: > > git log --grep -- HEAD > > I'd expect it to be equivalent to: > > git log --grep=-- HEAD > > but it's not; we truncate the arguments and complain that --grep is > missing its

Re: [BUG] redundant error message

2013-12-05 Thread Junio C Hamano
Jeff King writes: > BTW, the raw looping to find "--" made me wonder how we handle: > > git log --grep -- HEAD > > I'd expect it to be equivalent to: > > git log --grep=-- HEAD > > but it's not; we truncate the arguments and complain that --grep is > missing its argument. Which is probably go

Re: [BUG] redundant error message

2013-12-05 Thread Jeff King
On Thu, Dec 05, 2013 at 04:00:00PM -0500, Jeff King wrote: > Yes, I do expect an error. But it should not be "-- after filename". It > should be "foobar is not a revision". > [...] > It would be nice to get the error messages right, though. I do not see > any reason why it could not follow the sam

Re: [BUG] redundant error message

2013-12-05 Thread Jeff King
On Thu, Dec 05, 2013 at 12:15:07PM -0800, Junio C Hamano wrote: > >> Hmph, it looks like it is following the usual "zero-or-more dashed > >> options, zero-or-more revs and then zero-or-one double-dash and then > >> zero-or-more paths" rule to parse the thing. "foobar" is a file and > >> not a rev

Re: [BUG] redundant error message

2013-12-05 Thread Junio C Hamano
Jeff King writes: > On Thu, Dec 05, 2013 at 12:00:16PM -0800, Junio C Hamano wrote: > >> Jeff King writes: >> >> > $ >foobar >> > $ git rev-parse foobar -- >> > foobar >> > -- >> > fatal: bad flag '--' used after filename >> > >> > That's not right. >> >> Hmph, it looks like it is fo

Re: [BUG] redundant error message

2013-12-05 Thread Jeff King
On Thu, Dec 05, 2013 at 12:00:16PM -0800, Junio C Hamano wrote: > Jeff King writes: > > > $ >foobar > > $ git rev-parse foobar -- > > foobar > > -- > > fatal: bad flag '--' used after filename > > > > That's not right. > > Hmph, it looks like it is following the usual "zero-or-more da

Re: [BUG] redundant error message

2013-12-05 Thread Junio C Hamano
Jeff King writes: > $ >foobar > $ git rev-parse foobar -- > foobar > -- > fatal: bad flag '--' used after filename > > That's not right. Hmph, it looks like it is following the usual "zero-or-more dashed options, zero-or-more revs and then zero-or-one double-dash and then zero-or-more

Re: [BUG] redundant error message

2013-12-05 Thread Jeff King
On Thu, Dec 05, 2013 at 05:07:31PM +0700, Duy Nguyen wrote: > $ git rev-parse foobar -- > foobar > fatal: ambiguous argument 'foobar': unknown revision or path not in > the working tree. > Use '--' to separate paths from revisions, like this: > 'git [...] -- [...]' > > I already put "--" there.

[BUG] redundant error message

2013-12-05 Thread Duy Nguyen
$ git rev-parse foobar -- foobar fatal: ambiguous argument 'foobar': unknown revision or path not in the working tree. Use '--' to separate paths from revisions, like this: 'git [...] -- [...]' I already put "--" there. So it should shut up. -- Duy -- To unsubscribe from this list: send the line