Re: [BUG] MSVC: error box when interrupting `gitlog` by quitting less

2014-03-28 Thread Johannes Sixt
Please do not cull the Cc list. Am 3/28/2014 11:07, schrieb Marat Radchenko: > Jeff King peff.net> writes: > >> >> I'm not sure what an actual SIGPIPE death looks like on Windows. > > There is no SIGPIPE death on Windows due to total absence of SIGPIPE. > raise(unsupported int) just causes ugly

Re: [BUG] MSVC: error box when interrupting `gitlog` by quitting less

2014-03-28 Thread Jeff King
On Fri, Mar 28, 2014 at 10:07:22AM +, Marat Radchenko wrote: > > What > > happens if git is still writing data to the pager and the pager exits? > > Does it receive a signal of some sort? > > I'm not sure what you mean, sorry. check_pipe properly detects pager exit. > The problem is with the

Re: [BUG] MSVC: error box when interrupting `gitlog` by quitting less

2014-03-28 Thread Marat Radchenko
Jeff King peff.net> writes: > > I'm not sure what an actual SIGPIPE death looks like on Windows. There is no SIGPIPE death on Windows due to total absence of SIGPIPE. raise(unsupported int) just causes ugly "git.exe has stopped working" window and possibly ends up as SIGABT (I don't know how to

Re: [BUG] MSVC: error box when interrupting `gitlog` by quitting less

2014-03-28 Thread Jeff King
On Fri, Mar 28, 2014 at 09:14:07AM +, Marat Radchenko wrote: > > Jeff King peff.net> writes: > > > > > > > > The write_or_die function will always die on an error, > > > including EPIPE. However, it currently treats EPIPE > > > specially by suppressing any error message, and by exiting > >

Re: [BUG] MSVC: error box when interrupting `gitlog` by quitting less

2014-03-28 Thread Marat Radchenko
Marat Radchenko slonopotamus.org> writes: > > Jeff King peff.net> writes: > > > > > The write_or_die function will always die on an error, > > including EPIPE. However, it currently treats EPIPE > > specially by suppressing any error message, and by exiting > > with exit code 0. > > This cau

[BUG] MSVC: error box when interrupting `gitlog` by quitting less

2014-03-28 Thread Marat Radchenko
Jeff King peff.net> writes: > > The write_or_die function will always die on an error, > including EPIPE. However, it currently treats EPIPE > specially by suppressing any error message, and by exiting > with exit code 0. This causes error box on Windows in MSVC=1 build: git.exe!_invoke_watson