Re: [BUG] "git --literal-pathspecs blame" broken in master

2013-10-24 Thread Jeff King
On Fri, Oct 25, 2013 at 11:16:08AM +0700, Nguyen Thai Ngoc Duy wrote: > > All of the GUARD_PATHSPEC calls indicate that everybody understands > > PATHSPEC_LITERAL. It is not technically true that git-blame understands > > the literal pathspec magic: > > > > $ git blame -- ':(literal)revision.c'

Re: [BUG] "git --literal-pathspecs blame" broken in master

2013-10-24 Thread Duy Nguyen
On Fri, Oct 25, 2013 at 11:04 AM, Jeff King wrote: > On Thu, Oct 24, 2013 at 11:49:47PM -0400, Jeff King wrote: > >> We get another change with a16bf9d (pathspec: make --literal-pathspecs >> disable pathspec magic, 2013-07-14), which I would think would fix >> things, but doesn't. >> >> $ git bl

Re: [BUG] "git --literal-pathspecs blame" broken in master

2013-10-24 Thread Duy Nguyen
On Fri, Oct 25, 2013 at 10:49 AM, Jeff King wrote: > $ git --literal-pathspecs blame ':(foo)bar' > fatal: :(foo)bar: pathspec magic not supported by this command: 'literal' > > The first one remains good, but the second one is still broken. I > haven't dug further yet, but I thought it might b

Re: [BUG] "git --literal-pathspecs blame" broken in master

2013-10-24 Thread Jeff King
On Thu, Oct 24, 2013 at 11:49:47PM -0400, Jeff King wrote: > We get another change with a16bf9d (pathspec: make --literal-pathspecs > disable pathspec magic, 2013-07-14), which I would think would fix > things, but doesn't. > > $ git blame ':(foo)bar' > fatal: Invalid pathspec magic 'foo' in

[BUG] "git --literal-pathspecs blame" broken in master

2013-10-24 Thread Jeff King
There seems to be a bad interaction with --literal-pathspecs and the pathspec magic that is in master. Here's an example: [setup] $ git init $ echo content >':(foo)bar' $ git add . && git commit -m foo [with git v1.8.4] $ git blame ':(foo)bar' ^6b07eb4 (Jeff King 2013-10-24 22:59:02