Re: New diff test failures on s390x architecture (was: [ANNOUNCE] Git v2.22.0-rc1)

2019-05-23 Thread Todd Zullinger
Hi, Duy Nguyen wrote: > On Fri, May 24, 2019 at 2:14 AM Todd Zullinger wrote: >> I am guessing it's no coincidence that this only fails on >> s390x and it is the only big endian architecture in the >> fedora build system. > > I see a problem with -w and wrong type casting. sizeof(int) and > size

Re: New diff test failures on s390x architecture (was: [ANNOUNCE] Git v2.22.0-rc1)

2019-05-23 Thread Duy Nguyen
On Fri, May 24, 2019 at 2:14 AM Todd Zullinger wrote: > > I wrote: > > While running the 2.22.0-rc1 tests on Fedora, I hit a few > > new test failures since 2.21.0 -- but only on the s390x > > architecture. > > > > I haven't had time to dig into these the past few days, so I > > thought I would se

Re: New diff test failures on s390x architecture (was: [ANNOUNCE] Git v2.22.0-rc1)

2019-05-23 Thread Todd Zullinger
I wrote: > While running the 2.22.0-rc1 tests on Fedora, I hit a few > new test failures since 2.21.0 -- but only on the s390x > architecture. > > I haven't had time to dig into these the past few days, so I > thought I would send what I do have in case the problem is > obvious to someone else. I

New diff test failures on s390x architecture (was: [ANNOUNCE] Git v2.22.0-rc1)

2019-05-23 Thread Todd Zullinger
[-cc: lkml, +cc: Duy as author of a good number of diff-related commits in 2.22.0 :) ] Hi, While running the 2.22.0-rc1 tests on Fedora, I hit a few new test failures since 2.21.0 -- but only on the s390x architecture. I haven't had time to dig into these the past few days, so I thought I would

Re: [ANNOUNCE] Git v2.22.0-rc1

2019-05-21 Thread Duy Nguyen
On Tue, May 21, 2019 at 6:24 PM Ævar Arnfjörð Bjarmason wrote: > > > On Tue, May 21 2019, Duy Nguyen wrote: > > > (dropping lkml and git-packagers) > > > > On Tue, May 21, 2019 at 3:31 PM Duy Nguyen wrote: > >> > The bug there is that the old opt_arg() code would be torelant to empty > >> > value

Re: [ANNOUNCE] Git v2.22.0-rc1

2019-05-21 Thread Ævar Arnfjörð Bjarmason
On Tue, May 21 2019, Duy Nguyen wrote: > (dropping lkml and git-packagers) > > On Tue, May 21, 2019 at 3:31 PM Duy Nguyen wrote: >> > The bug there is that the old opt_arg() code would be torelant to empty >> > values. I noticed a similar change the other day with the --abbrev >> > option, but

Re: [ANNOUNCE] Git v2.22.0-rc1

2019-05-21 Thread Duy Nguyen
(dropping lkml and git-packagers) On Tue, May 21, 2019 at 3:31 PM Duy Nguyen wrote: > > The bug there is that the old opt_arg() code would be torelant to empty > > values. I noticed a similar change the other day with the --abbrev > > option, but didn't think it was worth noting. Maybe it's a mor

Re: [ANNOUNCE] Git v2.22.0-rc1

2019-05-21 Thread Duy Nguyen
On Tue, May 21, 2019 at 5:27 AM Ævar Arnfjörð Bjarmason wrote: > > > On Mon, May 20 2019, Bryan Turner wrote: > > > On Sun, May 19, 2019 at 10:00 AM Junio C Hamano wrote: > >> > >> * The diff machinery, one of the oldest parts of the system, which > >>long predates the parse-options API, use

Re: [ANNOUNCE] Git v2.22.0-rc1

2019-05-20 Thread Ævar Arnfjörð Bjarmason
On Mon, May 20 2019, Bryan Turner wrote: > On Sun, May 19, 2019 at 10:00 AM Junio C Hamano wrote: >> >> * The diff machinery, one of the oldest parts of the system, which >>long predates the parse-options API, uses fairly long and complex >>handcrafted option parser. This is being rew

Re: [ANNOUNCE] Git v2.22.0-rc1

2019-05-20 Thread Bryan Turner
On Sun, May 19, 2019 at 10:00 AM Junio C Hamano wrote: > > * The diff machinery, one of the oldest parts of the system, which >long predates the parse-options API, uses fairly long and complex >handcrafted option parser. This is being rewritten to use the >parse-options API. It look

Re: [ANNOUNCE] Git v2.22.0-rc1

2019-05-19 Thread Johannes Schindelin
Team, Git for Windows v2.22.0-rc1 is available here: https://github.com/git-for-windows/git/releases/tag/v2.22.0-rc1.windows.1 Thanks, Johannes On Sun, 19 May 2019, Junio C Hamano wrote: > A release candidate Git v2.22.0-rc1 is now available for testing > at the usual places. It is c

[ANNOUNCE] Git v2.22.0-rc1

2019-05-19 Thread Junio C Hamano
A release candidate Git v2.22.0-rc1 is now available for testing at the usual places. It is comprised of 699 non-merge commits since v2.21.0, contributed by 66 people, 16 of which are new faces. The tarballs are found at: https://www.kernel.org/pub/software/scm/git/testing/ The following pu