Re: "fatal: git-write-tree: error building trees" from `git stash`

2012-12-27 Thread Junio C Hamano
Jeff King writes: > but I suspect it is not sufficient: > > 1. There are other code paths that will end up in write-tree which > should probably be protected, too. Among 6 calls to write-tree, only the first ones in create_stash and apply_stash are about the index the user originally had.

Re: "fatal: git-write-tree: error building trees" from `git stash`

2012-12-27 Thread Junio C Hamano
Alex Vandiver writes: > ... "Cannot stash while resolving conflicts" or similar would be > more understandable to the end user than the above. Interestingly enough, the "apply" side is protected with this one liner: # current index state c_tree=$(git write-tree) ||

Re: "fatal: git-write-tree: error building trees" from `git stash`

2012-12-27 Thread Jeff King
On Thu, Dec 27, 2012 at 01:55:56PM -0500, Alex Vandiver wrote: > On Thu, 2012-12-27 at 10:51 -0800, Junio C Hamano wrote: > > > $ git stash > > > foo: needs merge > > > foo: needs merge > > > foo: unmerged (aeaa7e5e87cf309a7368d5d92a71c1f9e6a8c9e7) > > > foo: unmerged (a77fa514de2720c72c1a861de098

Re: "fatal: git-write-tree: error building trees" from `git stash`

2012-12-27 Thread Alex Vandiver
On Thu, 2012-12-27 at 10:51 -0800, Junio C Hamano wrote: > > $ git stash > > foo: needs merge > > foo: needs merge > > foo: unmerged (aeaa7e5e87cf309a7368d5d92a71c1f9e6a8c9e7) > > foo: unmerged (a77fa514de2720c72c1a861de098595959a2c97a) > > foo: unmerged (4a622d2b991f1a19ba7be313a46dc6f03692cd0a) >

Re: "fatal: git-write-tree: error building trees" from `git stash`

2012-12-27 Thread Junio C Hamano
Alex Vandiver writes: > Heya, > I just ran into the following with `git stash`. The set-up: > ... > $ git stash pop > Auto-merging foo > CONFLICT (content): Merge conflict in foo > Recorded preimage for 'foo' > > $ git stash > foo: needs merge > foo: needs merge > foo: unmerged (aeaa7e5e87cf309a

"fatal: git-write-tree: error building trees" from `git stash`

2012-12-27 Thread Alex Vandiver
Heya, I just ran into the following with `git stash`. The set-up: git init echo "Initial" > foo git add . git commit -m 'Initial commit' echo "Rewrite" > foo git commit -am 'Second commit, rewrites content' echo "Stashed changes" >> foo