[PATCH 1/2] t5403: simplify by using a single repository

2018-12-29 Thread orgads
From: Orgad Shaneh There is no strong reason to use separate clones to run these tests; just use a single test repository prepared with more modern test_commit shell helper function. While at it, replace three "awk '{print $N}'" on the same file with shell built-in "read" into three variables.

[PATCH 2/2] Rebase: Run post-checkout hook on checkout

2018-12-29 Thread orgads
From: Orgad Shaneh The scripted version of rebase used to run this hook on the initial checkout. The transition to built-in introduced a regression. Signed-off-by: Orgad Shaneh --- builtin/rebase.c | 12 ++-- t/t5403-post-checkout-hook.sh | 20 2 files

[PATCH 1/2] t5403: Refactor

2018-12-24 Thread orgads
From: Orgad Shaneh * Replace multiple clones and commits by test_commits. * Replace 3 invocations of awk by read. Signed-off-by: Orgad Shaneh --- t/t5403-post-checkout-hook.sh | 80 +-- 1 file changed, 29 insertions(+), 51 deletions(-) diff --git a/t/t5403-post

[PATCH 2/2] Rebase: Run post-checkout hook on checkout

2018-12-24 Thread orgads
From: Orgad Shaneh Signed-off-by: Orgad Shaneh --- builtin/rebase.c | 11 +-- t/t5403-post-checkout-hook.sh | 20 2 files changed, 29 insertions(+), 2 deletions(-) diff --git a/builtin/rebase.c b/builtin/rebase.c index b5c99ec10c..7f7a2c738e 100644 ---

[PATCH] Rebase: Run post-checkout hook on checkout

2018-12-24 Thread orgads
From: Orgad Shaneh Signed-off-by: Orgad Shaneh --- builtin/rebase.c | 11 +-- t/t5403-post-checkout-hook.sh | 20 2 files changed, 29 insertions(+), 2 deletions(-) diff --git a/builtin/rebase.c b/builtin/rebase.c index b5c99ec10c..7f7a2c738e 100644 ---

[PATCH 2/2] Rebase: Run post-checkout hook on checkout

2018-12-20 Thread orgads
From: Orgad Shaneh Signed-off-by: Orgad Shaneh --- builtin/rebase.c | 8 +++- t/t5403-post-checkout-hook.sh | 18 ++ 2 files changed, 25 insertions(+), 1 deletion(-) diff --git a/builtin/rebase.c b/builtin/rebase.c index b5c99ec10c..78a09dcda2 100644 --- a/bui

[PATCH 1/2] t5403: Refactor

2018-12-20 Thread orgads
From: Orgad Shaneh * Replace multiple clones and commits by test_commits. * Replace 3 invocations of awk by read. Signed-off-by: Orgad Shaneh --- t/t5403-post-checkout-hook.sh | 55 --- 1 file changed, 18 insertions(+), 37 deletions(-) diff --git a/t/t5403-post

[PATCH 1/2] t5403: Refactor

2018-12-20 Thread orgads
From: Orgad Shaneh * Replace multiple clones and commits by test_commits. * Replace 3 invocations of awk by read. Signed-off-by: Orgad Shaneh --- t/t5403-post-checkout-hook.sh | 55 --- 1 file changed, 18 insertions(+), 37 deletions(-) diff --git a/t/t5403-post

[PATCH 2/2] Rebase: Run post-checkout hook on checkout

2018-12-20 Thread orgads
From: Orgad Shaneh Signed-off-by: Orgad Shaneh --- builtin/rebase.c | 8 +++- t/t5403-post-checkout-hook.sh | 18 ++ 2 files changed, 25 insertions(+), 1 deletion(-) diff --git a/builtin/rebase.c b/builtin/rebase.c index b5c99ec10c..78a09dcda2 100644 --- a/bui

[PATCH] doc: fix typos in release notes

2018-11-05 Thread orgads
From: Orgad Shaneh Signed-off-by: Orgad Shaneh --- Documentation/RelNotes/2.20.0.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/RelNotes/2.20.0.txt b/Documentation/RelNotes/2.20.0.txt index 4b546d025f..bc0f4e8237 100644 --- a/Documentation/RelNotes/2.

[PATCH] add a test for "describe --contains" with mixed tags

2017-10-24 Thread orgads
From: Orgad Shaneh If a repository has early lightweight tags and annotated tags later, running git describe --contains for an early commit used the annotated tag for reference, instead of the lightweight tag which was closer. This has been fixed in ef1e74065c19cc427c4a1b322154fd55d7a3588b, and

[PATCH] add a test for "describe --contains" with mixed tags

2017-10-19 Thread orgads
From: Orgad Shaneh --- t/t6120-describe.sh | 16 1 file changed, 16 insertions(+) diff --git a/t/t6120-describe.sh b/t/t6120-describe.sh index 1c0e865..08427f4 100755 --- a/t/t6120-describe.sh +++ b/t/t6120-describe.sh @@ -340,4 +340,20 @@ test_expect_success ULIMIT_STACK_SIZE

[PATCH] name-rev: Fix tag lookup on repository with mixed types of tags

2017-10-18 Thread orgads
From: Orgad Shaneh Commit 7550424804 (name-rev: include taggerdate in considering the best name) introduced a bug in name-rev. If a repository has both annotated and non-annotated tags, annotated tag will always win, even if it was created decades after the commit. Consider a repository that al

[PATCH] name-rev: Fix tag lookup on repository with mixed types of tags

2017-06-22 Thread orgads
From: Orgad Shaneh Commit 7550424804 (name-rev: include taggerdate in considering the best name) introduced a bug in name-rev. If a repository has both annotated and non-annotated tags, annotated tag will always win, even if it was created decades after the commit. Consider a repository that al

[PATCH v2] merge: Run commit-msg hook

2016-07-26 Thread orgads
From: Orgad Shaneh commit-msg is needed to either validate the commit message or edit it. Gerrit for instance uses this hook to append its Change-Id footer. The hook is installed on the user's machine, and it is expected to append the footer for each commit that the user creates. This is releva

[PATCH v2] commit: Fix description of no-verify

2016-07-26 Thread orgads
From: Orgad Shaneh include also commit-msg hook. This brings the short help in line with the documentation. Signed-off-by: Orgad Shaneh --- builtin/commit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builtin/commit.c b/builtin/commit.c index 163dbca..2725712 100644 --