Re: [PATCH v8] diff.c: keep arrow(=>) on show_stats()'s shortened filename part to make rename visible

2013-10-22 Thread Yoshioka Tsuneo
s_the_first}/path1 | 0 And, it might be a bit nicer for me if the patch can be rejected(or ignored as other patches) from the beginning if the concept does not fit anyway. # Though I know we can know more after seeing the implementation, anyway :-) # And, my original explanation

Re: [PATCH v8] diff.c: keep arrow(=>) on show_stats()'s shortened filename part to make rename visible

2013-10-19 Thread Yoshioka Tsuneo
ctory, the > latter is much more informative, I would think. On Oct 18, 2013, at 1:38 AM, Junio C Hamano wrote: > Yoshioka Tsuneo writes: > >> In the "[PATCH v7]", I changed to keep filename part of suffix to handle >> above case, but not always keep directory part be

[PATCH v8] diff.c: keep arrow(=>) on show_stats()'s shortened filename part to make rename visible

2013-10-18 Thread Yoshioka Tsuneo
"git diff -M --stat" can detect rename and show renamed file name like "foofoofoo => barbarbar". Before this commit, this output is shortened always by omitting left most part like "...foo => barbarbar". So, if the destination filename is too long, source filename putting left or arrow can be to

Re: [PATCH v6] diff.c: keep arrow(=>) on show_stats()'s shortened filename part to make rename visible.

2013-10-18 Thread Yoshioka Tsuneo
tor than '}'). I just sent the updated patch as "[PATCH v8]". Thanks ! --- Tsuneo Yoshioka (吉岡 恒夫) yoshiokatsu...@gmail.com On Oct 18, 2013, at 1:38 AM, Junio C Hamano wrote: > Yoshioka Tsuneo writes: > >> In the "[PATCH v7]", I changed to keep

Re: [PATCH v6] diff.c: keep arrow(=>) on show_stats()'s shortened filename part to make rename visible.

2013-10-17 Thread Yoshioka Tsuneo
may cause output like: …{… => …}…ongPath1/LongPath2/nameOfTheFileThatWasMoved And, above may be worse than: ...{...ceDirectory => …ionDirectory}.../nameOfTheFileThatWasMoved I think. Thank you ! --- Tsuneo Yoshioka (吉岡 恒夫) yoshiokatsu...@gmail.com On Oct 17, 2013, at 10:29 PM, Junio C

[PATCH v7] diff.c: keep arrow(=>) on show_stats()'s shortened filename part to make rename visible

2013-10-17 Thread Yoshioka Tsuneo
"git diff -M --stat" can detect rename and show renamed file name like "foofoofoo => barbarbar". Before this commit, this output is shortened always by omitting left most part like "...foo => barbarbar". So, if the destination filename is too long, source filename putting left or arrow can be tot

[PATCH v2] diffcore-rename.c: Estimate filename similarity for rename detection

2013-10-17 Thread Yoshioka Tsuneo
On rename detection like command "git diff -M ...", rename is detected based on file similarities. This file similarities are calculated based on the contents of file. And, if the similarities of contents are the same, filename is taken into account. But, the similarity of filename is calculated j

[PATCH] diffcore-rename.c: Estimate filename similarity for rename detection

2013-10-17 Thread Yoshioka Tsuneo
On rename detection like command "git diff -M ...", rename is detected based on file similarities. This file similarities are calculated based on the contents of file. And, if the similarities of contents are the same, filename is taken into account. But, the similarity of filename is calculated j

Re: [PATCH v5] diff.c: keep arrow(=>) on show_stats()'s shortened filename part to make rename visible.

2013-10-16 Thread Yoshioka Tsuneo
Hello Junio, Keshav Thank you very much for your detailed reviewing. I just tried to update the patch and posted as "[PATCH v6]". --- Tsuneo Yoshioka (吉岡 恒夫) yoshiokatsu...@gmail.com On Oct 16, 2013, at 1:54 AM, Junio C Hamano wrote: > Yoshioka Tsuneo writes: > >&g

[PATCH v6] diff.c: keep arrow(=>) on show_stats()'s shortened filename part to make rename visible.

2013-10-16 Thread Yoshioka Tsuneo
"git diff -M --stat" can detect rename and show renamed file name like "foofoofoo => barbarbar". Before this commit, this output is shortened always by omitting left most part like "...foo => barbarbar". So, if the destination filename is too long, source filename putting left or arrow can be tota

Re: [PATCH v4] diff.c: keep arrow(=>) on show_stats()'s shortened filename part to make rename visible.

2013-10-15 Thread Yoshioka Tsuneo
Hello Felipe Thank you for pointing out the style issue again. I just fixed it and posted as [PATCH v5]. Thanks! --- Tsuneo Yoshioka (吉岡 恒夫) yoshiokatsu...@gmail.com On Oct 15, 2013, at 1:07 PM, Felipe Contreras wrote: > On Tue, Oct 15, 2013 at 4:45 AM, Yoshioka Tsuneo >

[PATCH v5] diff.c: keep arrow(=>) on show_stats()'s shortened filename part to make rename visible.

2013-10-15 Thread Yoshioka Tsuneo
"git diff -M --stat" can detect rename and show renamed file name like "foofoofoo => barbarbar". But if destination filename is long, the line is shortened like "...barbarbar" so there is no way to know whether the file is renamed or existed in the source commit. Make sure there is always an arrow

Re: [PATCH v3] diff.c: keep arrow(=>) on show_stats()'s shortened filename part to make rename visible.

2013-10-15 Thread Yoshioka Tsuneo
com On Oct 13, 2013, at 11:29 PM, Thomas Rast wrote: > Hi, > > Yoshioka Tsuneo writes: > >> "git diff -M --stat" can detect rename and show renamed file name like >> "foofoofoo => barbarbar", but if destination filename is long the line >>

Re: [PATCH v3] diff.c: keep arrow(=>) on show_stats()'s shortened filename part to make rename visible.

2013-10-15 Thread Yoshioka Tsuneo
, at 10:04 PM, Duy Nguyen wrote: > On Sun, Oct 13, 2013 at 3:48 AM, Yoshioka Tsuneo > wrote: >> "git diff -M --stat" can detect rename and show renamed file name like >> "foofoofoo => barbarbar", but if destination filename is long the line >> is

[PATCH v4] diff.c: keep arrow(=>) on show_stats()'s shortened filename part to make rename visible.

2013-10-15 Thread Yoshioka Tsuneo
"git diff -M --stat" can detect rename and show renamed file name like "foofoofoo => barbarbar". But if destination filename is long, the line is shortened like "...barbarbar" so there is no way to know whether the file is renamed or existed in the source commit. Make sure there is always an arrow

Re: [spf:guess,mismatch] [PATCH v2] diff.c: keep arrow(=>) on show_stats()'s shortened filename part to make rename visible.

2013-10-12 Thread Yoshioka Tsuneo
Hello On Oct 12, 2013, at 8:35 AM, Keshav Kini wrote: > Sam Vilain writes: > >> On 10/11/2013 06:07 AM, Yoshioka Tsuneo wrote: >>> + prefix_len = ((prefix_len >= 0) ? prefix_len : >>> 0); >>> +

[PATCH v3] diff.c: keep arrow(=>) on show_stats()'s shortened filename part to make rename visible.

2013-10-12 Thread Yoshioka Tsuneo
"git diff -M --stat" can detect rename and show renamed file name like "foofoofoo => barbarbar", but if destination filename is long the line is shortened like "...barbarbar" so there is no way to know whether the file is renamed or existed in the source commit. This commit makes it visible like ".

[PATCH v3] diff.c: keep arrow(=>) on show_stats()'s shortened filename part to make rename visible.

2013-10-12 Thread Yoshioka Tsuneo
"git diff -M --stat" can detect rename and show renamed file name like "foofoofoo => barbarbar", but if destination filename is long the line is shortened like "...barbarbar" so there is no way to know whether the file is renamed or existed in the source commit. This commit makes it visible like ".

[PATCH v2] diff.c: keep arrow(=>) on show_stats()'s shortened filename part to make rename visible.

2013-10-11 Thread Yoshioka Tsuneo
"git diff -M --stat" can detect rename and show renamed file name like "foofoofoo => barbarbar", but if destination filename is long the line is shortened like "...barbarbar" so there is no way to know whether the file is renamed or existed in the source commit. This commit makes it visible like ".

[PATCH] diff.c: keep arrow(=>) on show_stats()'s shortened filename part to make rename visible.

2013-10-11 Thread Yoshioka Tsuneo
"git diff -M --stat" can detect rename and show renamed file name like "foofoofoo => barbarbar", but if destination filename is long the line is shortened like "...barbarbar" so there is no way to know whether the file is renamed or existed in the source commit. This commit makes it visible like ".

[PATCH] diffcore-delta: optimize renames and copies detection (git diff -M/-C)

2013-10-09 Thread Yoshioka Tsuneo
diffcore_count_changes() can return -1 when src_copied is greater than delta_limit, without counting all the src_copied. By that, performance of "diff -M/-C" can be improved. Signed-off-by: Tsuneo Yoshioka --- diffcore-delta.c | 11 --- diffcore-rename.c | 2 +- 2 files changed, 9 inse