On Wed, Feb 13, 2019 at 02:37:48PM -0800, Junio C Hamano wrote:
> William Hubbs writes:
>
> > I am writing back onn this thread because I'm not quite sure of the
> > status. v5 of the patch seemed ok, but there were some changes discussed
> > that would have create
Hi Junio,
I am writing back onn this thread because I'm not quite sure of the
status. v5 of the patch seemed ok, but there were some changes discussed
that would have created a v6. The v6 changes though were never really
clear. I'm not sure whether I am supposed to be doing something more or
wheth
On Wed, Feb 06, 2019 at 01:26:12PM -0500, Jeff King wrote:
> On Wed, Feb 06, 2019 at 10:28:34AM +0100, Ævar Arnfjörð Bjarmason wrote:
>
> > I did some further digging. One of the confusing things is that we've
> > been carrying dead code since 2012 to set this
> > author_ident_explicitly_given var
On Wed, Feb 06, 2019 at 10:28:34AM +0100, Ævar Arnfjörð Bjarmason wrote:
>
> William, is that something you're intererested in carrying forward? I
> can also help if you want. Sorry your first contribution to git has
> turned into this mess of re-rolls, as often happens we find that when
> trying
On Tue, Feb 05, 2019 at 06:15:58PM -0600, William Hubbs wrote:
> On Tue, Feb 05, 2019 at 06:04:13PM -0600, William Hubbs wrote:
> > On Tue, Feb 05, 2019 at 10:14:37PM +0100, Ævar Arnfjörð Bjarmason wrote:
> > >
> > > On Tue, Feb 05 2019, Junio C Hamano wrote:
&
On Tue, Feb 05, 2019 at 06:04:13PM -0600, William Hubbs wrote:
> On Tue, Feb 05, 2019 at 10:14:37PM +0100, Ævar Arnfjörð Bjarmason wrote:
> >
> > On Tue, Feb 05 2019, Junio C Hamano wrote:
> >
> > > Ævar Arnfjörð Bjarmason writes:
> > >
> > >
On Tue, Feb 05, 2019 at 10:14:37PM +0100, Ævar Arnfjörð Bjarmason wrote:
>
> On Tue, Feb 05 2019, Junio C Hamano wrote:
>
> > Ævar Arnfjörð Bjarmason writes:
> >
> >> +static int set_ident_internal(const char *var, const char *value,
> >> + struct strbuf *sb, const int flag
committer.name settings so this information
can be set per repository.
Also, it generalizes the fmt_ident function so it can handle author vs
committer identification.
Signed-off-by: William Hubbs
---
Documentation/config/user.txt | 23 ++---
blame.c | 3 +-
builtin
*** BLURB HERE ***
This update adds back the reference to the EMAIL environment variable.
William Hubbs (1):
config: allow giving separate author and committer idents
Documentation/config/user.txt | 23 ++---
blame.c | 3 +-
builtin/am.c | 1
All,
this implements the changes requested in v3 of this patch:
- removes an extra comma from the enum
- reworks the logic for config handling so that the author and committer
variables are handled along with the user variables.
Please review.
William Hubbs (1):
config: allow giving
committer.name settings so this information
can be set per repository.
Also, it generalizes the fmt_ident function so it can handle author vs
committer identification.
Signed-off-by: William Hubbs
---
Documentation/config/user.txt | 23 ++---
blame.c | 3 +-
builtin
All,
this version of the patch adds more test cases, combines the tests into
the main patch, creates the static set_ident function, updates the
documentation and fixes some formatting.
It also applies against master.
Please review.
William Hubbs (1):
config: allow giving separate author and
committer.name settings so this information
can be set per repository.
Also, it generalizes the fmt_ident function so it can handle author vs
committer identification.
Signed-off-by: William Hubbs
---
Documentation/config/user.txt | 23 ++---
blame.c | 3 +-
builtin
On Fri, Jan 25, 2019 at 11:58:10PM +0100, Ævar Arnfjörð Bjarmason wrote:
>
> On Fri, Jan 25 2019, William Hubbs wrote:
>
> > @@ -480,6 +515,46 @@ int git_ident_config(const char *var, const char
> > *value, void *data)
> > return 0;
> >
On Mon, Jan 28, 2019 at 09:04:15PM +0100, Ævar Arnfjörð Bjarmason wrote:
>
> Adjusting for limited time, I'm happy to help out with this series,
> particularly if you have visual (screen reader) issues that make some of
> this prohibitive for you. Just say what you need.
I guess the best way to h
On Fri, Jan 25, 2019 at 11:58:10PM +0100, Ævar Arnfjörð Bjarmason wrote:
>
> On Fri, Jan 25 2019, William Hubbs wrote:
>
> > diff --git a/Documentation/config/user.txt b/Documentation/config/user.txt
> > index b5b2ba1199..18e1ec3c1b 100644
> > --- a/Documentatio
On Sat, Jan 26, 2019 at 12:05:08AM +0100, Ævar Arnfjörð Bjarmason wrote:
>
> On Fri, Jan 25 2019, William Hubbs wrote:
...
> > + sane_unset GIT_AUTHOR_NAME GIT_AUTHOR_EMAIL &&
> > + sane_unset GIT_COMMITTER_NAME GIT_COMMITTER_EMAIL &&
>
> Fine, but
committer.name settings so this information
can be set per repository.
Also, it generalizes the fmt_ident function so it can handle author vs
committer identification.
Signed-off-by: William Hubbs
---
Documentation/config/user.txt | 31 +-
blame.c | 3
All,
this is a re-roll of my previous patch to add separate author and
committer settings.:s/committer/committer configuration/
A
I attempted to encorporate everything from the last iteration, and all
tests still pass.
This applies to master. Please review.
[PATCH v2 1/2] config: allow giving s
Signed-off-by: William Hubbs
---
t/t7517-per-repo-email.sh | 17 +
1 file changed, 17 insertions(+)
diff --git a/t/t7517-per-repo-email.sh b/t/t7517-per-repo-email.sh
index 231b8cc19d..06c7c0fb78 100755
--- a/t/t7517-per-repo-email.sh
+++ b/t/t7517-per-repo-email.sh
@@ -85,4
The author.email, author.name, committer.email and committer.name
settings are analogous to the GIT_AUTHOR_* and GIT_COMMITTER_*
environment variables, but for the git config system. This allows them
to be set separately for each repository.
Signed-off-by: William Hubbs
reviews, and I would like to publically thank dscho
from #git-devel for assisting me in preparing this patch.
Also, since I use a screen reader, it would be very helpful if you put
your comments in your replies as close to the affected code as possible,
preferably directly below it.
William Hubbs
Hi Jonathan,
On Fri, Dec 07, 2018 at 02:44:28PM -0800, Jonathan Nieder wrote:
> William Hubbs wrote:
> > On Thu, Dec 06, 2018 at 11:20:07PM +0100, Johannes Schindelin wrote:
>
> >> There *is* a way to get what you want that is super easy and will
> >> definitely w
Hi Johannes,
On Thu, Dec 06, 2018 at 11:20:07PM +0100, Johannes Schindelin wrote:
> Hi William,
>
>[...]
>
> There *is* a way to get what you want that is super easy and will
> definitely work: if you sit down and do it ;-)
>
> Please let us know if you need any additional information before yo
On Thu, Dec 06, 2018 at 07:38:08PM +0100, Martin Ågren wrote:
> Hi William,
>
> [...]
>
> This idea was floated a couple of months ago [1]. Junio seemed to find
> the request sensible and outlined a design. No patches materialized, as
> far as I know, but that could be because Eric suggested a to
Hi all,
We are in a situation where we would like to use author information that is
different from committer information when we commit to certain
repositories.
Currently, it looks like there are two ways to do this, and I'm not sure
how to make either of them work well.
There are the GIT_AUTHOR
26 matches
Mail list logo
