[PATCH v4 5/6] midx: honor the MIDX_PROGRESS flag in midx_repack

From: William Baker Update midx_repack to only display progress when the MIDX_PROGRESS flag is set. Signed-off-by: William Baker --- midx.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/midx.c b/midx.c index 35bdc5f72c..b5f7f1c54a 100644 --- a/midx.c +++ b/midx.c @@ -1373,6 +1373,1

[PATCH v4 3/6] midx: add progress to expire_midx_packs

From: William Baker Add progress to expire_midx_packs. Progress is displayed when the MIDX_PROGRESS flag is set. Signed-off-by: William Baker --- midx.c | 12 1 file changed, 12 insertions(+) diff --git a/midx.c b/midx.c index 006f36b570..7157259ca2 100644 --- a/midx.c +++ b/mid

[PATCH v4 2/6] midx: add progress to write_midx_file

From: William Baker Add progress to write_midx_file. Progress is displayed when the MIDX_PROGRESS flag is set. Signed-off-by: William Baker --- midx.c | 25 + 1 file changed, 21 insertions(+), 4 deletions(-) diff --git a/midx.c b/midx.c index f169a681dd..006f36b570 10

[PATCH v4 4/6] midx: honor the MIDX_PROGRESS flag in verify_midx_file

From: William Baker Update verify_midx_file to only display progress when the MIDX_PROGRESS flag is set. Signed-off-by: William Baker --- midx.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/midx.c b/midx.c index 7157259ca2..35bdc5f72c 100644 --- a/m

[PATCH v4 6/6] multi-pack-index: add [--[no-]progress] option.

From: William Baker Add the --[no-]progress option to git multi-pack-index. Pass the MIDX_PROGRESS flag to the subcommand functions when progress should be displayed by multi-pack-index. The progress feature was added to 'verify' in 144d703 ("multi-pack-index: report progress during 'verify'", 20

[PATCH v4 1/6] midx: add MIDX_PROGRESS flag

From: William Baker Add the MIDX_PROGRESS flag and update the write|verify|expire|repack functions in midx.h to accept a flags parameter. The MIDX_PROGRESS flag indicates whether the caller of the function would like progress information to be displayed. This patch only changes the method protot

[PATCH v4 0/6] multi-pack-index: add --no-progress

Hello Git contributors, This is the fourth iteration of changes for adding support for --[no-]progress to multi-pack-index. I'm resubmitting the series after a discussion regarding 'MIDX_PROGRESS' that concluded with a decision to stick with the original changes in the v3 patch. Thanks, William

[PATCH 1/1] t7519-status-fsmonitor: improve comments

From: William Baker The comments for the staging/unstaging test did not accurately describe the scenario being tested. It is not essential that the test files being staged/unstaged appear at the end of the index. All that is required is that the test files are not flagged with CE_FSMONITOR_VALI

[PATCH 0/1] t7519-status-fsmonitor: improve comments

This patch series is based on the 'wb/fsmonitor-bitmap-fix' branch and addresses feedback on the new test that was added there. I've updated the comments for the new test to more accurately describe the scenario being tested. Thanks, William William Baker (1): t7519-status-fsmonitor: improve

[PATCH v3 0/1] fsmonitor: don't fill bitmap with entries to be removed

This is the third iteration of changes to fix the segfault that I encountered while testing fsmonitor. This iteration includes the following updates for feedback I received on v2: * Update the new test case to use its own dedicated test repository This latest v3 series has been reviewed by Dscho

[PATCH v3 1/1] fsmonitor: don't fill bitmap with entries to be removed

From: William Baker While doing some testing with fsmonitor enabled I found that git commands would segfault after staging and unstaging an untracked file. Looking at the crash it appeared that fsmonitor_ewah_callback was attempting to adjust bits beyond the bounds of the index cache. Digging i

[PATCH v2 0/1] fsmonitor: don't fill bitmap with entries to be removed

This is the second iteration of changes to fix the segfault that I encountered while testing fsmonitor. This iteration includes the following updates for feedback I received on v1: * Use %u instead of %"PRIuMAX" for unsigned ints in BUG format strings * Updated the new test's comment to be more

[PATCH v2 1/1] fsmonitor: don't fill bitmap with entries to be removed

From: William Baker While doing some testing with fsmonitor enabled I found that git commands would segfault after staging and unstaging an untracked file. Looking at the crash it appeared that fsmonitor_ewah_callback was attempting to adjust bits beyond the bounds of the index cache. Digging i

[PATCH 1/1] fsmonitor: don't fill bitmap with entries to be removed

From: William Baker While doing some testing with fsmonitor enabled I found that git commands would segfault after staging and unstaging an untracked file. Looking at the crash it appeared that fsmonitor_ewah_callback was attempting to adjust bits beyond the bounds of the index cache. Digging i

[PATCH 0/1] fsmonitor: don't fill bitmap with entries to be removed

This patch series fixes a segfault that I encountered while testing fsmonitor. Under some circumstances, the fsmonitor extension was being written with too many bits, and subsequent git commands would segfault when trying to apply the bits to the index. As part of these changes I've added some BUG

[PATCH v3 2/6] midx: add progress to write_midx_file

From: William Baker Add progress to write_midx_file. Progress is displayed when the MIDX_PROGRESS flag is set. Signed-off-by: William Baker --- midx.c | 25 + 1 file changed, 21 insertions(+), 4 deletions(-) diff --git a/midx.c b/midx.c index b2673f52e8..0808a40dd4 10

[PATCH v3 5/6] midx: honor the MIDX_PROGRESS flag in midx_repack

From: William Baker Update midx_repack to only display progress when the MIDX_PROGRESS flag is set. Signed-off-by: William Baker --- midx.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/midx.c b/midx.c index ced5898bbf..1c5ddeb007 100644 --- a/midx.c +++ b/midx.c @@ -1374,6 +1374,1

[PATCH v3 6/6] multi-pack-index: add [--[no-]progress] option.

From: William Baker Add the --[no-]progress option to git multi-pack-index. Pass the MIDX_PROGRESS flag to the subcommand functions when progress should be displayed by multi-pack-index. The progress feature was added to 'verify' in 144d703 ("multi-pack-index: report progress during 'verify'", 20

[PATCH v3 1/6] midx: add MIDX_PROGRESS flag

From: William Baker Add the MIDX_PROGRESS flag and update the write|verify|expire|repack functions in midx.h to accept a flags parameter. The MIDX_PROGRESS flag indicates whether the caller of the function would like progress information to be displayed. This patch only changes the method protot

[PATCH v3 4/6] midx: honor the MIDX_PROGRESS flag in verify_midx_file

From: William Baker Update verify_midx_file to only display progress when the MIDX_PROGRESS flag is set. Signed-off-by: William Baker --- midx.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/midx.c b/midx.c index f14bebb092..ced5898bbf 100644 --- a/m

[PATCH v3 3/6] midx: add progress to expire_midx_packs

From: William Baker Add progress to expire_midx_packs. Progress is displayed when the MIDX_PROGRESS flag is set. Signed-off-by: William Baker --- midx.c | 12 1 file changed, 12 insertions(+) diff --git a/midx.c b/midx.c index 0808a40dd4..f14bebb092 100644 --- a/midx.c +++ b/mid

[PATCH v3 0/6] multi-pack-index: add --no-progress

Hello Git contributors, This is the third iteration of changes for adding support for --[no-]progress to multi-pack-index, and it includes the following updates for the feedback I received on v2: * Fixed commit message formatting * Updated 'pack_paths_checked' from u32 to unsigned Thanks, Will

[PATCH v2 3/6] midx: add progress to expire_midx_packs Add progress to expire_midx_packs. Progress is displayed when the MIDX_PROGRESS flag is set.

From: William Baker Signed-off-by: William Baker --- midx.c | 12 1 file changed, 12 insertions(+) diff --git a/midx.c b/midx.c index 54e4e93b2b..3a0e161aea 100644 --- a/midx.c +++ b/midx.c @@ -1206,18 +1206,29 @@ int expire_midx_packs(struct repository *r, const char *object_dir

[PATCH v2 6/6] multi-pack-index: add [--[no-]progress] option. Add the --[no-]progress option to git multi-pack-index. Pass the MIDX_PROGRESS flag to the subcommand functions when progress should be d

From: William Baker Signed-off-by: William Baker --- Documentation/git-multi-pack-index.txt | 6 ++- builtin/multi-pack-index.c | 18 +-- t/t5319-multi-pack-index.sh| 69 ++ 3 files changed, 87 insertions(+), 6 deletions(-) diff --git a/Docu

[PATCH v2 2/6] midx: add progress to write_midx_file Add progress to write_midx_file. Progress is displayed when the MIDX_PROGRESS flag is set.

From: William Baker Signed-off-by: William Baker --- midx.c | 25 + 1 file changed, 21 insertions(+), 4 deletions(-) diff --git a/midx.c b/midx.c index b2673f52e8..54e4e93b2b 100644 --- a/midx.c +++ b/midx.c @@ -449,6 +449,8 @@ struct pack_list { uint32_t nr;

[PATCH v2 4/6] midx: honor the MIDX_PROGRESS flag in verify_midx_file Update verify_midx_file to only display progress when the MIDX_PROGRESS flag is set.

From: William Baker Signed-off-by: William Baker --- midx.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/midx.c b/midx.c index 3a0e161aea..dc7c5f43f8 100644 --- a/midx.c +++ b/midx.c @@ -1098,15 +1098,16 @@ int verify_midx_file(struct repository *r,

[PATCH v2 0/6] multi-pack-index: add --no-progress

Hello Git contributors! My name is William Baker and I work at Microsoft. Over the past few years I've worked closely with the Microsoft team contributing to the git ecosystem and I'm excited to start working with the community. Derrick Stolee helped me pick out my first task, and it's to add sup

[PATCH v2 5/6] midx: honor the MIDX_PROGRESS flag in midx_repack Update midx_repack to only display progress when the MIDX_PROGRESS flag is set.

From: William Baker Signed-off-by: William Baker --- midx.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/midx.c b/midx.c index dc7c5f43f8..106ccc4ab2 100644 --- a/midx.c +++ b/midx.c @@ -1374,6 +1374,12 @@ int midx_repack(struct repository *r, const char *object_dir, size_t batch_

[PATCH v2 1/6] midx: add MIDX_PROGRESS flag Add the MIDX_PROGRESS flag and update the write|verify|expire|repack functions in midx.h to accept a flags parameter. The MIDX_PROGRESS flag indicates whet

From: William Baker Signed-off-by: William Baker --- builtin/multi-pack-index.c | 8 builtin/repack.c | 2 +- midx.c | 8 midx.h | 10 ++ 4 files changed, 15 insertions(+), 13 deletions(-) diff --git a/builtin/multi

[PATCH 0/1] multi-pack-index: add --no-progress

Hello Git contributors! My name is William Baker and I work at Microsoft. Over the past few years I've worked closely with the Microsoft team contributing to the git ecosystem and I'm excited to start working with the community. Derrick Stolee helped me pick out my first task, and it's to add sup

[PATCH 1/1] multi-pack-index: add --no-progress Add --no-progress option to git multi-pack-index. The progress feature was added in 144d703 ("multi-pack-index: report progress during 'verify'", 2018-0

From: William Baker Signed-off-by: William Baker --- Documentation/git-multi-pack-index.txt | 6 +- builtin/multi-pack-index.c | 14 +--- midx.c | 30 +- midx.h | 6 -- t/t5319-