Re: [GSoC] Discussion of "Submodule related work" project

2017-03-15 Thread Valery Tolstov
about this. Thanks, Valery Tolstov

Re: [GSoC] Discussion of "Submodule related work" project

2017-03-10 Thread Valery Tolstov
; That is a nice project, though my gut feeling is that it is too small > for a GSoC project on itself. Does it sound good? If does, then I'll begin to work on my proposal. Thanks, Valery Tolstov

Re: [GSoC] Discussion of "Submodule related work" project

2017-03-10 Thread Valery Tolstov
r response you talk about them as independent projects... This means I can take only any one of them as starting point for my proposal? Or maybe I misunderstood you? Thanks, Valery Tolstov

[GSoC] Discussion of "Submodule related work" project

2017-03-10 Thread Valery Tolstov
l example that shows the problem, please? And why advanced datastructure knowledge is expected? Maybe you have something else about this project to say. Thanks, Valery Tolstov

Re: [PATCH v3 2/2] submodule--helper.c: remove duplicate code

2017-03-09 Thread Valery Tolstov
As remainder. It is better if only [PATCH v3 2/2] is taken, on top the patch from here https://public-inbox.org/git/20170309221543.15897-8-sbel...@google.com/ The [PATCH v3 1/2] is just a copy of latter.

[GSoC] Git patch flow

2017-03-09 Thread Valery Tolstov
to do what is in p.4 said exactly, right? Asking this question because can't find good examples in mailing list archive. Thanks, Valery Tolstov

Re: [PATCH] submodule--helper.c: remove duplicate code

2017-03-08 Thread Valery Tolstov
afely create leading directories," > first and then your deduplication patch. Is there a handy way to forward your patch in new patch series? Also, should I start new thread for new patch series? Regards, Valery Tolstov

[PATCH v3 0/2] Remove duplicate code from module_clone()

2017-03-08 Thread Valery Tolstov
Stefan Beller (1): connect_work_tree_and_git_dir: safely create leading directories Valery Tolstov (1): submodule--helper.c: remove duplicate code builtin/submodule--helper.c | 22 ++ dir.c | 32 +--- submodule.c

[PATCH v3 2/2] submodule--helper.c: remove duplicate code

2017-03-08 Thread Valery Tolstov
Remove code fragment from module_clone that duplicates functionality of connect_work_tree_and_git_dir in dir.c Signed-off-by: Valery Tolstov --- builtin/submodule--helper.c | 22 ++ 1 file changed, 2 insertions(+), 20 deletions(-) diff --git a/builtin/submodule--helper.c b

[PATCH v3 1/2] connect_work_tree_and_git_dir: safely create leading directories

2017-03-08 Thread Valery Tolstov
From: Stefan Beller In a later patch we'll use connect_work_tree_and_git_dir when the directory for the gitlink file doesn't exist yet. This patch makes connect_work_tree_and_git_dir safe to use for both cases of either the git dir or the working dir missing. To do so, we need to call safe_creat

Re: Re: [PATCH v2 0/2] Remove duplicate code from module_clone()

2017-03-08 Thread Valery Tolstov
albe? Regards, Valery Tolstov

[PATCH v2 0/2] Remove duplicate code from module_clone()

2017-03-08 Thread Valery Tolstov
afely create leading directories," > first and then your deduplication patch. Combined two patches Stefan Beller (1): connect_work_tree_and_git_dir: safely create leading directories Valery Tolstov (1): submodule--helper.c: remove duplicate code builtin/submodule--helper.c | 20

[PATCH v2 1/2] connect_work_tree_and_git_dir: safely create leading directories

2017-03-08 Thread Valery Tolstov
From: Stefan Beller In a later patch we'll use connect_work_tree_and_git_dir when the directory for the gitlink file doesn't exist yet. This patch makes connect_work_tree_and_git_dir safe to use for both cases of either the git dir or the working dir missing. To do so, we need to call safe_creat

[PATCH v2 2/2] submodule--helper.c: remove duplicate code

2017-03-08 Thread Valery Tolstov
Remove code fragment from module_clone that duplicates functionality of connect_work_tree_and_git_dir in dir.c Signed-off-by: Valery Tolstov --- builtin/submodule--helper.c | 20 ++-- 1 file changed, 2 insertions(+), 18 deletions(-) diff --git a/builtin/submodule--helper.c b

Re: [PATCH] submodule--helper.c: remove duplicate code

2017-03-08 Thread Valery Tolstov
Thank you for your detailed responses. Yes, we difenitely need this patch first. All tests passed when I applied it. Regards, Valery Tolstov

Re: GSoC 2017

2017-03-07 Thread Valery Tolstov
the flag indicating that path is submodule or not. But I think this solution is bad. Regards, Valery Tolstov

Re: git init --separate-git-dir does not update symbolic .git links for submodules

2017-03-07 Thread Valery Tolstov
Just noticed that there already is function that gives module list module_list_compute. But purpose of it's arguments is not quite clear for me at this moment.

Re: git init --separate-git-dir does not update symbolic .git links for submodules

2017-03-07 Thread Valery Tolstov
it command using submodule--helper, with subcommand that fixes all submodules on current level 2. Each submodule processed with another subcommand/function in submodule--helper individually 3. Repeat for current submodule recursively Glad to see your advices. Regards, Valery Tolstov

Re: git init --separate-git-dir does not update symbolic .git links for submodules

2017-03-04 Thread Valery Tolstov
Looking for microproject ideas for GSoC. Would this issue be suitable as the microproject? Thanks, Valery Tolstov

GSoC 2017

2017-03-04 Thread Valery Tolstov
Hi. Want to participate in GSoC 2017 with Git. Can I choose "Make 'git tag --contains ' less chatty" as my microproject? Thanks.