On Sat, Jun 6, 2015 at 12:03 AM, Junio C Hamano wrote:
> Tay Ray Chuan writes:
>
>> Would it be a good idea to have a --diff-only option to include diff,
>> but not status output? Or perhaps a --diff option, while leaving it to
>> the user to specify if status outpu
Hi Junio,
On Fri, Jun 5, 2015 at 2:39 AM, Junio C Hamano wrote:
>
> Tay Ray Chuan writes:
>
> > When running git-commit`, --verbose appends a diff to the prepared
> > message, while --no-status omits git-status output.
>
> The --verbose option is called --verbose and
When running git-commit`, --verbose appends a diff to the prepared
message, while --no-status omits git-status output; thus, one would
expect --verbose --no-status to give a commit message with a diff of
the commit without git-status output.
However, this is not what happens - the prepared commit
, which triggers
the setting of the commitable flag, and the printing of the diff. This
is set only by git-commit, and when it detects that --verbose and
--no-status have been used.
Signed-off-by: Tay Ray Chuan
---
Changed since v1: adopted peff's suggestion in
20140224083312
It may not be obvious from its name that wt_status_print_updated() that
it also sets wt_status.commitable, which affects commit functionality.
Extract this out into a separate function for improved clarity, though
at the expense of executing another loop.
Signed-off-by: Tay Ray Chuan
Hi Rupert,
On Mon, Apr 13, 2015 at 1:51 AM, Johannes Schindelin
wrote:
> On 2015-04-11 10:37, rupert thurner wrote:
> > * the prompt is still as slow as before, calculating the branch name on
> > pressing return without option to turn it off
>
> There is no explicit option in the installer to tur
On Sat, Oct 11, 2014 at 11:51 PM, Mark Levedahl wrote:
>
> $git checkout was taking about 3.5 seconds to respond on one
> repository having four remotes with about 100 total refs (measured on
> Cygwin). All of the time was being claimed in "git for-each-ref" to do
> its work. This working direc
On Sat, Mar 1, 2014 at 10:58 AM, Duy Nguyen wrote:
> On Sat, Mar 1, 2014 at 8:07 AM, Sun He wrote:
>> Signed-off-by: Sun He
>> ---
>> Find the potential places with memcpy by the bash command:
>>$ find . | xargs grep "memcpy.*\(.*20.*\)"
>>
>> Helped-by: Michael Haggerty
>
> You may want t
On Wed, Feb 26, 2014 at 6:52 PM, Jeff King wrote:
> I'd worry a little that it is not a summer's worth of work, but I
> suspect there are other parts of rebase--interactive that could use
> attention once the student is familiar with the code.
It might be worthwhile to check for prior projects th
On Sat, Feb 22, 2014 at 4:31 PM, Jeff King wrote:
> On Sat, Feb 22, 2014 at 03:09:22AM +0800, Tay Ray Chuan wrote:
>
>> @@ -1141,7 +1146,12 @@ static int parse_and_validate_options(int argc, const
>> char *argv[],
>> if (all && argc > 0)
>>
matter of calling wt_status_mark_commitable().
[1] http://article.gmane.org/gmane.comp.version-control.git/242489
Signed-off-by: Tay Ray Chuan
---
t/t7501-commit.sh | 36
1 file changed, 36 insertions(+)
diff --git a/t/t7501-commit.sh b/t/t7501-commit.sh
index
--verbose, and ii) --no-status.
Signed-off-by: Tay Ray Chuan
---
builtin/commit.c | 14 +-
wt-status.c | 2 +-
wt-status.h | 3 +++
3 files changed, 17 insertions(+), 2 deletions(-)
diff --git a/builtin/commit.c b/builtin/commit.c
index 2e86b76..fca6a6b 100644
--- a/builti
One would expect 'git commit --verbose --no-status' to give a commit
message with a diff of the commit, sans the output of git-status.
However, this does not work currently; the commit message body is
entirely empty (diff is absent as well). This patch series attempts to
make this work, as one woul
contributors would outweigh the performance penalty.
Signed-off-by: Tay Ray Chuan
---
wt-status.c | 17 -
1 file changed, 16 insertions(+), 1 deletion(-)
diff --git a/wt-status.c b/wt-status.c
index a452407..9b0189c 100644
--- a/wt-status.c
+++ b/wt-status.c
@@ -589,6 +589,21 @@ void
Cc: Jeff King
In f3f47a1 (status: add --long output format option), STATUS_FORMAT_NONE
was introduced, meaning "the user did not specify anything". Rename this
to *_DEFAULT to better indicate its meaning.
This paves the way for _NONE to really mean "no status".
Signed-o
Posting to msysgit since this was on Windows.
--
Cheers,
Ray Chuan
On Mon, Feb 17, 2014 at 3:45 PM, youngseonkim <1.youngsun@gmail.com> wrote:
> Hi, I really wonder about this happen.
> I want svn→git migrate, and I use this command.
>
> git svn clone https://my.svn.repo/url --stdlayout
>
>
We were leaking memory in there, as after obtaining a string from
git_getpass, we returned a copy of it, yet no one else held the original
string, apart from credential_ask_one.
Signed-off-by: Tay Ray Chuan
---
credential.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
On Thu, Nov 28, 2013 at 4:14 PM, Duy Nguyen wrote:
> On Thu, Nov 28, 2013 at 2:41 PM, zhifeng hu wrote:
>> Thanks for reply, But I am developer, I want to clone full repository, I
>> need to view code since very early.
>
> if it works with --depth =1, you can incrementally run "fetch
> --depth=N
On Wed, Oct 9, 2013 at 11:57 AM, Paolo G. Giarrusso
wrote:
> diff --git a/contrib/subtree/git-subtree.sh b/contrib/subtree/git-subtree.sh
> index 7d7af03..ebfb78f 100755
> --- a/contrib/subtree/git-subtree.sh
> +++ b/contrib/subtree/git-subtree.sh
> @@ -592,7 +592,9 @@ cmd_split()
> eval "
On Fri, Oct 4, 2013 at 1:50 AM, Stefan Pochmann
wrote:
> 4) When I found this email address and sent a mail with items 1)-3), I
> got a rejection reply saying " The message contains HTML subpart".
> Very annoying. I'm trying to help here by pointing out problems, and
> you're making it really inco
Hi Karsten,
On Tue, Sep 24, 2013 at 5:50 PM, Karsten Blees wrote:
>
> | add| get 100% hits |get 10% hits
> | hash | hashmap | hash | hashmap | hash | hashmap
> ++-+---+-+-+
> FNV | 14.815 | 2.345 |
On Tue, Sep 17, 2013 at 1:06 AM, Jens Lehmann wrote:
Thanks Jens for having a look!
> Am 15.09.2013 19:38, schrieb Tay Ray Chuan:
>> When 'update' is run with no path in a repository with uninitialized
>> submodules, the program terminates with no output, and zer
322bb6e (2011 Aug 11) introduced a new subshell at the end of a test
case but omitted a '&&' to join the two; fix this.
Signed-off-by: Tay Ray Chuan
---
t/t7406-submodule-update.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t7406-submodule-u
Signed-off-by: Tay Ray Chuan
---
t/t7406-submodule-update.sh | 20
1 file changed, 20 insertions(+)
diff --git a/t/t7406-submodule-update.sh b/t/t7406-submodule-update.sh
index f0b3305..00475eb 100755
--- a/t/t7406-submodule-update.sh
+++ b/t/t7406-submodule-update.sh
When 'update' is run with no path in a repository with uninitialized
submodules, the program terminates with no output, and zero status code.
Be more helpful to users by mentioning this.
This may be controlled by an advice.* option.
Signed-off-by: Tay Ray Chuan
---
Documentation/
From: "Shawn O. Pearce"
Signed-off-by: Shawn O. Pearce
Signed-off-by: Tay Ray Chuan
--
This is the original
<1255065768-10428-2-git-send-email-spea...@spearce.org>
with some minor changes, as follows:
- fix mis-spelling 'paramterized'
- fix mis-spelling &#x
Drop LF, SP which are defined in RFC 5234.
Replace HT with HTAB (also defined in the RFC).
Use '/' instead of '|', as the RFC does.
Signed-off-by: Tay Ray Chuan
---
Documentation/technical/http-protocol.txt | 26 +-
1 file changed, 9 inserti
From: "Shawn O. Pearce"
Signed-off-by: Tay Ray Chuan
--
To Shawn: sign-off-by needed.
Based on:
From: "Shawn O. Pearce"
Message-ID: <20091016142135.gr10...@spearce.org>
Mike Hommey wrote:
> On Thu, Oct 15, 2009 at 10:59:25PM -0700, H. Peter Anvin wrote:
This patch series are the changes based on the discussion on Shawn's
original text [1]. Some of them are minor, while some may potentially
change behaviour; see below for a classification of the changes.
Hopefully they can be examined by the git contributors here.
An earlier iteration of this patc
Signed-off-by: Tay Ray Chuan
---
Documentation/technical/http-protocol.txt | 17 +++--
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/Documentation/technical/http-protocol.txt
b/Documentation/technical/http-protocol.txt
index 70a1648..55753bb 100644
--- a
From: Junio C Hamano
It is unclear if '?' can be part of $GIT_URL. E.g.
$ wget http://example.xz/serve.cgi?path=git.git/info/refs
$ git clone http://example.xz/serve.cgi?path=git.git
Signed-off-by: Tay Ray Chuan
--
Notes:
- said "request to" instead of Junio'
From: Nguyễn Thái Ngọc Duy
Signed-off-by: Tay Ray Chuan
Signed-off-by: Nguyễn Thái Ngọc Duy
--
Subject crafted by Ray Chuan, Nguyễn's s-o-b lifted from
<1377092713-25434-1-git-send-email-pclo...@gmail.com>.
---
Documentation/technical/http-protocol.txt | 3 ++-
1 file changed, 2
From: "Shawn O. Pearce"
Signed-off-by: Tay Ray Chuan
--
To Shawn: sign-off-by needed.
Based on the discussion in
<20091009195035.ga15...@coredump.intra.peff.net>,
<20091015165228.go10...@spearce.org> (patch),
<20091015173902.ga22...@sigill.intra.peff.net> (
. I know it is "from the
repository served by the server", but if it were named without
"upload-pack", I might have mistaken that you are allowing to proxy a
request to access a third-party repository by this server. The same
comment applies to the git-receiv
Shift details like ABNF from the client section to server section. This
is in line with the smart analogue.
Signed-off-by: Tay Ray Chuan
---
Documentation/technical/http-protocol.txt | 49 +++
1 file changed, 23 insertions(+), 26 deletions(-)
diff --git a
Add LF for responses.
For smart interactions, add pkt-line lengths and the flush-pkt () line.
Drop the SP that followed NUL before capability list.
Signed-off-by: Tay Ray Chuan
---
Documentation/technical/http-protocol.txt | 35 ---
1 file changed, 18
mind-boggling setups.
While providing an example $GIT_URL containing a '?' (the catch-all
gateway one), also mention a possible contradiction between the
exactly-one-param requirement and the http client implementation in Git.
Signed-off-by: Tay Ray Chuan
---
Documentation/technic
Use obj-id in lieu of id (defined as 40*HEX).
Use zero-id in lieu of 40*"0".
Use refname in lieu of name (not defined).
Drop section on capabilities, since they are already available in
protocol-capabilities.txt.
Signed-off-by: Tay Ray Chuan
--
pkt-line format section was dropped i
Indent client/server query examples with 3 spaces.
Indent ABNF rules with 2 spaces.
Signed-off-by: Tay Ray Chuan
--
This is in its own patch to minimize noise in diffs.
---
Documentation/technical/http-protocol.txt | 226 +++---
1 file changed, 113 insertions(+), 113
e is misleading, and the second sentence is also an inappropriate
advice.
Signed-off-by: Tay Ray Chuan
---
Documentation/technical/http-protocol.txt | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/Documentation/technical/http-protocol.txt
b/Documentation/techn
On Fri, Sep 6, 2013 at 10:27 AM, Tim Chase wrote:
> I've got a pretty good grasp on git's rather straightforward
> branching, but am trying to wrap my head around Mercurial's
> branching. There seem to be several flavors, some default to
> push-public, while others are private; some are tracked i
On Wed, May 15, 2013 at 3:37 AM, Torsten Bögershausen wrote:
> Second,
> I was able to do some testing.
> The hanging is not 100% reproducable, and I had one hanging in Git 1.8.1
>
> Turning the screen saver off in Win XP helps that the machine reacts,
> and using process explorer showed that the
Hi,
You need to start Terminal to use git. eg.
$ git init foo
creates a git repo in the folder named foo.
You can get a GUI to run git too: http://git-scm.com/downloads/guis
--
Cheers,
Ray Chuan
On Fri, May 10, 2013 at 1:49 PM, Esther Hwang wrote:
> Hi,
>
> I just installed the latest Git
Hi,
Is the GIT_EDITOR or EDITOR environment variable set? They may be
overriding the core.editor setting.
--
Cheers,
Ray Chuan
On Fri, Apr 26, 2013 at 3:39 PM, Thorsten Jolitz wrote:
>
> Hi List,
>
> after experiencing one crash to many, I'm back to Standard Emacs
> (instead of Emacsserver/Emac
On Fri, Feb 1, 2013 at 5:00 PM, TJ wrote:
> Using Ubuntu Precise 12.04 with git version (1.8.0.3) I discovered a bug
> whereby git-clone deletes the repository
> it has just created if there is a GnuTLS error after the final transfer.
>
> I switched to building and using the current git head
> (
On Thu, Apr 11, 2013 at 6:36 PM, John Tapsell wrote:
> I noticed that code that you put in merge will not be visible by
> default. This seems like a pretty horrible security problem, no?
>
> I made the following test tree, with just 3 commits:
>
> https://github.com/johnflux/ExampleEvilness.git
On Wed, Apr 10, 2013 at 4:40 PM, Jeremy Rosen wrote:
> is there some way to know how far you are within a rebase when the rebase is
> interupted by a conflict other than the message given by git rebase when it
> was interrupted ?
How about
$ cat .git/rebase-merge/done
sample output:
p 3b
On Wed, Mar 20, 2013 at 8:44 PM, Ramkumar Ramachandra
wrote:
> remote.c: introduce remote.pushdefault
> remote.c: introduce branch..pushremote
Perhaps we should clarify how this differs from remote.pushurl in the
documentation for it, in git-config and/or git-push. Maybe even
include the desi
On Wed, Mar 20, 2013 at 8:45 PM, Ramkumar Ramachandra
wrote:
> This new configuration variable overrides `remote.pushdefault` and
> `branch..remote` for pushes. In a typical triangular-workflow
> setup, you would want to set `remote.pushdefault` to specify the
> remote to push to for all branches
On Fri, Mar 1, 2013 at 10:39 PM, wrote:
> Is there some way to get 'git fetch'
> to be more verbose?
It seems that the remote is running the 'dumb' http protocol, you
might want to try setting the GIT_CURL_VERBOSE environment variable
for more verbosity.
Have you tried running git-update-server
On Sun, Feb 3, 2013 at 10:37 PM, John Keeping wrote:
> When compiling combine-diff.c, clang 3.2 says:
>
> combine-diff.c:1006:19: warning: adding 'int' to a string does not
> append to the string [-Wstring-plus-int]
> prefix = COLONS + offset;
>
On Thu, Nov 1, 2012 at 11:29 AM, Lars Gullik Bjønnes wrote:
> Ramkumar Ramachandra writes:
>
> | Hi,
>>
> | Some of my colleagues are lazy to fire up an editor and write proper
> | commit messages- they often write one-liners using `git commit -m`.
> | However, that line turns out to be longer th
On Tue, Aug 7, 2012 at 8:35 AM, Jeff King wrote:
> Subject: [PATCH] terminal: seek when switching between reading and writing
>
> When a stdio stream is opened in update mode (e.g., "w+"),
> the C standard forbids switching between reading or writing
> without an intervening positioning function.
On Mon, Aug 6, 2012 at 7:17 AM, Ben Walton wrote:
> I've also briefly dabbled with getting Solaris to simply use the
> HAVE_DEV_TTY code path but the terminal echo stuff hasn't worked
> nicely for me just yet. (It reads the password with nothing echoed
> but then displays the string after reading
2:push
[N/1/2/...]
This prompt is enabled only if help.autocorrect is set to ask; if unset,
advise the user about this ability.
Helped-by: Thomas Rast
Signed-off-by: Tay Ray Chuan
---
Changed in v3:
- say do_* instead of shall_*
- use new terminal interface
Documentation/c
getpass() uses them both.
Signed-off-by: Tay Ray Chuan
---
compat/terminal.c | 52
compat/terminal.h | 10 ++
2 files changed, 54 insertions(+), 8 deletions(-)
diff --git a/compat/terminal.c b/compat/terminal.c
index 6d16c8f..c85d5c7 100644
As discussed in the previous iteration, testing for prompt-availabilty
has been reworked (patch #2).
This is done with the aid of patch #1, which extracts the opening of
/dev/tty from git_terminal_prompt() into a terminal_open(). Its return
value indicates if a terminal is available for prompting.
On Thu, Jul 26, 2012 at 1:57 AM, Junio C Hamano wrote:
>
> Tay Ray Chuan writes:
>
> > If suggestions are available (based on Levenshtein distance) and if the
> > terminal isatty(), present a prompt to the user to select one of the
> > computed suggestions.
>
2:push
[N/1/2/...]
This prompt is enabled only if help.autocorrect is set to ask; if unset,
advise the user about this ability.
Signed-off-by: Tay Ray Chuan
---
Changed in v2: implement Thomas' idea [1] to hijack help.autocorrect to
configure this behaviour.
[1] <878vh4con4@t
the config is set; fix this.
Signed-off-by: Tay Ray Chuan
---
Changed in v2: plug leak when help.autocorrect is not set.
---
help.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/help.c b/help.c
index dfb2e9d..ee261f4 100644
--- a/help.c
+++ b/help.c
@@ -362,8 +362,7 @@
o longer accessible
anyway.
Signed-off-by: Tay Ray Chuan
---
help.c | 20 ++--
1 file changed, 18 insertions(+), 2 deletions(-)
diff --git a/help.c b/help.c
index 6991492..dfb2e9d 100644
--- a/help.c
+++ b/help.c
@@ -20,6 +20,17 @@ void add_cmdname(struct cmdnames *cmds, const ch
just copied it into place).
3. A pointer to an equivalent string (i.e., we rejected i-1 _because_
it was identical to j-1).
Signed-off-by: Jeff King
Signed-off-by: Tay Ray Chuan
---
Changed in v2: used Jeff's code from [1]. Patch text was also based on
it.
[1] <20120506081
lt;878vh4con4@thomas.inf.ethz.ch>
Jeff King (1):
help.c::uniq: plug a leak
Tay Ray Chuan (3):
help.c::exclude_cmds: realloc() before copy, plug a leak
help.c: plug leaks with(out) help.autocorrect
allow recovery from command name typos
Documentation/config.txt | 30
advice.c
63 matches
Mail list logo
