Hello everyone,
I'm Tamer Tas. I am studying computer engineering in Turkey.
I'm about to complete my junior year in Middle East Technical University.
After setting up my git development environment,
I've submitted patches to a microproject [1][2][3]. I'm still getting feedbacks
on
the microproj
Hello everyone,
I'm Tamer Tas. I am studying computer engineering in Turkey.
I'm about to complete my junior year in Middle East Technical University.
After setting up my git development environment,
I've submitted patches to a microproject [1][2][3]. I'm still getting feedbacks
on
the microproj
Hello everyone,
I'm Tamer Tas. I am studying computer engineering in Turkey.
I'm about to complete my junior year in Middle East Technical University.
After setting up my git development environment,
I've submitted patches to a microproject [1][2][3]. I'm still getting feedbacks
on
the microproj
Signed-off-by: TamerTas
---
Thanks again for the feedback it's been a great learning experience. Comments
Below :)
I have refactored the commit [1] to * suggested changes [2].
format-patch was placing 2 hyphens instead of 3 but it's fixed now.
I've turned the table into a multi
Signed-off-by: TamerTas
--
Thanks for the feedback. Comments below.
I've made the suggested changes [1] to patch [2]
but, since there are different number of format
specifiers, an if-else clause is necessary.
Removing the if-else chain completely doesn't seem to be possible.
So
blems.
Please let me know if there is any problems that I missed.
I would also love to learn if you think that the code was better
before and why it was better.
TamerTas (1):
changed logical chain in branch.c to lookup tables
branch.c | 31 ---
1 file changed,
Signed-off-by: TamerTas
---
branch.c | 31 ---
1 file changed, 8 insertions(+), 23 deletions(-)
diff --git a/branch.c b/branch.c
index 723a36b..397edd3 100644
--- a/branch.c
+++ b/branch.c
@@ -50,6 +50,9 @@ static int should_setup_rebase(const char *origin)
void
7 matches
Mail list logo