Re: Regression: git no longer works with musl libc's regex impl

2016-10-04 Thread Ray Donnelly
On Tue, Oct 4, 2016 at 6:16 PM, Johannes Schindelin wrote: > Hi Rich, > > On Tue, 4 Oct 2016, Rich Felker wrote: > >> On Tue, Oct 04, 2016 at 06:08:33PM +0200, Johannes Schindelin wrote: >> > Hi Rich, >> > >> > On Tue, 4 Oct 2016, Rich Felker wrote: >> > >> > > On Tue, Oct 04, 2016 at 11:27:22AM -

Re: [PATCH 16/19] mingw: avoid absolute path in t0008

2016-01-25 Thread Ray Donnelly
On Mon, Jan 25, 2016 at 4:48 PM, Johannes Schindelin wrote: > Hi Junio, > > On Sun, 24 Jan 2016, Junio C Hamano wrote: > >> Johannes Schindelin writes: >> >> > From: Pat Thoyts >> > >> > The test separator char is a colon which means any absolute paths on >> > Windows confuse the tests that use

Re: [PATCH 1/2] test-path-utils.c: remove incorrect assumption

2015-10-09 Thread Ray Donnelly
On Fri, Oct 9, 2015 at 2:05 AM, Junio C Hamano wrote: > I'll squash this in as part of your first patch that removes the > test from test-path-utils.c. That makes it clearer why it is the > right thing to remove the test, I'd think. > Great, many thanks! > Thanks. > -- To unsubscribe from this

Re: [PATCH 1/2] test-path-utils.c: remove incorrect assumption

2015-10-08 Thread Ray Donnelly
On Mon, Oct 5, 2015 at 12:36 AM, Ray Donnelly wrote: > On Sun, Oct 4, 2015 at 6:21 PM, Junio C Hamano wrote: >> Ray Donnelly writes: >> >>>> Some callers of this function in real code (i.e. not the one you are >>>> removing the check) do seem to depend on

Re: [PATCH 1/2] test-path-utils.c: remove incorrect assumption

2015-10-04 Thread Ray Donnelly
On Sun, Oct 4, 2015 at 6:21 PM, Junio C Hamano wrote: > Ray Donnelly writes: > >>> Some callers of this function in real code (i.e. not the one you are >>> removing the check) do seem to depend on that condition, e.g. the >>> codepath in clone that leads to

Re: [PATCH 1/2] test-path-utils.c: remove incorrect assumption

2015-10-04 Thread Ray Donnelly
On Sat, Oct 3, 2015 at 6:13 PM, Junio C Hamano wrote: > Ray Donnelly writes: > >> In normalize_ceiling_entry(), we test that normalized paths end with >> slash, *unless* the path to be normalized was already the root >> directory. >> >> However, normalize_pa

Re: [PATCH 1/2] test-path-utils.c: remove incorrect assumption

2015-10-03 Thread Ray Donnelly
I'm going to have to attach this as a file, git-send-email isn't working for me; apologies. On Sat, Oct 3, 2015 at 1:44 PM, Ray Donnelly wrote: > In normalize_ceiling_entry(), we test that normalized paths end with > slash, *unless* the path to be normalized was already the

[PATCH 1/2] test-path-utils.c: remove incorrect assumption

2015-10-03 Thread Ray Donnelly
things due to MSYS2 ensuring that the converted path maintains the same state as the input path with respect to any final '/'. So let's just forget about this test. It is non-essential to Git's operation, anyway. Ack-by: Johannes Schindelin Signed-off-by: Ray Donnelly --- te

Re: [msysGit] [PATCH 07/14] Fix BASIC_LDFLAGS and COMPAT_CFLAGS for 64bit MinGW-w64

2014-10-09 Thread Ray Donnelly
On Thu, Oct 9, 2014 at 8:22 PM, Johannes Schindelin wrote: > Hi, > > On Wed, 8 Oct 2014, Marat Radchenko wrote: > >> +CC_MACH := $(shell sh -c '$(CC) -dumpmachine 2>/dev/null || echo not') > > There is a rather huge problem with that. The latest mingw-w64 release, > 4.9.1, does not do what you exp