[PATCH v2 2/2] fast-import: fix segfault in store_tree()

Branch tree is NULLified by filedelete command if we are trying to delete root tree. Add sanity check and use load_tree() in that case. Signed-off-by: Maxim Bublis --- fast-import.c | 6 +- t/t9300-fast-import.sh | 4 ++-- 2 files changed, 7 insertions(+), 3 deletions(-) diff

[PATCH v2 0/2] fast-import: fix segfault and filedelete tests

Removing root tree with filedelete command would lead to segmentation fault in store_tree(). First patch from patch series adds filedelete command tests with test case to show incorrect behaviour on filedelete root operation. Second one fixes bug by sanity check and load_tree() usage. Maxim

[PATCH v2 1/2] t9300: test filedelete command

Add new fast-import test series for filedelete command. Signed-off-by: Maxim Bublis --- t/t9300-fast-import.sh | 104 + 1 file changed, 104 insertions(+) diff --git a/t/t9300-fast-import.sh b/t/t9300-fast-import.sh index 5fc9ef2..9cf5e45 100755

Re: [PATCH 2/2] fast-import: fix segfault in store_tree()

On 29 авг. 2014 г., at 3:16, Junio C Hamano wrote: > Missing ‘;' Thanks, I’ll fix it. What a stupid mistype, I was writing some amount of Go code recently and it doesn’t use semicolons. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger

Re: [PATCH 1/2] t9300: test filedelete root

On 29 авг. 2014 г., at 2:30, Junio C Hamano wrote: > You may have been concentrating on the "delete root" case, but as > long as you claim "We add a series to test filedelete command", it > would be sensible to test more typical cases of deleting files, not > the entire tree as well, no? Perhaps

[PATCH v2] contrib/svn-fe: fix Makefile

Fixes several problems: * include config.mak.uname, config.mak.autogen and config.mak in order to use settings for prefix and other such things; * link xdiff/lib.a as it is a requirement for libgit.a; * fix CFLAGS, LDFLAGS and EXTLIBS for Linux and Mac OS X. Signed-off-by: Maxim Bublis

[PATCH 1/2] t9300: test filedelete root

Add new fast-import test series for filedelete command. Signed-off-by: Maxim Bublis --- t/t9300-fast-import.sh | 46 ++ 1 file changed, 46 insertions(+) diff --git a/t/t9300-fast-import.sh b/t/t9300-fast-import.sh index 5fc9ef2..3d557b3 100755 --- a

[PATCH 0/2] fast-import: fix segfault and tests

Removing root tree with filedelete command would lead to segmentation fault in store_tree(). First patch from patch series adds test to show incorrect behaviour and second one fixes bug by sanity check and load_tree() usage. Maxim Bublis (2): t9300: test filedelete root fast-import: fix

[PATCH 2/2] fast-import: fix segfault in store_tree()

Branch tree is NULLified by filedelete command if we are trying to delete root tree. Add sanity check and use load_tree() in that case. Signed-off-by: Maxim Bublis --- fast-import.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/fast-import.c b/fast-import.c index

Re: [PATCH] contrib/svn-fe: fix Makefile

On 26 авг. 2014 г., at 13:31, Torsten Bögershausen wrote: > On 08/26/2014 02:44 PM, Maxim Bublis wrote: >> >> + >> +ifeq ($(uname_S),Darwin) >> +CFLAGS += -I/opt/local/include >> +LDFLAGS += -L/opt/local/lib >> +endif >> + >

[PATCH] contrib/svn-fe: fix Makefile

Fixes several problems: * include config.mak.uname, config.mak.autogen and config.mak in order to use settings for prefix and other such things; * link xdiff/lib.a as it is a requirement for libgit.a; * fix CFLAGS and EXTLIBS for Linux and Mac OS X. --- contrib/svn-fe/Makefile | 47 +