[PATCH v3] range-diff: allow to diff files regardless of submodule config

S_ISGITLINK will return true (mode == 016 here). Similar thing happens if submodule.diff is "diff". Do like it's done in grep.c when calling fill_filespec() and force it to be recognized as a file by adding S_IFREG to the mode. Signed-off-by: Lucas De Marchi Acked-by: Johannes Schin

Re: [PATCH] range-diff: allow to diff files regardless submodule

On Wed, Oct 24, 2018 at 02:18:43PM +0900, Junio C Hamano wrote: > Junio C Hamano writes: > > > Lucas De Marchi writes: > > > >> Your reply arrived just a little after I sent the v2, so I thought it > >> was just the race and you would end up seeing the

Re: [PATCH] range-diff: allow to diff files regardless submodule

On Wed, Oct 24, 2018 at 11:12:51AM +0900, Junio C Hamano wrote: > Lucas De Marchi writes: > > >> Yes, I agree on both counts (i.e. it was totally unclear what > >> problem is being solved and what the root cause of the problem is, > >> and we would want a ne

Re: [PATCH] range-diff: allow to diff files regardless submodule

On Thu, Oct 11, 2018 at 05:25:02PM +0900, Junio C Hamano wrote: > Ævar Arnfjörð Bjarmason writes: > > > On Wed, Oct 10 2018, Lucas De Marchi wrote: > > > >> Do like it's done in grep so mode doesn't end up as > >> 016, which means range-diff does

[PATCH v2] range-diff: allow to diff files regardless submodule

iff between the revisions. Signed-off-by: Lucas De Marchi --- range-diff.c | 2 +- t/t3206-range-diff.sh | 29 + 2 files changed, 30 insertions(+), 1 deletion(-) diff --git a/range-diff.c b/range-diff.c index 60edb2f518..bd8083f2d1 100644 --- a/range-diff.c +++

Re: [PATCH] range-diff: allow to diff files regardless submodule

On Thu, Oct 11, 2018 at 12:42 AM Ævar Arnfjörð Bjarmason wrote: > > > On Wed, Oct 10 2018, Lucas De Marchi wrote: > > > Do like it's done in grep so mode doesn't end up as > > 016, which means range-diff doesn't work if one has > > "submod

Re: [PATCH] range-diff: allow to diff files regardless submodule

On Wed, Oct 10, 2018 at 5:02 PM brian m. carlson wrote: > > On Wed, Oct 10, 2018 at 08:09:16AM -0700, Lucas De Marchi wrote: > > Do like it's done in grep so mode doesn't end up as > > 016, which means range-diff doesn't work if one has > > "submodu

[PATCH] range-diff: allow to diff files regardless submodule

iff between the revisions. Signed-off-by: Lucas De Marchi --- range-diff.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/range-diff.c b/range-diff.c index 60edb2f518..bd8083f2d1 100644 --- a/range-diff.c +++ b/range-diff.c @@ -354,7 +354,7 @@ static struct diff_filespec *get_