Re: [PATCH 1/3] sha1dc: update from my PR #36

2017-06-27 Thread Liam R. Howlett
* Junio C Hamano [170627 15:10]: > Ævar Arnfjörð Bjarmason writes: > > > Because in the current code is, abbreviated: > > > > #if (defined(_BYTE_ORDER) || defined(__BYTE_ORDER) || > > defined(__BYTE_ORDER__)) > > #if /* byte order is bendian */ > > #define SHA1DC_BIGENDIAN > > #

Re: Compile Error v2.13.2 on Solaris SPARC

2017-06-27 Thread Liam R. Howlett
* Junio C Hamano [170627 13:38]: > "Liam R. Howlett" writes: > > > How about: > > > > 8< > > diff --git a/sha1dc/sha1.c b/sha1dc/sha1.c > > index facea1bb5..ed8c63f2d 100644 > > --- a/sha1dc/sha1.c > > +++ b/sha1dc/sha1

Re: [PATCH 1/3] sha1dc: update from my PR #36

2017-06-27 Thread Liam R. Howlett
* Junio C Hamano [170627 11:55]: > Junio C Hamano writes: > > >> +#if (defined(__ARMEB__) || defined(__THUMBEB__) || defined(__AARCH64EB__) > >> || \ > >> defined(__MIPSEB__) || defined(__MIPSEB) || defined(_MIPSEB) || \ > >> defined(__sparc)) > >> +/* > >> + * Should define Big End

Re: Compile Error v2.13.2 on Solaris SPARC

2017-06-27 Thread Liam R. Howlett
How about: 8< diff --git a/sha1dc/sha1.c b/sha1dc/sha1.c index facea1bb5..ed8c63f2d 100644 --- a/sha1dc/sha1.c +++ b/sha1dc/sha1.c @@ -38,9 +38,18 @@ #if (defined(_BYTE_ORDER) || defined(__BYTE_ORDER) || defined(__BYTE_ORDER__)) +#define EMPTY_VAL(x) x ## 1 +#define EMPTY(x) EMPTY_

Re: Compile Error v2.13.2 on Solaris SPARC

2017-06-26 Thread Liam R. Howlett
* ?var Arnfj?r? Bjarmason [170626 08:47]: > > On Mon, Jun 26 2017, Michael Kebe jotted: > > > No luck with the patch. > > > > Still got: > > > > CC sha1dc/sha1.o > > sha1dc/sha1.c:43:58: error: operator '==' has no right operand > > (defined(_BYTE_ORDER) && (_BYTE_ORDER == _BIG_ENDIAN)

Re: [PATCH 0/3] update sha1dc

2017-06-12 Thread Liam R. Howlett
* ?var Arnfj?r? Bjarmason [170606 11:12]: > This updates sha1dc fixing the issue on Cygwin introduced in 2.13.1, > and hopefully not regressing elsewhere. Liam, it would be much > appreciated if you could test this on SPARC. Tested and confirmed this works for SPARC with no build flags. Sorry fo

Re: Unaligned accesses in sha1dc

2017-06-02 Thread Liam R. Howlett
* ?var Arnfj?r? Bjarmason [170602 04:53]: > On Fri, Jun 2, 2017 at 2:15 AM, Junio C Hamano wrote: > > Martin Ågren writes: > > > >> I looked into this some more. It turns out it is possible to trigger > >> undefined behavior on "next". Here's what I did: > >> ... > >> > >> This "fixes" the probl

Re: 2.13.0-rc1 is broken on SPARC

2017-05-30 Thread Liam R. Howlett
* Junio C Hamano [170529 00:11]: > "Liam R. Howlett" writes: > > > My SPARC build does not function and seg bus terminates on any command. > > Sorry, known issue in the released version 2.13 (we would have > appreciated if a bug report for -rc1 came way before

2.13.0-rc1 is broken on SPARC

2017-05-28 Thread Liam R. Howlett
Hello, My SPARC build does not function and seg bus terminates on any command. I have worked out the commit is the one that switched the default SHA1 code to sha1dc - commit e6b07da2780f349c29809bd75d3eca6ad3c35d19. I managed to get it working by following the instructions on updating the library