Re: [PATCH] git-sh-setup.sh: fix missing double quotes variables

2016-06-19 Thread LE Manh Cuong
It's really a good commit message, better than mine. So must I make another patch or you will update the commit message? PS: This is the first time I submit a patch to Git, so forgive me if I made any silly questions. -- To unsubscribe from this list: send the line "unsubscribe git" in the body o

Re: [PATCH] git-sh-setup.sh: fix missing double quotes variables

2016-06-19 Thread LE Manh Cuong
> While I think enclosing the string in dq is an improvement (as I > said already), I still do think your use of the v-word is making a > mountain out of an anthill. Well, sorry if that word is annoyed. So, is this patch fine or I must re-phrase the title? -- To unsubscribe from this list: send t

Re: [PATCH] git-sh-setup.sh: fix missing double quotes variables

2016-06-18 Thread LE Manh Cuong
> Given that LESS, LV and GIT_OBJECT_DIRECTORY are expected to be free > of any "expensive to expand" strings, I am not sure if this actually > matters, though. And more importantly, these are what the end users > are expected to set to whatever sensible values for them. The problem is the end us

[PATCH] git-sh-setup.sh: fix missing double quotes variables

2016-06-18 Thread LE Manh Cuong
=.}' Run it and our machine will hang/crash (especially in Linux). `LESS`, `LV` and `GIT_OBJECT_DIRECTORY` variables in `git-sh-setup` are vulnerable with this case. Fix this vulnerability by quoting those variables. Signed-off-by: LE Manh Cuong --- git-sh-setup.sh | 6 +++--- 1 file ch

[no subject]

2016-06-18 Thread LE Manh Cuong
Sorry, the example in commit message is wrong, due to editor auto wrapping line. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] git-sh-setup.sh: fix missing double quotes variables

2016-06-18 Thread LE Manh Cuong
=.}' Run it and our machine will hang/crash (especially in Linux). `LESS`, `LV` and `GIT_OBJECT_DIRECTORY` variables in `git-sh-setup` are vulnerable with this case. Fix this vulnerability by quoting those variables. Signed-off-by: LE Manh Cuong --- git-sh-setup.sh | 6 +++--- 1 file ch