Re: [tig] [PATCHv2 3/3] log: Colour the diff stat

2014-04-16 Thread Kumar Appaiah
On Wed, Apr 16, 2014 at 08:44:41PM -0400, Jonas Fonseca wrote: > On Sun, Apr 13, 2014 at 5:54 PM, Kumar Appaiah > wrote: > > > > This commit adds custom log_read and log_draw functions that utilize > > the diff stat drawing functions from the diff module. The absence

[tig] [PATCHv2 2/3] diff: Move diff stat drawing to a common function

2014-04-13 Thread Kumar Appaiah
Signed-off-by: Kumar Appaiah --- include/tig/diff.h | 1 + src/diff.c | 30 ++ 2 files changed, 19 insertions(+), 12 deletions(-) diff --git a/include/tig/diff.h b/include/tig/diff.h index ba40386..16299fe 100644 --- a/include/tig/diff.h +++ b/include/tig

[tig] [PATCHv2 3/3] log: Colour the diff stat

2014-04-13 Thread Kumar Appaiah
This commit adds custom log_read and log_draw functions that utilize the diff stat drawing functions from the diff module. The absence of the triple hyphen separator prevents direct usage of the diff drawing functions directly. Signed-Off-By: Kumar Appaiah --- src/log.c | 55

[tig] [PATCHv2 0/3] log: colour the diffstat

2014-04-13 Thread Kumar Appaiah
These patches add colourization to the log view. They reuse the diff stat drawing functions from the diff module directly. This version just includes some code reformatting and minor fixes. Please comment on what other fixes could help. Thanks. Kumar Appaiah (3): diff: Move diff stat addition

[tig] [PATCHv2 1/3] diff: Move diff stat addition to a common function

2014-04-13 Thread Kumar Appaiah
Signed-off-by: Kumar Appaiah --- include/tig/diff.h | 1 + src/diff.c | 27 ++- 2 files changed, 19 insertions(+), 9 deletions(-) diff --git a/include/tig/diff.h b/include/tig/diff.h index be325c4..ba40386 100644 --- a/include/tig/diff.h +++ b/include/tig/diff.h

[tig] [PATCH 3/3] log: Colour the diff stat

2014-04-11 Thread Kumar Appaiah
This commit adds custom log_read and log_draw functions that utilize the diff stat drawing functions from the diff module. The absence of the triple hyphen separator prevents direct usage of the diff drawing functions directly. Signed-Off-By: Kumar Appaiah --- src/log.c | 62

[tig] [PATCH 2/3] diff: Move diff stat drawing to a common function

2014-04-11 Thread Kumar Appaiah
Signed-off-by: Kumar Appaiah --- include/tig/diff.h | 1 + src/diff.c | 30 ++ 2 files changed, 19 insertions(+), 12 deletions(-) diff --git a/include/tig/diff.h b/include/tig/diff.h index ba40386..16299fe 100644 --- a/include/tig/diff.h +++ b/include/tig

[tig] [PATCH 1/3] diff: Move diff stat addition to a common function

2014-04-11 Thread Kumar Appaiah
Signed-off-by: Kumar Appaiah --- include/tig/diff.h | 1 + src/diff.c | 27 ++- 2 files changed, 19 insertions(+), 9 deletions(-) diff --git a/include/tig/diff.h b/include/tig/diff.h index be325c4..ba40386 100644 --- a/include/tig/diff.h +++ b/include/tig/diff.h

[tig] [PATCH 0/3] log: colour the diffstat.

2014-04-11 Thread Kumar Appaiah
These patches add colourization to the log view. They reuse the diff stat drawing functions from the diff module directly. Kumar Appaiah (3): diff: Move diff stat addition to a common function diff: Move diff stat drawing to a common function log: Colour the diff stat include/tig/diff.h

Re: [[TIG][PATCH v2] 2/3] Display correct diff the context in split log view

2013-08-06 Thread Kumar Appaiah
On Tue, Aug 06, 2013 at 12:58:20AM -0400, Kumar Appaiah wrote: > tig-1.1 > --- > diff --git a/tig.c b/tig.c > index 845153f..256b589 100644 > --- a/tig.c > +++ b/tig.c > @@ -4475,8 +4475,15 @@ log_request(struct view *view, enum request request, > struct line *lin

[[TIG][PATCH v2] 3/3] Revert "Scroll diff with arrow keys in log view"

2013-08-05 Thread Kumar Appaiah
uses the pager view concept) would expect. Signed-Off-By: Kumar Appaiah Conflicts: tig.c --- tig.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/tig.c b/tig.c index 256b589..5f564a5 100644 --- a/tig.c +++ b/tig.c @@ -1905,7 +1905,6 @@ enum view_flag

[[TIG][PATCH v2] 0/3] Refactoring the log view

2013-08-05 Thread Kumar Appaiah
using the : approach doesn't call log_request, so we need to come up with a smarter way to communicate the line number change, I guess. Thanks for all the feedback! Kumar Appaiah (3): Add log_select function to find commit from context in log view Display correct diff the context in spli

[[TIG][PATCH v2] 1/3] Add log_select function to find commit from context in log view

2013-08-05 Thread Kumar Appaiah
function handles this scenario to do the ``right thing''. In addition, it introduces the log_state structure as the private entry of the log view to hold a flag that decides whether to re-evaluate the current commit based on scrolling. Signed-off-by: Kumar Appaiah ---

[[TIG][PATCH v2] 2/3] Display correct diff the context in split log view

2013-08-05 Thread Kumar Appaiah
, rather than delegating it to pager_request. In addition, it also gets rid of unexpected upward scrolling of the log view. Fixes GH #155 Signed-Off-By: Kumar Appaiah --- NEWS | 1 + tig.c | 9 - 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 076ac9d..1b0f737

Re: [[TIG][PATCH] 1/3] Add log_select function to find commit from context in log view

2013-08-05 Thread Kumar Appaiah
Dear Jonas, Thanks for the patient review. On Mon, Aug 05, 2013 at 11:27:44PM -0400, Jonas Fonseca wrote: > On Fri, Aug 2, 2013 at 8:23 PM, Kumar Appaiah > wrote: > > This commit introduces and uses the log_select function to find the > > correct commit in the unsplit log vie

[[TIG][PATCH] 1/3] Add log_select function to find commit from context in log view

2013-08-02 Thread Kumar Appaiah
function handles this scenario to to the ``right thing''. In addition, it introduces the log_state structure as the private entry of the log view to hold a flag that decides whether to re-evaluate the current commit based on scrolling. Signed-off-by: Kumar Appaiah ---

[[TIG][PATCH] 2/3] Display correct diff the context in split log view

2013-08-02 Thread Kumar Appaiah
, rather than delegating it to pager_request. In addition, it also gets rid of unexpected upward scrolling of the log view. Fixes GH #155 Signed-Off-By: Kumar Appaiah --- NEWS | 1 + tig.c | 12 2 files changed, 13 insertions(+) diff --git a/NEWS b/NEWS index 0394407..f59e517 100644

[[TIG][PATCH] 3/3] Revert "Scroll diff with arrow keys in log view"

2013-08-02 Thread Kumar Appaiah
uses the pager view concept) would expect. Signed-Off-By: Kumar Appaiah Conflicts: tig.c --- tig.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/tig.c b/tig.c index 53947b7..65c91a0 100644 --- a/tig.c +++ b/tig.c @@ -1901,7 +1901,6 @@ enum view_flag

[TIG][PATCH 0/3] Refactoring of the log view

2013-08-02 Thread Kumar Appaiah
updated scrolling pattern is much more consistent. As always, I will gladly alter the patch based on comments on coding style and all other aspects. Thanks! Kumar Kumar Appaiah (3): Add log_select function to find commit from context in log view Display correct diff the context in split log view

Re: [TIG][PATCH] Scroll diff with arrow keys in log view

2013-08-01 Thread Kumar Appaiah
On Thu, Aug 01, 2013 at 10:01:58PM -0400, Jonas Fonseca wrote: > On Wed, Jul 31, 2013 at 11:11 PM, Kumar Appaiah > wrote: > > This commit introduces the VIEW_NO_PARENT_NAV flag and adds it to the > > log view. This allows the scrolling commands to fall through from the > >

[PATCH] Scroll diff with arrow keys in log view

2013-07-31 Thread Kumar Appaiah
This commit introduces the VIEW_NO_PARENT_NAV flag and adds it to the log view. This allows the scrolling commands to fall through from the pager to the diff when the diff is viewed in the log mode. Signed-Off-By: Kumar Appaiah --- tig.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions