On Wed, Sep 28, 2016 at 10:54:52AM -0700, Junio C Hamano wrote:
>
> I just got an impression that you were apologetic for having to add
> this option that is otherwise useless and tried to suggest a simpler
> solution that does not involve such an addition.
Sorry, to be clear, I meant I was ok wi
On Mon, Sep 19, 2016 at 08:52:34PM +0700, Duy Nguyen wrote:
>
> A brief overview for this service in
> Documentation/technical/http-protocol.txt (and maybe
> Documentation/gitremote-helpers.txt as well) would be great help. It's
> a bit hard to follow because at this point I don't know anything ab
On Fri, Sep 16, 2016 at 03:45:44PM -0700, Junio C Hamano wrote:
> > @@ -1136,7 +1138,10 @@ static int handle_curl_result(struct slot_results
> > *results)
> > curl_easy_strerror(results->curl_result),
> > sizeof(curl_errorstr));
> > #endif
>
On Fri, Sep 16, 2016 at 04:32:05PM -0700, Junio C Hamano wrote:
> > ---
> > @@ -172,6 +173,12 @@ objects from the source repository into a pack in the
> > cloned repository.
> > via ssh, this specifies a non-default path for the command
> > run on the other end.
> >
> > +--prime
On Fri, Sep 16, 2016 at 04:07:00PM -0700, Junio C Hamano wrote:
> Kevin Wern writes:
>
> > Add option RUN_COMMAND_NO_STDOUT, which sets no_stdout on a child
> > process.
> >
> > This will be used by git clone when calling index-pack on a downloaded
> > pac
On Mon, Sep 19, 2016 at 09:04:40PM +0700, Duy Nguyen wrote:
> On Fri, Sep 16, 2016 at 7:12 AM, Kevin Wern wrote:
> > builtin/clone.c | 590
> > +---
>
> Argh.. this is too big for my brain at this hour. It might be easi
On Mon, Sep 19, 2016 at 08:15:00PM +0700, Duy Nguyen wrote:
> We also have an exception for select_getanyfile() below. I think it's
> time we add a function callback in struct rpc_service to run each
> service the way they want. Then prime-clone won't need an exception
> (neither does select_anyfil
On Fri, Sep 16, 2016 at 03:17:28PM -0700, Junio C Hamano wrote:
> Kevin Wern writes:
>
> > /* And complain if we didn't get enough bytes to satisfy the read. */
> > if (ret < size) {
> > - if (options & PACKET_READ_GENTLE
On Fri, Sep 16, 2016 at 01:53:15PM -0700, Junio C Hamano wrote:
> Kevin Wern writes:
>
> > Create git-prime-clone, a program to be executed on the server that
> > returns the location and type of static resource to download before
> > performing the rest of a clone.
>
Add method for transport to call when parsing primeclone output from
stdin. Suppress stderr when using git_connect with ssh, unless output
is verbose.
Signed-off-by: Kevin Wern
---
connect.c | 47 +++
connect.h | 10 ++
2 files changed, 53
verbosely. Therefore, all error parsing is
done with remote-curl, and any protocol breach between remote-curl and
transport-helper will treated as a bug and result in death.
Signed-off-by: Kevin Wern
---
transport-helper.c | 51 ++-
transport.c
ll be downloaded to. The url passed to remote-curl on
invocation does not matter (git clone will use the resource url
again here).
Signed-off-by: Kevin Wern
---
http.c| 86 ++-
http.h| 7 -
remote-curl.c | 27 +
, and leaving a resumable
directory on exit--the logic for when to do these still needs more
work.
Signed-off-by: Kevin Wern
---
Documentation/git-clone.txt | 16 ++
builtin/clone.c | 590 +---
t/t9904-git-prime-clone.sh | 181 +++
Create function to get gitdir file RESUMABLE.
Signed-off-by: Kevin Wern
---
cache.h | 1 +
path.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/cache.h b/cache.h
index d7ff46e..1f4117c 100644
--- a/cache.h
+++ b/cache.h
@@ -811,6 +811,7 @@ const char *git_path_merge_mode(void);
const
Create function transport_download_primer and components
to invoke and pass commands to remote-curl.
Signed-off-by: Kevin Wern
---
transport-helper.c | 24
transport.c| 9 +
transport.h| 7 +++
3 files changed, 40 insertions(+)
diff --git
Add option RUN_COMMAND_NO_STDOUT, which sets no_stdout on a child
process.
This will be used by git clone when calling index-pack on a downloaded
packfile.
Signed-off-by: Kevin Wern
---
run-command.c | 1 +
run-command.h | 1 +
2 files changed, 2 insertions(+)
diff --git a/run-command.c b/run
case.
Signed-off-by: Kevin Wern
---
remote-curl.c | 165 ++
1 file changed, 121 insertions(+), 44 deletions(-)
diff --git a/remote-curl.c b/remote-curl.c
index 15e48e2..8ebb587 100644
--- a/remote-curl.c
+++ b/remote-curl.c
@@ -13,6 +13,8
am to
BINDIR_PROGRAMS_NEED_X, in addition to the usual builtin places. Add
git-prime-clone executable to gitignore, as well
Signed-off-by: Kevin Wern
---
.gitignore| 1 +
Documentation/git-prime-clone.txt | 39
Makefile | 2 +
buil
Add logic to serve git-prime-clone to git and http clients.
Do not pass --stateless-rpc and --advertise-refs options to
prime-clone. It is inherently stateless and an 'advertisement'.
Signed-off-by: Kevin Wern
---
Documentation/git-daemon.txt | 7 +++
Documentatio
Create a functions that can read malformed messages without dying.
Includes creation of flag PACKET_READ_GENTLE_ALL. For use handling
prime-clone (or other server error) responses.
Signed-off-by: Kevin Wern
---
pkt-line.c | 47 ++-
pkt-line.h | 16
e been actively working on, but I'm
hitting a point where keeping everyone up-to-date trumps completeness.
Hopefully, the bulk of the 'learning and re-doing' is done and I can
update more frequently in smaller increments.
I will probably work on the git-daemon download service,
Create a bare-bones version of git-prime-clone, which returns the
location of an alternate resource specified by the server that the
client should fetch and build before returning to perform an incremental
fetch.
At this point, no validation is performed of the file's existence, the
file's validit
Add endpoints for prime-clone in http service and git daemon
---
daemon.c | 7 +++
http-backend.c | 1 +
2 files changed, 8 insertions(+)
diff --git a/daemon.c b/daemon.c
index 8d45c33..2ddc7f7 100644
--- a/daemon.c
+++ b/daemon.c
@@ -475,10 +475,17 @@ static int receive_pack(void)
esign considerations I missed, and I want to keep
this as easily extensible to the other types as possible.
Apologies for not keeping everyone in the loop. I should be working on this
more actively from this point onwards.
-Kevin Wern
--
[PATCH 1/2] Resumable clone: create git-prime-clone (
Junio,
> Yes, that is very close to what I said in the "what remains?"
> section, but with a crucial difference in a detail. Perhaps reading
> the message you are respoinding to again more carefully will clear
> the confusion. This is what we want to allow the server to say
> (from the message y
Hey Junio and Duy,
Thank you for your thorough responses! I'm new to git dev, so it's
extremely helpful.
> - The server side endpoint does not have to be, and I think it
> should not be, implemented as an extension to the current
> upload-pack protocol. It is perfectly fine to add a new "git
> pr
Hey, all,
A while ago, I noticed that if a clone is interrupted, it has to be
restarted completely. When I looked up the issue, I saw that someone
suggested resumable clones as a feature as early as 2007. It doesn't
seem like any progress has been made on this issue, so I began looking
at relevan
27 matches
Mail list logo
