Re: [PATCH 4/7] commit: fix patch hunk editing with

2014-03-11 Thread Jun Hao
Jeff King peff.net> writes: > > Ah, you're right. I was thinking that our invocation of launch_editor > also respected it. It does, but we never get there at all because > use_editor is set to 0. So yeah, it really is just needed for the hook. > > Your patch, even though it is a bigger change,

Re: [PATCH 4/7] commit: fix patch hunk editing with "commit -p -m"

2014-03-10 Thread Jun Hao
gt; 9 files changed, 79 insertions(+), 31 deletions(-) > > This is a lot of change, and in some ways I think it is making things > better overall. However, the simplest fix for this is basically to move > the setting of GIT_EDITOR down to after we prepare the index. > > Jun Hao