Re: [PATCH] Fix urlencode format string on signed char.

2017-12-22 Thread Julien Dusser
Thank you for review. I didn't find any other error. Code in http.c:quote_ref_url() is almost the same but ch is a signed int, so there's no issue. Le 22/12/2017 à 22:48, Junio C Hamano a écrit : Julien Dusser writes: Git credential fails with special char in password. remot

[PATCH] Fix urlencode format string on signed char.

2017-12-22 Thread Julien Dusser
. Signed-off-by: Julien Dusser --- strbuf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/strbuf.c b/strbuf.c index 323c49ceb..4d5a9ce55 100644 --- a/strbuf.c +++ b/strbuf.c @@ -658,7 +658,7 @@ static void strbuf_add_urlencode(struct strbuf *sb, const char *s, size_t len