gitk: bug viewing diffs with the word items

;t know if any other magic words are affected ied it with the master bug confirmed exists in github/git/git/master I created a small repository that shows the error for me: clone it to reproduce the behavior https://github.com/d4ddi0/gitk_diff_view ~Joshua Clayton

[PATCHv3] Fix in Git.pm cat_blob crashes on large files

ned-off-by: Joshua Clayton Reviewed-by: Jeff King Reviewed-by: Junio C Hamano --- perl/Git.pm | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/perl/Git.pm b/perl/Git.pm index 931047c..db6e0a8 100644 --- a/perl/Git.pm +++ b/perl/Git.pm @@ -942,20 +942,22 @@

Re: [PATCH] Fix in Git.pm cat_blob crashes on large files (resubmit with reviewed-by)

Thanks for all the input and patience. On Fri, Feb 22, 2013 at 10:34 AM, Jeff King wrote: > On Fri, Feb 22, 2013 at 09:30:57AM -0800, Joshua Clayton wrote: > >> Read and write each 1024 byte buffer, rather than trying to buffer >> the entire content of the file. > > OK.

[PATCH] Fix in Git.pm cat_blob crashes on large files (resubmit with reviewed-by)

it might crash before reaching 2 GiB due to memory exhaustion. Signed-off-by: Joshua Clayton Reviewed-by: Jeff King --- perl/Git.pm | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/perl/Git.pm b/perl/Git.pm index 931047c..cc91288 100644 --- a/perl/Git.pm +++ b/p

[PATCH] Fix in Git.pm cat_blob crashes on large files (reviewed by Jeff King)

it might crash before reaching 2 GiB due to memory exhaustion. Signed-off-by: Joshua Clayton --- perl/Git.pm | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/perl/Git.pm b/perl/Git.pm index 931047c..cc91288 100644 --- a/perl/Git.pm +++ b/perl/Git.pm @@ -949,13 +949

Re: [PATCH] Fix in Git.pm cat_blob crashes on large files

12m36.275s sys 24m26.112s ...so the simpler code wins the trivial test. I would say go with it. Should I resubmit? On Thu, Feb 21, 2013 at 3:24 PM, Jeff King wrote: > On Thu, Feb 21, 2013 at 03:18:40PM -0800, Joshua Clayton wrote: > >> > By having the read and flush size be the

Re: [PATCH] Fix in Git.pm cat_blob crashes on large files

On Thu, Feb 21, 2013 at 2:43 PM, Jeff King wrote: > On Thu, Feb 21, 2013 at 02:13:32PM -0800, Joshua Clayton wrote: > >> Greetings. >> This is my first patch here. Hopefully I get the stylistic & political >> details right... :) >> Patch applies against maint a

[PATCH] Fix in Git.pm cat_blob crashes on large files

with low memory it may crash before reaching 2 GiB due to memory exhaustion. Fix writes in smaller 64K increments. Tested to work on git svn fetch Signed-off-by: Joshua Clayton --- perl/Git.pm | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/perl/Git.